ACPI / bus: Remove checks in acpi_get_match_data()
PATCH v2 3/6 ACPI / bus: Remove checks in acpi_get_match_data()
Quoted 24 lines · Rafael J. Wysocki
Quoted 21 lines · Andy Shevchenko
Quoted 20 lines · Andy Shevchenko
As well as its sibling
of_device_get_match_data()has no such checks,
no need to do it inacpi_get_match_data().First of all, we are not supposed to call fwnode API like this without
driver attached.Second, since
__acpi_match_device()does check input parameter there
is
no need to duplicate it outside.Fixes 80212a162329 ("ACPI / bus: Introduce acpi_get_match_data()function")
Cc Sinan Kaya <[email protected]>Cc Sakari Ailus <[email protected]>Cc Vinod Koul <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Quoted 4 lines
Quoted 2 lines
rhaps I have to add that this conditional prevents
device_get_match_data()to work on PRP0001 devices AFAIU.Yes, please.
OK.
Quoted 1 line
I'm also not sure if the Fixes: tag is really applicable to this.
We can of course drop it, I put it here in a hope that this series would be material to v4.16-rc2 to fix an introduced API.