Patch "x86/spectre: Simplify spectre_v2 command line parsing" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
x86/spectre: Simplify spectre_v2 command line parsing
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
x86-spectre-simplify-spectre_v2-command-line-parsing.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Feb 8 03:32:24 CET 2018
From: KarimAllah Ahmed <[email protected]>
Date: Thu, 1 Feb 2018 11:27:21 +0000
Subject: x86/spectre: Simplify spectre_v2 command line parsing
From: KarimAllah Ahmed <[email protected]>
(cherry picked from commit 9005c6834c0ffdfe46afa76656bd9276cca864f6)
[dwmw2: Use ARRAY_SIZE]
--- arch/x86/kernel/cpu/bugs.c | 84 +++++++++++++++++++++++++++++---------------- 1 file changed, 55 insertions(+), 29 deletions(-)
arch/x86/kernel/cpu/bugs.c +55 -29
@@ -118,13 +118,13 @@ static inline const char *spectre_v2_modstatic void __init spec2_print_if_insecure (const char *reason) {if (boot_cpu_has_bug (X86_BUG_SPECTRE_V2 )) -pr_info ("%s\n" , reason); +pr_info ("%s selected on command line.\n" , reason); }static void __init spec2_print_if_secure (const char *reason) {if (!boot_cpu_has_bug (X86_BUG_SPECTRE_V2 )) -pr_info ("%s\n" , reason); +pr_info ("%s selected on command line.\n" , reason); }static inline bool retp_compiler (void )
@@ -139,42 +139,68 @@ static inline bool match_option(const chreturn len == arglen && !strncmp (arg, opt, len); } +static const struct { +const char *option; +enum spectre_v2_mitigation_cmd cmd; +bool secure; +} mitigation_options[] = { + {"off" ,SPECTRE_V2_CMD_NONE , false }, + {"on" ,SPECTRE_V2_CMD_FORCE , true }, + {"retpoline" ,SPECTRE_V2_CMD_RETPOLINE , false }, + {"retpoline,amd" ,SPECTRE_V2_CMD_RETPOLINE_AMD , false }, + {"retpoline,generic" ,SPECTRE_V2_CMD_RETPOLINE_GENERIC , false }, + {"auto" ,SPECTRE_V2_CMD_AUTO , false }, +}; +static enum spectre_v2_mitigation_cmd __init spectre_v2_parse_cmdline (void ) {char arg[20 ]; -int ret; +int ret, i; +enum spectre_v2_mitigation_cmd cmd =SPECTRE_V2_CMD_AUTO ; + +if (cmdline_find_option_bool (boot_command_line,"nospectre_v2" )) +return SPECTRE_V2_CMD_NONE ; +else { + ret =cmdline_find_option (boot_command_line,"spectre_v2" , arg, +sizeof (arg)); +if (ret <0 ) +return SPECTRE_V2_CMD_AUTO ; - ret =cmdline_find_option (boot_command_line,"spectre_v2" , arg, -sizeof (arg)); -if (ret >0 ) { -if (match_option (arg, ret,"off" )) { - goto disable; - }else if (match_option (arg, ret,"on" )) { -spec2_print_if_secure ("force enabled on command line." ); -return SPECTRE_V2_CMD_FORCE ; - }else if (match_option (arg, ret,"retpoline" )) { -spec2_print_if_insecure ("retpoline selected on command line." ); -return SPECTRE_V2_CMD_RETPOLINE ; - }else if (match_option (arg, ret,"retpoline,amd" )) { -if (boot_cpu_data.x86_vendor !=X86_VENDOR_AMD ) { -pr_err ("retpoline,amd selected but CPU is not AMD. Switching to AUTO select\n" ); -return SPECTRE_V2_CMD_AUTO ; - } -spec2_print_if_insecure ("AMD retpoline selected on command line." ); -return SPECTRE_V2_CMD_RETPOLINE_AMD ; - }else if (match_option (arg, ret,"retpoline,generic" )) { -spec2_print_if_insecure ("generic retpoline selected on command line." ); -return SPECTRE_V2_CMD_RETPOLINE_GENERIC ; - }else if (match_option (arg, ret,"auto" )) { +for (i =0 ; i <ARRAY_SIZE (mitigation_options); i++) { +if (!match_option (arg, ret, mitigation_options[i].option)) +continue ; + cmd = mitigation_options[i].cmd; +break ; + } + +if (i >=ARRAY_SIZE (mitigation_options)) { +pr_err ("unknown option (%s). Switching to AUTO select\n" , + mitigation_options[i].option);return SPECTRE_V2_CMD_AUTO ; } } -if (!cmdline_find_option_bool (boot_command_line,"nospectre_v2" )) +if ((cmd ==SPECTRE_V2_CMD_RETPOLINE || + cmd ==SPECTRE_V2_CMD_RETPOLINE_AMD || + cmd ==SPECTRE_V2_CMD_RETPOLINE_GENERIC ) && + !IS_ENABLED (CONFIG_RETPOLINE )) { +pr_err ("%s selected but not compiled in. Switching to AUTO select\n" , + mitigation_options[i].option);return SPECTRE_V2_CMD_AUTO ; -disable: -spec2_print_if_insecure ("disabled on command line." ); -return SPECTRE_V2_CMD_NONE ; + } + +if (cmd ==SPECTRE_V2_CMD_RETPOLINE_AMD && + boot_cpu_data.x86_vendor !=X86_VENDOR_AMD ) { +pr_err ("retpoline,amd selected but CPU is not AMD. Switching to AUTO select\n" ); +return SPECTRE_V2_CMD_AUTO ; + } + +if (mitigation_options[i].secure) +spec2_print_if_secure (mitigation_options[i].option); +else +spec2_print_if_insecure (mitigation_options[i].option); + +return cmd; }/* Check for Skylake-like CPUs (for RSB handling) */
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/kvm-vmx-allow-direct-access-to-msr_ia32_spec_ctrl.patch queue-4.9/kvm-x86-add-ibpb-support.patch queue-4.9/kvm-svm-allow-direct-access-to-msr_ia32_spec_ctrl.patch queue-4.9/x86-cpufeatures-add-intel-feature-bits-for-speculation-control.patch queue-4.9/x86-retpoline-simplify-vmexit_fill_rsb.patch queue-4.9/x86-cpufeatures-clean-up-spectre-v2-related-cpuid-flags.patch queue-4.9/x86-cpufeatures-add-cpuid_7_edx-cpuid-leaf.patch queue-4.9/x86-cpufeature-blacklist-spec_ctrl-pred_cmd-on-early-spectre-v2-microcodes.patch queue-4.9/x86-retpoline-avoid-retpolines-for-built-in-__init-functions.patch queue-4.9/x86-cpuid-fix-up-virtual-ibrs-ibpb-stibp-feature-bits-on-intel.patch queue-4.9/x86-cpufeatures-add-amd-feature-bits-for-speculation-control.patch queue-4.9/x86-spectre-simplify-spectre_v2-command-line-parsing.patch queue-4.9/x86-msr-add-definitions-for-new-speculation-control-msrs.patch queue-4.9/x86-speculation-add-basic-ibpb-indirect-branch-prediction-barrier-support.patch queue-4.9/kvm-vmx-emulate-msr_ia32_arch_capabilities.patch queue-4.9/x86-pti-do-not-enable-pti-on-cpus-which-are-not-vulnerable-to-meltdown.patch