Skip to contentSkip to conversation

python-smbus: remove sed to replace i2c path

PATCH Superseded Derek Straka 2 participants 4 messages Feb 8, 2018 – Feb 10, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 python-smbus: remove sed to replace i2c path

The i2c-dev file is now installed in the standard location, so the sed to change the path can be removed

---
 meta-python/recipes-devtools/python/python-smbus.inc | 6 ------
 1 file changed, 6 deletions(-)
meta-python/recipes-devtools/python/python-smbus.inc +0 -6
index 0bca58f..57ca8ae 100644
@@ -9,9 +9,3 @@ SRC_URI[sha256sum] = "5b60daf6f011de0acb61de57dba62f2054bb39f19961d67e0c91610f07
 DEPENDS += "i2c-tools"
 
 S = "${WORKDIR}/i2c-tools-${PV}/py-smbus/"
-
-do_configure_prepend() {
-    # Adjust for OE header rename
-    sed -i s:linux/i2c-dev.h:linux/i2c-dev-user.h: Module.mk
-    sed -i s:linux/i2c-dev.h:linux/i2c-dev-user.h: smbusmodule.c
-}
Signature · 1 line
2.7.4
#1 lore raw

Thanks, works for me.

Quoted 33 lines · Derek Straka

The i2c-dev file is now installed in the standard location, so the sed to change the path can be removed

---
 meta-python/recipes-devtools/python/python-smbus.inc | 6 ------
 1 file changed, 6 deletions(-)
meta-python/recipes-devtools/python/python-smbus.inc +0 -0
index 0bca58f..57ca8ae 100644
@@ -9,9 +9,3 @@ SRC_URI[sha256sum] = "5b60daf6f011de0acb61de57dba62f

2054bb39f19961d67e0c91610f07
DEPENDS += "i2c-tools"

S = "${WORKDIR}/i2c-tools-${PV}/py-smbus/"

meta-python/recipes-devtools/python/python-smbus.inc +0 -7
-
-do_configure_prepend() {
-    # Adjust for OE header rename
-    sed -i s:linux/i2c-dev.h:linux/i2c-dev-user.h: Module.mk
-    sed -i s:linux/i2c-dev.h:linux/i2c-dev-user.h: smbusmodule.c
-}
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw

There is small issue I've noticed in incremental builds.. when do_configure is re-executed in the same WORKDIR where this sed was already executed it will fail with the same error about missing i2c-dev-user.h.

It can be fixed by additional PR bump to force new WORKDIR.

Quoted 39 lines · Martin Jansa

Thanks, works for me.

Quoted 33 lines · Derek Straka

The i2c-dev file is now installed in the standard location, so the sed to change the path can be removed

---
 meta-python/recipes-devtools/python/python-smbus.inc | 6 ------
 1 file changed, 6 deletions(-)
meta-python/recipes-devtools/python/python-smbus.inc +0 -0
index 0bca58f..57ca8ae 100644
@@ -9,9 +9,3 @@ SRC_URI[sha256sum] = "5b60daf6f011de0acb61de57dba62

f2054bb39f19961d67e0c91610f07
DEPENDS += "i2c-tools"

S = "${WORKDIR}/i2c-tools-${PV}/py-smbus/"

meta-python/recipes-devtools/python/python-smbus.inc +0 -7
-
-do_configure_prepend() {
-    # Adjust for OE header rename
-    sed -i s:linux/i2c-dev.h:linux/i2c-dev-user.h: Module.mk
-    sed -i s:linux/i2c-dev.h:linux/i2c-dev-user.h: smbusmodule.c
-}
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw

Bumped the PR and sent a V2. Thanks for catching that.

Quoted 49 lines · Martin Jansa

There is small issue I've noticed in incremental builds.. when do_configure is re-executed in the same WORKDIR where this sed was already executed it will fail with the same error about missing i2c-dev-user.h.

It can be fixed by additional PR bump to force new WORKDIR.

Quoted 39 lines · Martin Jansa

Thanks, works for me.

Quoted 33 lines · Derek Straka

The i2c-dev file is now installed in the standard location, so the sed to change the path can be removed

---
 meta-python/recipes-devtools/python/python-smbus.inc | 6 ------
 1 file changed, 6 deletions(-)
meta-python/recipes-devtools/python/python-smbus.inc +0 -0
index 0bca58f..57ca8ae 100644
@@ -9,9 +9,3 @@ SRC_URI[sha256sum] = "5b60daf6f011de0acb61de57dba62

f2054bb39f19961d67e0c91610f07
DEPENDS += "i2c-tools"

S = "${WORKDIR}/i2c-tools-${PV}/py-smbus/"

meta-python/recipes-devtools/python/python-smbus.inc +0 -7
-
-do_configure_prepend() {
-    # Adjust for OE header rename
-    sed -i s:linux/i2c-dev.h:linux/i2c-dev-user.h: Module.mk
-    sed -i s:linux/i2c-dev.h:linux/i2c-dev-user.h: smbusmodule.c
-}
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel