Skip to contentSkip to conversation

SystemACE: Remove

PATCH In review Tom Rini 2 participants 3 messages Feb 12, 2018 – Feb 14, 2018 Block layer

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 SystemACE: Remove

This driver is no longer used on any supported platform in U-Boot and there is no interest in maintaining it further from people that have used it historically.

Cc: Simon Glass <[email protected]>
Cc: Michal Simek <[email protected]>
c: Alexey Brodkin <[email protected]>

---
 arch/sandbox/include/asm/io.h |   4 -
 configs/sandbox_defconfig     |   3 -
 drivers/block/Kconfig         |  19 ---
 drivers/block/Makefile        |   1 -
 drivers/block/blk-uclass.c    |   2 -
 drivers/block/systemace.c     | 303 ------------------------------------------
 include/blk.h                 |   1 -
 7 files changed, 333 deletions(-)
 delete mode 100644 drivers/block/systemace.c
arch/sandbox/include/asm/io.h +0 -4
index 59729f5635e8..d3e8b969d63c 100644
@@ -171,10 +171,6 @@ static inline void _outsw(volatile u16 *port, const void *buf, int ns)
 #define insw(port, buf, ns)		_insw((u16 *)port, buf, ns)
 #define outsw(port, buf, ns)		_outsw((u16 *)port, buf, ns)
 
-/* For systemace.c */
-#define out16(addr, val)
-#define in16(addr)		0
-
 #include <iotrace.h>
 #include <asm/types.h>
 
configs/sandbox_defconfig +0 -3
index c0f4c0a89f12..063828333d58 100644
@@ -81,9 +81,6 @@ CONFIG_DEVRES=y
 CONFIG_DEBUG_DEVRES=y
 CONFIG_ADC=y
 CONFIG_ADC_SANDBOX=y
-CONFIG_SYSTEMACE=y
-CONFIG_SYS_SYSTEMACE_BASE=0x0
-CONFIG_SYS_SYSTEMACE_WIDTH=16
 CONFIG_CLK=y
 CONFIG_CPU=y
 CONFIG_DM_DEMO=y
drivers/block/Kconfig +0 -19
index 73836ada094b..15fd1bcb2b7e 100644
@@ -44,22 +44,3 @@ config IDE
 	  This allows access to raw blocks and filesystems on an IDE drive
 	  from U-Boot. See also CMD_IDE which provides an 'ide' command for
 	  performing various IDE operations.
-
-config SYSTEMACE
-	bool "Xilinx SystemACE support"
-	select HAVE_BLOCK_DEVICE
-	help
-	  Adding this option adds support for Xilinx SystemACE chips attached
-	  via some sort of local bus. The address of the chip must also be
-	  defined in the CONFIG_SYS_SYSTEMACE_BASE macro.
-
-	  When SystemACE support is added, the "ace" device type becomes
-	  available to the fat commands, i.e. fatls.
-
-config SYS_SYSTEMACE_BASE
-	hex "Base address of SystemACE chip"
-	depends on SYSTEMACE
-
-config SYS_SYSTEMACE_WIDTH
-	int "Word size of access to the of SystemACE chip"
-	depends on SYSTEMACE
drivers/block/Makefile +0 -1
index d06a598f1409..3d52bd8f4639 100644
@@ -13,5 +13,4 @@ endif
 
 obj-$(CONFIG_IDE) += ide.o
 obj-$(CONFIG_SANDBOX) += sandbox.o
-obj-$(CONFIG_SYSTEMACE) += systemace.o
 obj-$(CONFIG_BLOCK_CACHE) += blkcache.o
drivers/block/blk-uclass.c +0 -2
index bfda2211f0e8..c32aee67605a 100644
@@ -22,7 +22,6 @@ static const char *if_typename_str[IF_TYPE_COUNT] = {
 	[IF_TYPE_SD]		= "sd",
 	[IF_TYPE_SATA]		= "sata",
 	[IF_TYPE_HOST]		= "host",
-	[IF_TYPE_SYSTEMACE]	= "ace",
 	[IF_TYPE_NVME]		= "nvme",
 	[IF_TYPE_EFI]		= "efi",
 };
@@ -37,7 +36,6 @@ static enum uclass_id if_type_uclass_id[IF_TYPE_COUNT] = {
 	[IF_TYPE_SD]		= UCLASS_INVALID,
 	[IF_TYPE_SATA]		= UCLASS_AHCI,
 	[IF_TYPE_HOST]		= UCLASS_ROOT,
-	[IF_TYPE_SYSTEMACE]	= UCLASS_INVALID,
 	[IF_TYPE_NVME]		= UCLASS_NVME,
 	[IF_TYPE_EFI]		= UCLASS_EFI,
 };
drivers/block/systemace.c deleted +0 -303

303 lines not on this page · raw message

include/blk.h +0 -1
index 69b5a98e5673..636eed9de912 100644
@@ -32,7 +32,6 @@ enum if_type {
 	IF_TYPE_SD,
 	IF_TYPE_SATA,
 	IF_TYPE_HOST,
-	IF_TYPE_SYSTEMACE,
 	IF_TYPE_NVME,
 	IF_TYPE_EFI,
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 SystemACE: Remove

Quoted 8 lines · Tom Rini

This driver is no longer used on any supported platform in U-Boot and there is no interest in maintaining it further from people that have used it historically.

Cc: Simon Glass <[email protected]>
Cc: Michal Simek <[email protected]>
c: Alexey Brodkin <[email protected]>

Quoted 10 lines
---
 arch/sandbox/include/asm/io.h |   4 -
 configs/sandbox_defconfig     |   3 -
 drivers/block/Kconfig         |  19 ---
 drivers/block/Makefile        |   1 -
 drivers/block/blk-uclass.c    |   2 -
 drivers/block/systemace.c     | 303 ------------------------------------------
 include/blk.h                 |   1 -
 7 files changed, 333 deletions(-)
 delete mode 100644 drivers/block/systemace.c

Thanks,
Michal

author
#2 lore raw
In reply to Tom Rini
Quoted 9 lines · Tom Rini

This driver is no longer used on any supported platform in U-Boot and there is no interest in maintaining it further from people that have used it historically.

Cc: Simon Glass <[email protected]>
Cc: Michal Simek <[email protected]>
c: Alexey Brodkin <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180214/8a14bec0/attachment.sig>