Patch "scsi: core: check for device state in __scsi_remove_target()" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
scsi: core: check for device state in __scsi_remove_target()
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-core-check-for-device-state-in-__scsi_remove_target.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
81b6c999897919d5a16fedc018fe375dbab091c5Mon Sep 17 00:00:00 2001
From: Hannes Reinecke <[email protected]>
Date: Wed, 13 Dec 2017 14:21:37 +0100
Subject: scsi: core: check for device state in __scsi_remove_target()
From: Hannes Reinecke <[email protected]>
commit 81b6c999897919d5a16fedc018fe375dbab091c5 upstream.
As it turned out device_get() doesn't use kref_get_unless_zero(), so we will be always getting a device pointer. Consequently, we need to check for the device state in __scsi_remove_target() to avoid tripping over deleted objects.
--- drivers/scsi/scsi_sysfs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/scsi/scsi_sysfs.c +4 -1
@@ -1383,7 +1383,10 @@ static void __scsi_remove_target(struct* check. */ if (sdev->channel != starget->channel || - sdev->id != starget->id || + sdev->id != starget->id) +continue ; +if (sdev->sdev_state ==SDEV_DEL || + sdev->sdev_state ==SDEV_CANCEL || !get_device (&sdev->sdev_gendev))continue ;spin_unlock_irqrestore (shost->host_lock, flags);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/scsi-core-check-for-device-state-in-__scsi_remove_target.patch