Skip to contentSkip to conversation

drm/amd: remove inclusion of non-existing scheduler directory

PATCH In review Corentin Labbe 2 participants 4 messages Feb 22, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/amd: remove inclusion of non-existing scheduler directory

The scheduler directory was removed via commit 1b1f42d8fde4 ("drm: move amd_gpu_scheduler into common location") Remove it from include path.

---
 drivers/gpu/drm/amd/amdgpu/Makefile | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/Makefile +0 -1
index d6e5b7273853..8408aeeaf6c1 100644
@@ -30,7 +30,6 @@ FULL_AMD_DISPLAY_PATH = $(FULL_AMD_PATH)/$(DISPLAY_FOLDER_NAME)
 ccflags-y := -I$(FULL_AMD_PATH)/include/asic_reg \
 	-I$(FULL_AMD_PATH)/include \
 	-I$(FULL_AMD_PATH)/amdgpu \
-	-I$(FULL_AMD_PATH)/scheduler \
 	-I$(FULL_AMD_PATH)/powerplay/inc \
 	-I$(FULL_AMD_PATH)/acp/include \
 	-I$(FULL_AMD_DISPLAY_PATH) \
Signature · 6 lines
2.16.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH 2/2 drm/amd: Remove inclusion of non-existing include directories

This patch fix the following build warnings:
CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o
cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs]
cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs]
CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_device.o
cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs]
cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs] [...]
This warning is shown for each file in amdgpu directory, so it spams a lot.

---
 drivers/gpu/drm/amd/display/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/display/Makefile +0 -2
index c27c81cdeed3..22c72dffdf98 100644
@@ -26,8 +26,6 @@
 
 AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
 
-subdir-ccflags-y += -I$(AMDDALPATH)/ -I$(AMDDALPATH)/include
-
 subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
 subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
 subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/modules/inc
Signature · 6 lines
2.16.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/amd: Remove inclusion of non-existing include directories

Am 22.02.2018 um 09:21 schrieb Corentin Labbe:

Quoted 11 lines

This patch fix the following build warnings:
CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o
cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs]
cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs]
CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_device.o
cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs]
cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs] [...]
This warning is shown for each file in amdgpu directory, so it spams a lot.

Quoted 9 lines
---
  drivers/gpu/drm/amd/display/Makefile | 2 --
  1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/display/Makefile +0 -0
index c27c81cdeed3..22c72dffdf98 100644

drivers/gpu/drm/amd/display/Makefile line 31

Quoted 8 lines
drivers/gpu/drm/amd/display/Makefile +0 -2
@@ -26,8 +26,6 @@
 
  AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
 
-subdir-ccflags-y += -I$(AMDDALPATH)/ -I$(AMDDALPATH)/include
-
  subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
  subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
  subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/modules/inc

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

maintainer Reviewed-by on v1 1/2
#3 lore raw
In reply to Corentin Labbe

Am 22.02.2018 um 09:21 schrieb Corentin Labbe:

Quoted 4 lines

The scheduler directory was removed via commit 1b1f42d8fde4 ("drm: move amd_gpu_scheduler into common location") Remove it from include path.

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/Makefile | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/Makefile +0 -0
index d6e5b7273853..8408aeeaf6c1 100644

drivers/gpu/drm/amd/amdgpu/Makefile FULL_AMD_DISPLAY_PATH = $(FULL_AMD_PATH)/$(DISPLAY_FOLDER_NAME) · line 35

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/Makefile +0 -1
@@ -30,7 +30,6 @@ FULL_AMD_DISPLAY_PATH = $(FULL_AMD_PATH)/$(DISPLAY_FOLDER_NAME)
  ccflags-y := -I$(FULL_AMD_PATH)/include/asic_reg \
  	-I$(FULL_AMD_PATH)/include \
  	-I$(FULL_AMD_PATH)/amdgpu \
-	-I$(FULL_AMD_PATH)/scheduler \
  	-I$(FULL_AMD_PATH)/powerplay/inc \
  	-I$(FULL_AMD_PATH)/acp/include \
  	-I$(FULL_AMD_DISPLAY_PATH) \

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx