Patch "staging: android: ion: Switch from WARN to pr_warn" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
staging: android: ion: Switch from WARN to pr_warn
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
staging-android-ion-switch-from-warn-to-pr_warn.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
e4e179a844f52e907e550f887d0a2171f1508af1Mon Sep 17 00:00:00 2001
From: Laura Abbott <[email protected]>
Date: Fri, 5 Jan 2018 11:14:09 -0800
Subject: staging: android: ion: Switch from WARN to pr_warn
From: Laura Abbott <[email protected]>
commit e4e179a844f52e907e550f887d0a2171f1508af1 upstream.
Syzbot reported a warning with Ion:
WARNING: CPU: 0 PID: 3502 at drivers/staging/android/ion/ion-ioctl.c:73 ion_ioctl+0x2db/0x380 drivers/staging/android/ion/ion-ioctl.c:73 Kernel panic - not syncing: panic_on_warn set ...
This is a warning that validation of the ioctl fields failed. This was deliberately added as a warning to make it very obvious to developers that something needed to be fixed. In reality, this is overkill and disturbs fuzzing. Switch to pr_warn for a message instead.
--- drivers/staging/android/ion/ion-ioctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/android/ion/ion-ioctl.c +3 -1
@@ -71,8 +71,10 @@ long ion_ioctl(struct file *filp, unsignreturn -EFAULT ; ret =validate_ioctl_arg (cmd, &data); -if (WARN_ON_ONCE (ret)) +if (ret) { +pr_warn_once ("%s: ioctl validate failed\n" , __func__);return ret; + }if (!(dir & _IOC_WRITE))memset (&data,0 ,sizeof (data));
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/staging-android-ion-switch-from-warn-to-pr_warn.patch queue-4.14/staging-android-ion-add-__gfp_nowarn-for-system-contig-heap.patch