Patch "net: ethernet: arc: fix error handling in emac_rockchip_probe" has been added to the 4.14-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
net: ethernet: arc: fix error handling in emac_rockchip_probe
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-ethernet-arc-fix-error-handling-in-emac_rockchip_probe.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Fri Feb 23 11:45:09 CET 2018
From: Branislav Radocaj <[email protected]>
Date: Thu, 7 Dec 2017 00:07:38 +0100
Subject: net: ethernet: arc: fix error handling in emac_rockchip_probe
From: Branislav Radocaj <[email protected]>
[ Upstream commit e46772a6946a7d1f3fbbc1415871851d6651f1d4 ]
If clk_set_rate() fails, we should disable clk before return. Found by Linux Driver Verification project (linuxtesting.org).
--- drivers/net/ethernet/arc/emac_rockchip.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ethernet/arc/emac_rockchip.c +5 -2
@@ -220,9 +220,11 @@ static int emac_rockchip_probe(struct pl/* RMII TX/RX needs always a rate of 25MHz */ err =clk_set_rate (priv->macclk,25000000 ); -if (err) +if (err) {dev_err (dev,"failed to change mac clock rate (%d)\n" , err); + goto out_clk_disable_macclk; + } } err =arc_emac_probe (ndev, interface);
@@ -232,7 +234,8 @@ static int emac_rockchip_probe(struct pl }return 0 ; - +out_clk_disable_macclk: +clk_disable_unprepare (priv->macclk); out_regulator_disable:if (priv->regulator)regulator_disable (priv->regulator);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/net-ethernet-arc-fix-error-handling-in-emac_rockchip_probe.patch