percpu: add a schedule point in pcpu_balance_workfn()
Subsystems (4)
PATCH 1/1 percpu: add a schedule point in pcpu_balance_workfn()
From: Eric Dumazet <[email protected]>
When a large BPF percpu map is destroyed, I have seen pcpu_balance_workfn() holding cpu for hundreds of milliseconds.
On KASAN config and 112 hyperthreads, average time to destroy a chunk is ~4 ms.
[ 2489.841376] destroy chunk 1 in 4148689 ns ... [ 2490.093428] destroy chunk 32 in 4072718 ns
Signed-off-by Eric Dumazet <[email protected]>
---
mm/percpu.c | 1 +
1 file changed, 1 insertion(+)
mm/percpu.c +1 -0
@@ -1600,6 +1600,7 @@ static void pcpu_balance_workfn(struct work_struct *work)spin_unlock_irq (&pcpu_lock); }pcpu_destroy_chunk (chunk); +cond_resched (); }/*
Quoted 5 lines · Eric Dumazet
From: Eric Dumazet <[email protected]>
When a large BPF percpu map is destroyed, I have seen
pcpu_balance_workfn()holding cpu for hundreds of milliseconds.
Quoted 8 lines
On KASAN config and 112 hyperthreads, average time to destroy a chunk is ~4 ms.
[ 2489.841376] destroy chunk 1 in 4148689 ns ... [ 2490.093428] destroy chunk 32 in 4072718 nsSigned-off-by Eric Dumazet <[email protected]>
Applied to percpu/for-4.16-fixes.
Thank, Eric.
Signature · 1 line
tejun