Skip to contentSkip to conversation

Patch "amd-xgbe: Fix unused suspend handlers build warning" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Feb 23, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

amd-xgbe: Fix unused suspend handlers build warning

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
amd-xgbe-fix-unused-suspend-handlers-build-warning.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 91eefaabf102c539e6f5531e9a1e5ed46d2b41ca Mon Sep 17 00:00:00 2001

From: Borislav Petkov <[email protected]>
Date: Sat, 26 Nov 2016 21:53:52 +0100
Subject: amd-xgbe: Fix unused suspend handlers build warning
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Borislav Petkov <[email protected]>

commit 91eefaabf102c539e6f5531e9a1e5ed46d2b41ca upstream.

Fix:

drivers/net/ethernet/amd/xgbe/xgbe-main.c:835:12: warning: ‘xgbe_suspend’ defined
but not used [-Wunused-function]
drivers/net/ethernet/amd/xgbe/xgbe-main.c:855:12: warning: ‘xgbe_resume’ defined
but not used [-Wunused-function]

I see it during randconfig builds here.

---
 drivers/net/ethernet/amd/xgbe/xgbe-main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/amd/xgbe/xgbe-main.c +2 -2
@@ -829,7 +829,7 @@ static int xgbe_remove(struct platform_d
 	return 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int xgbe_suspend(struct device *dev)
 {
 	struct net_device *netdev = dev_get_drvdata(dev);
@@ -868,7 +868,7 @@ static int xgbe_resume(struct device *de
 
 	return ret;
 }
-#endif /* CONFIG_PM */
+#endif /* CONFIG_PM_SLEEP */
 
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id xgbe_acpi_match[] = {

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/x86-nospec-fix-header-guards-names.patch queue-4.4/x86-ras-inject-make-it-depend-on-x86_local_apic-y.patch queue-4.4/mm-early_ioremap-fix-boot-hang-with-earlyprintk-efi-keep.patch queue-4.4/platform-x86-intel_mid_thermal-fix-suspend-handlers-unused-warning.patch queue-4.4/x86-microcode-amd-change-load_microcode_amd-s-param-to-bool-to-fix-preemptibility-bug.patch queue-4.4/x86-spectre-fix-spelling-mistake-vunerable-vulnerable.patch queue-4.4/amd-xgbe-fix-unused-suspend-handlers-build-warning.patch queue-4.4/x86-platform-olpc-fix-resume-handler-build-warning.patch queue-4.4/x86-bugs-drop-one-mitigation-from-dmesg.patch