Patch "Revert "usb: musb: host: don't start next rx urb if current one failed"" has been added to the 4.15-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
Revert "usb: musb: host: don't start next rx urb if current one failed"
to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-usb-musb-host-don-t-start-next-rx-urb-if-current-one-failed.patch
and it can be found in the queue-4.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
44eb5e12b845cc8a0634f21b70ef07d774eb4b25Mon Sep 17 00:00:00 2001
From: Bin Liu <[email protected]>
Date: Tue, 20 Feb 2018 07:31:35 -0600
Subject: Revert "usb: musb: host: don't start next rx urb if current one failed"
From: Bin Liu <[email protected]>
commit 44eb5e12b845cc8a0634f21b70ef07d774eb4b25 upstream.
This reverts commit dbac5d07d13e330e6706813c9fde477140fb5d80.
commit dbac5d07d13e ("usb: musb: host: don't start next rx urb if current one failed") along with commit b5801212229f ("usb: musb: host: clear rxcsr error bit if set") try to solve the issue described in [1], but the latter alone is sufficient, and the former causes the issue as in [2], so now revert it.
[1] https://marc.info/?l=linux-usb&m=146173995117456&w=2
[2] https://marc.info/?l=linux-usb&m=151689238420622&w=2
--- drivers/usb/musb/musb_host.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/usb/musb/musb_host.c +1 -7
@@ -393,13 +393,7 @@ static void musb_advance_schedule(struct } } -/* -* The pipe must be broken if current urb->status is set, so don't -* start next urb. -* TODO: to minimize the risk of regression, only check urb->status -* for RX, until we have a test case to understand the behavior of TX. -*/ -if ((!status || !is_in) && qh && qh->is_ready) { +if (qh !=NULL && qh->is_ready) {musb_dbg (musb,"... next ep%d %cX urb %p" , hw_ep->epnum, is_in ?'R' :'T' ,next_urb (qh));musb_start_urb (musb, is_in, qh);
Patches currently in stable-queue which might be from [email protected] are
queue-4.15/revert-usb-musb-host-don-t-start-next-rx-urb-if-current-one-failed.patch