Skip to contentSkip to conversation

Patch "vsprintf: avoid misleading "(null)" for %px" has been added to the 4.15-stable tree

PATCH [email protected] 1 participant 1 message Feb 28, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

vsprintf: avoid misleading "(null)" for %px

to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
vsprintf-avoid-misleading-null-for-px.patch
and it can be found in the queue-4.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3a129cc2151425e5aeb69aeb25fbc994ec738137 Mon Sep 17 00:00:00 2001

From: Adam Borowski <[email protected]>
Date: Sun, 4 Feb 2018 18:45:21 +0100
Subject: vsprintf: avoid misleading "(null)" for %px

From: Adam Borowski <[email protected]>

commit 3a129cc2151425e5aeb69aeb25fbc994ec738137 upstream.

Like %pK already does, print "00000000" instead.

This confused people -- the convention is that "(null)" means you tried to dereference a null pointer as opposed to printing the address.

To: Sergey Senozhatsky <[email protected]>
To: Steven Rostedt <[email protected]>
To: [email protected]

Cc Andrew Morton <[email protected]>
Cc Joe Perches <[email protected]>
Cc Kees Cook <[email protected]>
Cc "Roberts, William C" <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc David Laight <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
---
 lib/vsprintf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/vsprintf.c +1 -1
@@ -1849,7 +1849,7 @@ char *pointer(const char *fmt, char *buf
 {
 	const int default_width = 2 * sizeof(void *);
 
-	if (!ptr && *fmt != 'K') {
+	if (!ptr && *fmt != 'K' && *fmt != 'x') {
 		/*
 		 * Print (null) with the same width as a pointer so it makes
 		 * tabular output look nice.

Patches currently in stable-queue which might be from [email protected] are

queue-4.15/vsprintf-avoid-misleading-null-for-px.patch