drm/i915/uc: Make GuC/HuC fw fetch and loading functions/file structure symmetric
Subsystems (2)
PATCH v2 1/1 drm/i915/uc: Make GuC/HuC fw fetch and loading functions/file structure symmetric
GuC load function is named intel_guc_fw_upload() and HuC load function is named intel_huc_init_hw(). Make them consistent intel_*_fw_upload. Also move HuC fw loading functions and declarations to separate files intel_huc_fw.c|h like GuC.
While at this, do below changes
1. Update kernel-doc comment for intel_*_fw_upload() functions
2. s/huc_ucode_xfer/huc_fw_xfer
3. Introduce intel_huc_fw_init_early()
v2: Changed patch to update HuC functions instead of changing
guc_fw_upload and update file structure. (Michal Wajdeczko)
--- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/intel_guc_fw.c | 10 +- drivers/gpu/drm/i915/intel_huc.c | 154 +----------------------------- drivers/gpu/drm/i915/intel_huc.h | 2 +- drivers/gpu/drm/i915/intel_huc_fw.c | 184 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_huc_fw.h | 33 +++++++ drivers/gpu/drm/i915/intel_uc.c | 2 +- 7 files changed, 227 insertions(+), 161 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_fw.c create mode 100644 drivers/gpu/drm/i915/intel_huc_fw.h
drivers/gpu/drm/i915/Makefile +2 -1
@@ -89,7 +89,8 @@ i915-y += intel_uc.o \ intel_guc_fw.o \ intel_guc_log.o \ intel_guc_submission.o \ - intel_huc.o + intel_huc.o \ + intel_huc_fw.o # autogenerated null render state i915-y += intel_renderstate_gen6.o \
drivers/gpu/drm/i915/intel_guc_fw.c +5 -5
@@ -269,15 +269,15 @@ static int guc_fw_xfer(struct intel_uc_fw *guc_fw, struct i915_vma *vma) }/** -* intel_guc_fw_upload() - finish preparing the GuC for activity +* intel_guc_fw_upload() - load GuC uCode to device * @guc: intel_guc structure * -* Called during driver loading and also after a GPU reset. +* Called from intel_uc_init_hw() during driver load, resume from sleep and +* after a GPU reset. * -* The main action required here it to load the GuC uCode into the device. * The firmware image should have already been fetched into memory by the -* earlier call to intel_guc_init(), so here we need only check that -* worked, and then transfer the image to the h/w. +* earlier call to intel_uc_init_fw(), so here we need to only check that +* fetch succeeded, and then transfer the image to the h/w. * * Return: non-zero code on error */
drivers/gpu/drm/i915/intel_huc.c +1 -153
162 lines not on this page · raw message
drivers/gpu/drm/i915/intel_huc.h +1 -1
@@ -26,6 +26,7 @@#define _INTEL_HUC_H_#include "intel_uc_fw.h" +#include "intel_huc_fw.h" struct intel_huc {/* Generic uC firmware management */
@@ -35,7 +36,6 @@ struct intel_huc { };void intel_huc_init_early (struct intel_huc *huc); -int intel_huc_init_hw (struct intel_huc *huc);int intel_huc_auth (struct intel_huc *huc);#endif
drivers/gpu/drm/i915/intel_huc_fw.c new file +184 -0
184 lines not on this page · raw message
drivers/gpu/drm/i915/intel_huc_fw.h new file +33 -0
@@ -0,0 +1,33 @@ +/* +* Copyright © 2014-2018 Intel Corporation +* +* Permission is hereby granted, free of charge, to any person obtaining a +* copy of this software and associated documentation files (the "Software"), +* to deal in the Software without restriction, including without limitation +* the rights to use, copy, modify, merge, publish, distribute, sublicense, +* and/or sell copies of the Software, and to permit persons to whom the +* Software is furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice (including the next +* paragraph) shall be included in all copies or substantial portions of the +* Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL +* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS +* IN THE SOFTWARE. +* +*/ + +#ifndef _INTEL_HUC_FW_H_ +#define _INTEL_HUC_FW_H_ + +struct intel_huc ; + +void intel_huc_fw_init_early (struct intel_huc *huc); +int intel_huc_fw_upload (struct intel_huc *huc); + +#endif
drivers/gpu/drm/i915/intel_uc.c +1 -1
@@ -361,7 +361,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv) goto err_out;if (USES_HUC (dev_priv)) { - ret =intel_huc_init_hw (huc); + ret =intel_huc_fw_upload (huc);if (ret) goto err_out; }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 249 lines · Sagar Arun Kamble
GuC load function is named
intel_guc_fw_upload()and HuC load function is namedintel_huc_init_hw(). Make them consistent intel_*_fw_upload. Also move HuC fw loading functions and declarations to separate files intel_huc_fw.c|h like GuC.While at this, do below changes
1. Update kernel-doc comment for intel_*_fw_upload() functions
2. s/huc_ucode_xfer/huc_fw_xfer
3. Introduceintel_huc_fw_init_early()v2: Changed patch to update HuC functions instead of changing
guc_fw_uploadand update file structure. (Michal Wajdeczko)Signed-off-by Sagar Arun Kamble <[email protected]>Cc Michal Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Cc Chris Wilson <[email protected]>Cc Anusha Srivatsa <[email protected]>--- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/intel_guc_fw.c | 10 +- drivers/gpu/drm/i915/intel_huc.c | 154 +----------------------------- drivers/gpu/drm/i915/intel_huc.h | 2 +- drivers/gpu/drm/i915/intel_huc_fw.c | 184 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_huc_fw.h | 33 +++++++ drivers/gpu/drm/i915/intel_uc.c | 2 +- 7 files changed, 227 insertions(+), 161 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_fw.c create mode 100644 drivers/gpu/drm/i915/intel_huc_fw.hdrivers/gpu/drm/i915/Makefile +2
-1@@ -89,7 +89,8 @@ i915-y += intel_uc.o \ intel_guc_fw.o \ intel_guc_log.o \ intel_guc_submission.o \ - intel_huc.o + intel_huc.o \ + intel_huc_fw.o # autogenerated null render state i915-y += intel_renderstate_gen6.o \drivers/gpu/drm/i915/intel_guc_fw.c +2
-2@@ -269,15 +269,15 @@ static int guc_fw_xfer(struct intel_uc_fw *guc_fw, struct i915_vma *vma) }/** -* intel_guc_fw_upload() - finish preparing the GuC for activity +* intel_guc_fw_upload() - load GuC uCode to device * @guc: intel_guc structure * -* Called during driver loading and also after a GPU reset. +* Called from intel_uc_init_hw() during driver load, resume from sleep and
+ * after a GPU reset.
*
- * The main action required here it to load the GuC uCode into the device.
* The firmware image should have already been fetched into memory by
the
- * earlier call tointel_guc_init(), so here we need only check that
- * worked, and then transfer the image to the h/w.
+ * earlier call tointel_uc_init_fw(), so here we need to only check that
+ * fetch succeeded, and then transfer the image to the h/w. *
* Return: non-zero code on error
*/drivers/gpu/drm/i915/intel_huc.c +0
-5@@ -27,161 +27,9 @@#include "intel_huc.h" #include "i915_drv.h" -/** -* DOC: HuC Firmware -* -* Motivation: -* GEN9 introduces a new dedicated firmware for usage in media HEVC (High
- * Efficiency Video Coding) operations. Userspace can use the firmware
- * capabilities by adding HuC specific commands to batch buffers.
- *
- * Implementation:
- * The same firmware loader is used as the GuC. However, the actual
- * loading to HW is deferred until GEM initialization is done.
- *
- * Note that HuC firmware loading must be done before GuC loading.
- */drivers/gpu/drm/i915/intel_huc.c +0
-79- -#define BXT_HUC_FW_MAJOR 01 -#define BXT_HUC_FW_MINOR 07 -#define BXT_BLD_NUM 1398 - -#define SKL_HUC_FW_MAJOR 01 -#define SKL_HUC_FW_MINOR 07 -#define SKL_BLD_NUM 1398 - -#define KBL_HUC_FW_MAJOR 02 -#define KBL_HUC_FW_MINOR 00 -#define KBL_BLD_NUM 1810 - -#define HUC_FW_PATH (platform, major, minor, bld_num) \ - "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ - __stringify(minor) "_" __stringify(bld_num) ".bin" - -#define I915_SKL_HUC_UCODE HUC_FW_PATH(skl, SKL_HUC_FW_MAJOR, \ - SKL_HUC_FW_MINOR, SKL_BLD_NUM) -MODULE_FIRMWARE (I915_SKL_HUC_UCODE ); - -#define I915_BXT_HUC_UCODE HUC_FW_PATH(bxt, BXT_HUC_FW_MAJOR, \ - BXT_HUC_FW_MINOR, BXT_BLD_NUM) -MODULE_FIRMWARE (I915_BXT_HUC_UCODE ); - -#define I915_KBL_HUC_UCODE HUC_FW_PATH(kbl, KBL_HUC_FW_MAJOR, \ - KBL_HUC_FW_MINOR, KBL_BLD_NUM) -MODULE_FIRMWARE (I915_KBL_HUC_UCODE ); - -static void huc_fw_select (struct intel_uc_fw *huc_fw) -{ - struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw); -struct drm_i915_private *dev_priv =huc_to_i915 (huc); - -GEM_BUG_ON (huc_fw->type !=INTEL_UC_FW_TYPE_HUC ); - -if (!HAS_HUC (dev_priv)) -return ; - -if (i915_modparams.huc_firmware_path) { - huc_fw->path = i915_modparams.huc_firmware_path; - huc_fw->major_ver_wanted =0 ; - huc_fw->minor_ver_wanted =0 ; - }else if (IS_SKYLAKE (dev_priv)) { - huc_fw->path =I915_SKL_HUC_UCODE ; - huc_fw->major_ver_wanted =SKL_HUC_FW_MAJOR ; - huc_fw->minor_ver_wanted =SKL_HUC_FW_MINOR ; - }else if (IS_BROXTON (dev_priv)) { - huc_fw->path =I915_BXT_HUC_UCODE ; - huc_fw->major_ver_wanted =BXT_HUC_FW_MAJOR ; - huc_fw->minor_ver_wanted =BXT_HUC_FW_MINOR ; - }else if (IS_KABYLAKE (dev_priv) ||IS_COFFEELAKE (dev_priv)) { - huc_fw->path =I915_KBL_HUC_UCODE ; - huc_fw->major_ver_wanted =KBL_HUC_FW_MAJOR ; - huc_fw->minor_ver_wanted =KBL_HUC_FW_MINOR ; - }else { -DRM_WARN ("%s: No firmware known for this platform!\n" , -intel_uc_fw_type_repr (huc_fw->type)); - } -} - -/** -* intel_huc_init_early() - initializes HuC struct -* @huc: intel_huc struct -* -* On platforms with HuC selects firmware for uploading -*/ void intel_huc_init_early (struct intel_huc *huc) { -struct intel_uc_fw *huc_fw = &huc->fw; - -intel_uc_fw_init (huc_fw,INTEL_UC_FW_TYPE_HUC ); -huc_fw_select (huc_fw); -} - -/** -* huc_ucode_xfer() - DMA's the firmware -* @huc_fw: the firmware descriptor -* @vma: the firmware image (bound into the GGTT) -* -* Transfer the firmware image to RAM for execution by the microcontroller.
- *
- * Return: 0 on success, non-zero on failure
- */
-static inthuc_ucode_xfer(struct intel_uc_fw *huc_fw, struct i915_vma *vma)drivers/gpu/drm/i915/intel_huc.c +0
-30-{ - struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw); -struct drm_i915_private *dev_priv =huc_to_i915 (huc); -unsigned long offset =0 ; -u32 size; -int ret; - -GEM_BUG_ON (huc_fw->type !=INTEL_UC_FW_TYPE_HUC ); - -intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL ); - -/* Set the source address for the uCode */ - offset =guc_ggtt_offset (vma) + huc_fw->header_offset; -I915_WRITE (DMA_ADDR_0_LOW ,lower_32_bits (offset)); -I915_WRITE (DMA_ADDR_0_HIGH ,upper_32_bits (offset) &0xFFFF ); - -/* Hardware doesn't look at destination address for HuC. Set it to 0, -* but still program the correct address space. -*/ -I915_WRITE (DMA_ADDR_1_LOW ,0 ); -I915_WRITE (DMA_ADDR_1_HIGH ,DMA_ADDRESS_SPACE_WOPCM ); - - size = huc_fw->header_size + huc_fw->ucode_size; -I915_WRITE (DMA_COPY_SIZE , size); - -/* Start the DMA */ -I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (HUC_UKERNEL |START_DMA )); - -/* Wait for DMA to finish */ - ret = intel_wait_for_register_fw(dev_priv, DMA_CTRL, START_DMA, 0,100);
drivers/gpu/drm/i915/intel_huc.c +0
-16- -DRM_DEBUG_DRIVER ("HuC DMA transfer wait over with ret %d\n" , ret); - -/* Disable the bits once DMA is over */ -I915_WRITE (DMA_CTRL ,_MASKED_BIT_DISABLE (HUC_UKERNEL )); - -intel_uncore_forcewake_put (dev_priv,FORCEWAKE_ALL ); - -return ret; -} - -/** -* intel_huc_init_hw() - load HuC uCode to device -* @huc: intel_huc structure -* -* Called from intel_uc_init_hw() during driver loading and also after a GPU
- * reset. Be note that HuC loading must be done before GuC loading.
- *
- * The firmware image should have already been fetched into memory by the
- * earlier call tointel_uc_init_fw(), so here we need only check that
- * is succeeded, and then transfer the image to the h/w.
- *
- */drivers/gpu/drm/i915/intel_huc.c +1
-3-int intel_huc_init_hw (struct intel_huc *huc) -{ -return intel_uc_fw_upload (&huc->fw, huc_ucode_xfer); +intel_huc_fw_init_early (huc); }/**
drivers/gpu/drm/i915/intel_huc.h +0
-0
drivers/gpu/drm/i915/intel_huc.h line 28
Quoted 3 lines
drivers/gpu/drm/i915/intel_huc.h +1
-0@@ -26,6 +26,7 @@#define _INTEL_HUC_H_#include "intel_uc_fw.h" +#include "intel_huc_fw.h"
hmm, as we don't need anything from this header, maybe we can drop it ?
Quoted 14 lines
drivers/gpu/drm/i915/intel_huc.h +0
-1struct intel_huc {/* Generic uC firmware management */ @@ -35,7 +36,6 @@ struct intel_huc { };void intel_huc_init_early (struct intel_huc *huc); -int intel_huc_init_hw (struct intel_huc *huc);int intel_huc_auth (struct intel_huc *huc);#endif drivers/gpu/drm/i915/intel_huc_fw.c new file +0
-0
drivers/gpu/drm/i915/intel_huc_fw.c line 2
Quoted 2 lines
drivers/gpu/drm/i915/intel_huc_fw.c new file +2
-0@@ -0,0 +1,184 @@ +/* +* Copyright © 2016-2018 Intel Corporation
I think there was agreement to use SPDX license identifiers only.
Quoted 206 lines
drivers/gpu/drm/i915/intel_huc_fw.c new file +2
-0+* +* Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */drivers/gpu/drm/i915/intel_huc_fw.c new file +9
-0+ +#include "intel_huc_fw.h" +#include "i915_drv.h" + +/** +* DOC: HuC Firmware +* +* Motivation: +* GEN9 introduces a new dedicated firmware for usage in media HEVC (High
+ * Efficiency Video Coding) operations. Userspace can use the firmware
+ * capabilities by adding HuC specific commands to batch buffers.
+ *
+ * Implementation:
+ * The same firmware loader is used as the GuC. However, the actual
+ * loading to HW is deferred until GEM initialization is done.
+ *
+ * Note that HuC firmware loading must be done before GuC loading.
+ */drivers/gpu/drm/i915/intel_huc_fw.c new file +81
-0+ +#define BXT_HUC_FW_MAJOR 01 +#define BXT_HUC_FW_MINOR 07 +#define BXT_BLD_NUM 1398 + +#define SKL_HUC_FW_MAJOR 01 +#define SKL_HUC_FW_MINOR 07 +#define SKL_BLD_NUM 1398 + +#define KBL_HUC_FW_MAJOR 02 +#define KBL_HUC_FW_MINOR 00 +#define KBL_BLD_NUM 1810 + +#define HUC_FW_PATH (platform, major, minor, bld_num) \ + "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ + __stringify(minor) "_" __stringify(bld_num) ".bin" + +#define I915_SKL_HUC_UCODE HUC_FW_PATH(skl, SKL_HUC_FW_MAJOR, \ + SKL_HUC_FW_MINOR, SKL_BLD_NUM) +MODULE_FIRMWARE (I915_SKL_HUC_UCODE ); + +#define I915_BXT_HUC_UCODE HUC_FW_PATH(bxt, BXT_HUC_FW_MAJOR, \ + BXT_HUC_FW_MINOR, BXT_BLD_NUM) +MODULE_FIRMWARE (I915_BXT_HUC_UCODE ); + +#define I915_KBL_HUC_UCODE HUC_FW_PATH(kbl, KBL_HUC_FW_MAJOR, \ + KBL_HUC_FW_MINOR, KBL_BLD_NUM) +MODULE_FIRMWARE (I915_KBL_HUC_UCODE ); + +static void huc_fw_select (struct intel_uc_fw *huc_fw) +{ + struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw); +struct drm_i915_private *dev_priv =huc_to_i915 (huc); + +GEM_BUG_ON (huc_fw->type !=INTEL_UC_FW_TYPE_HUC ); + +if (!HAS_HUC (dev_priv)) +return ; + +if (i915_modparams.huc_firmware_path) { + huc_fw->path = i915_modparams.huc_firmware_path; + huc_fw->major_ver_wanted =0 ; + huc_fw->minor_ver_wanted =0 ; + }else if (IS_SKYLAKE (dev_priv)) { + huc_fw->path =I915_SKL_HUC_UCODE ; + huc_fw->major_ver_wanted =SKL_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =SKL_HUC_FW_MINOR ; + }else if (IS_BROXTON (dev_priv)) { + huc_fw->path =I915_BXT_HUC_UCODE ; + huc_fw->major_ver_wanted =BXT_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =BXT_HUC_FW_MINOR ; + }else if (IS_KABYLAKE (dev_priv) ||IS_COFFEELAKE (dev_priv)) { + huc_fw->path =I915_KBL_HUC_UCODE ; + huc_fw->major_ver_wanted =KBL_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =KBL_HUC_FW_MINOR ; + }else { +DRM_WARN ("%s: No firmware known for this platform!\n" , +intel_uc_fw_type_repr (huc_fw->type)); + } +} + +/** +* intel_huc_fw_init_early() - initializes HuC firmware struct +* @huc: intel_huc struct +* +* On platforms with HuC selects firmware for uploading +*/ +void intel_huc_fw_init_early (struct intel_huc *huc) +{ +struct intel_uc_fw *huc_fw = &huc->fw; + +intel_uc_fw_init (huc_fw,INTEL_UC_FW_TYPE_HUC ); +huc_fw_select (huc_fw); +} + +/** +* huc_fw_xfer() - DMA's the firmware +* @huc_fw: the firmware descriptor +* @vma: the firmware image (bound into the GGTT) +* +* Transfer the firmware image to RAM for execution by the microcontroller.
+ *
+ * Return: 0 on success, non-zero on failure
+ */drivers/gpu/drm/i915/intel_huc_fw.c new file +31
-0+static int huc_fw_xfer (struct intel_uc_fw *huc_fw,struct i915_vma *vma) +{ + struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw); +struct drm_i915_private *dev_priv =huc_to_i915 (huc); +unsigned long offset =0 ; +u32 size; +int ret; + +GEM_BUG_ON (huc_fw->type !=INTEL_UC_FW_TYPE_HUC ); + +intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL ); + +/* Set the source address for the uCode */ + offset =guc_ggtt_offset (vma) + huc_fw->header_offset; +I915_WRITE (DMA_ADDR_0_LOW ,lower_32_bits (offset)); +I915_WRITE (DMA_ADDR_0_HIGH ,upper_32_bits (offset) &0xFFFF ); + +/* Hardware doesn't look at destination address for HuC. Set it to 0, +* but still program the correct address space. +*/ +I915_WRITE (DMA_ADDR_1_LOW ,0 ); +I915_WRITE (DMA_ADDR_1_HIGH ,DMA_ADDRESS_SPACE_WOPCM ); + + size = huc_fw->header_size + huc_fw->ucode_size; +I915_WRITE (DMA_COPY_SIZE , size); + +/* Start the DMA */ +I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (HUC_UKERNEL |START_DMA )); + +/* Wait for DMA to finish */ + ret = intel_wait_for_register_fw(dev_priv, DMA_CTRL, START_DMA, 0,100);
drivers/gpu/drm/i915/intel_huc_fw.c new file +16
-0+ +DRM_DEBUG_DRIVER ("HuC DMA transfer wait over with ret %d\n" , ret); + +/* Disable the bits once DMA is over */ +I915_WRITE (DMA_CTRL ,_MASKED_BIT_DISABLE (HUC_UKERNEL )); + +intel_uncore_forcewake_put (dev_priv,FORCEWAKE_ALL ); + +return ret; +} + +/** +* intel_huc_fw_upload() - load HuC uCode to device +* @huc: intel_huc structure +* +* Called from intel_uc_init_hw() during driver load, resume from sleep and
+ * after a GPU reset. Note that HuC must be loaded before GuC.
+ *
+ * The firmware image should have already been fetched into memory by the
+ * earlier call tointel_uc_init_fw(), so here we need to only check that
+ * fetch succeeded, and then transfer the image to the h/w.
+ *
+ * Return: non-zero code on error
+ */drivers/gpu/drm/i915/intel_huc_fw.c new file +4
-0+int intel_huc_fw_upload (struct intel_huc *huc) +{ +return intel_uc_fw_upload (&huc->fw, huc_fw_xfer); +}drivers/gpu/drm/i915/intel_huc_fw.h new file +0
-0
drivers/gpu/drm/i915/intel_huc_fw.h line 2
Quoted 2 lines
drivers/gpu/drm/i915/intel_huc_fw.h new file +2
-0@@ -0,0 +1,33 @@ +/* +* Copyright © 2014-2018 Intel Corporation
use SPDX
Quoted 48 lines
drivers/gpu/drm/i915/intel_huc_fw.h new file +2
-0+* +* Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */drivers/gpu/drm/i915/intel_huc_fw.h new file +10
-0+ +#ifndef _INTEL_HUC_FW_H_ +#define _INTEL_HUC_FW_H_ + +struct intel_huc ; + +void intel_huc_fw_init_early (struct intel_huc *huc); +int intel_huc_fw_upload (struct intel_huc *huc); + +#endif drivers/gpu/drm/i915/intel_uc.c +0
-0
drivers/gpu/drm/i915/intel_uc.c int intel_uc_init_hw(struct drm_i915_private · line 367
Quoted 8 lines
drivers/gpu/drm/i915/intel_uc.c +1
-1@@ -361,7 +361,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv) goto err_out;if (USES_HUC (dev_priv)) { - ret =intel_huc_init_hw (huc); + ret =intel_huc_fw_upload (huc);if (ret) goto err_out; }
LGTM, and with SPDX fixes,
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 20 lines · Michal Wajdeczko
Quoted 18 lines · Sagar Arun Kamble
GuC load function is named
intel_guc_fw_upload()and HuC load function is namedintel_huc_init_hw(). Make them consistent intel_*_fw_upload. Also move HuC fw loading functions and declarations to separate files intel_huc_fw.c|h like GuC.While at this, do below changes
1. Update kernel-doc comment for intel_*_fw_upload() functions
2. s/huc_ucode_xfer/huc_fw_xfer
3. Introduceintel_huc_fw_init_early()v2: Changed patch to update HuC functions instead of changing
guc_fw_uploadand update file structure. (Michal Wajdeczko)Signed-off-by Sagar Arun Kamble <[email protected]>Cc Michal Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Cc Chris Wilson <[email protected]>Cc Anusha Srivatsa <[email protected]>
<snip>
Quoted 10 lines
drivers/gpu/drm/i915/intel_huc.h line 28
Quoted 8 lines
drivers/gpu/drm/i915/intel_huc.h +1
-0@@ -26,6 +26,7 @@ #define _INTEL_HUC_H_#include "intel_uc_fw.h" +#include "intel_huc_fw.h" hmm, as we don't need anything from this header, maybe we can drop it ?
fw_init_early called from huc.c and fw_upload from uc.c which can access through intel_huc.h. Similar to GuC. Not including huc_fw.h directly in huc.c or uc.c
Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/intel_huc.h +0
-1struct intel_huc { /* Generic uC firmware management */@@ -35,7 +36,6 @@ struct intel_huc { };void intel_huc_init_early (struct intel_huc *huc); -int intel_huc_init_hw (struct intel_huc *huc); int intel_huc_auth(struct intel_huc *huc);#endif drivers/gpu/drm/i915/intel_huc_fw.c new file +0
-0
Quoted 9 lines
drivers/gpu/drm/i915/intel_huc_fw.c line 2
Quoted 6 lines
index 0000000..d83a63d
drivers/gpu/drm/i915/intel_huc_fw.c new file +2
-0@@ -0,0 +1,184 @@ +/* +* Copyright © 2016-2018 Intel Corporation I think there was agreement to use SPDX license identifiers only.
Ah. right. will update. Thanks
Quoted 274 lines
Quoted 209 lines
drivers/gpu/drm/i915/intel_huc_fw.c new file +2
-0+* +* Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */drivers/gpu/drm/i915/intel_huc_fw.c new file +9
-0+ +#include "intel_huc_fw.h" +#include "i915_drv.h" + +/** +* DOC: HuC Firmware +* +* Motivation: +* GEN9 introduces a new dedicated firmware for usage in media HEVC (High
+ * Efficiency Video Coding) operations. Userspace can use the firmware
+ * capabilities by adding HuC specific commands to batch buffers.
+ *
+ * Implementation:
+ * The same firmware loader is used as the GuC. However, the actual
+ * loading to HW is deferred until GEM initialization is done.
+ *
+ * Note that HuC firmware loading must be done before GuC loading.
+ */drivers/gpu/drm/i915/intel_huc_fw.c new file +81
-0+ +#define BXT_HUC_FW_MAJOR 01 +#define BXT_HUC_FW_MINOR 07 +#define BXT_BLD_NUM 1398 + +#define SKL_HUC_FW_MAJOR 01 +#define SKL_HUC_FW_MINOR 07 +#define SKL_BLD_NUM 1398 + +#define KBL_HUC_FW_MAJOR 02 +#define KBL_HUC_FW_MINOR 00 +#define KBL_BLD_NUM 1810 + +#define HUC_FW_PATH (platform, major, minor, bld_num) \ + "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ + __stringify(minor) "_" __stringify(bld_num) ".bin" + +#define I915_SKL_HUC_UCODE HUC_FW_PATH(skl, SKL_HUC_FW_MAJOR, \ + SKL_HUC_FW_MINOR, SKL_BLD_NUM) +MODULE_FIRMWARE (I915_SKL_HUC_UCODE ); + +#define I915_BXT_HUC_UCODE HUC_FW_PATH(bxt, BXT_HUC_FW_MAJOR, \ + BXT_HUC_FW_MINOR, BXT_BLD_NUM) +MODULE_FIRMWARE (I915_BXT_HUC_UCODE ); + +#define I915_KBL_HUC_UCODE HUC_FW_PATH(kbl, KBL_HUC_FW_MAJOR, \ + KBL_HUC_FW_MINOR, KBL_BLD_NUM) +MODULE_FIRMWARE (I915_KBL_HUC_UCODE ); + +static void huc_fw_select (struct intel_uc_fw *huc_fw) +{ + struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw); + struct drm_i915_private *dev_priv = huc_to_i915(huc); + + GEM_BUG_ON(huc_fw->type != INTEL_UC_FW_TYPE_HUC); + + if (!HAS_HUC(dev_priv)) + return; + + if (i915_modparams.huc_firmware_path) { + huc_fw->path = i915_modparams.huc_firmware_path; + huc_fw->major_ver_wanted = 0; + huc_fw->minor_ver_wanted = 0; + } else if (IS_SKYLAKE(dev_priv)) { + huc_fw->path = I915_SKL_HUC_UCODE; + huc_fw->major_ver_wanted = SKL_HUC_FW_MAJOR; + huc_fw->minor_ver_wanted = SKL_HUC_FW_MINOR; + } else if (IS_BROXTON(dev_priv)) { + huc_fw->path = I915_BXT_HUC_UCODE; + huc_fw->major_ver_wanted = BXT_HUC_FW_MAJOR; + huc_fw->minor_ver_wanted = BXT_HUC_FW_MINOR; + } else if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv)) { + huc_fw->path = I915_KBL_HUC_UCODE; + huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR; + huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR; + } else { + DRM_WARN("%s: No firmware known for this platform!\n", + intel_uc_fw_type_repr(huc_fw->type)); + } +} + +/** +* intel_huc_fw_init_early() - initializes HuC firmware struct +* @huc: intel_huc struct +* +* On platforms with HuC selects firmware for uploading +*/ +void intel_huc_fw_init_early (struct intel_huc *huc) +{ + struct intel_uc_fw *huc_fw = &huc->fw; + + intel_uc_fw_init(huc_fw, INTEL_UC_FW_TYPE_HUC); + huc_fw_select(huc_fw); +} + +/** +* huc_fw_xfer() - DMA's the firmware +* @huc_fw: the firmware descriptor +* @vma: the firmware image (bound into the GGTT) +* +* Transfer the firmware image to RAM for execution by the microcontroller.
+ *
+ * Return: 0 on success, non-zero on failure
+ */
+static inthuc_fw_xfer(struct intel_uc_fw *huc_fw, struct i915_vma *vma)drivers/gpu/drm/i915/intel_huc_fw.c new file +17
-0+{ + struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw); + struct drm_i915_private *dev_priv = huc_to_i915(huc); + unsigned long offset = 0; + u32 size; + int ret; + + GEM_BUG_ON(huc_fw->type != INTEL_UC_FW_TYPE_HUC); + + intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL); + + /* Set the source address for the uCode */ + offset = guc_ggtt_offset(vma) + huc_fw->header_offset; + I915_WRITE(DMA_ADDR_0_LOW, lower_32_bits(offset)); + I915_WRITE(DMA_ADDR_0_HIGH, upper_32_bits(offset) & 0xFFFF); + + /* Hardware doesn't look at destination address for HuC. Set itto 0,
+ * but still program the correct address space. + */
+I915_WRITE(DMA_ADDR_1_LOW, 0);
+I915_WRITE(DMA_ADDR_1_HIGH, DMA_ADDRESS_SPACE_WOPCM);drivers/gpu/drm/i915/intel_huc_fw.c new file +9
-0+ + size = huc_fw->header_size + huc_fw->ucode_size; + I915_WRITE(DMA_COPY_SIZE, size); + + /* Start the DMA */ + I915_WRITE(DMA_CTRL, _MASKED_BIT_ENABLE(HUC_UKERNEL | START_DMA)); + + /* Wait for DMA to finish */ + ret = intel_wait_for_register_fw(dev_priv, DMA_CTRL, START_DMA,0, 100);
drivers/gpu/drm/i915/intel_huc_fw.c new file +16
-0+ + DRM_DEBUG_DRIVER("HuC DMA transfer wait over with ret %d\n", ret); + + /* Disable the bits once DMA is over */ + I915_WRITE(DMA_CTRL, _MASKED_BIT_DISABLE(HUC_UKERNEL)); + + intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL); + + return ret; +} + +/** +* intel_huc_fw_upload() - load HuC uCode to device +* @huc: intel_huc structure +* +* Called from intel_uc_init_hw() during driver load, resume from sleep and
+ * after a GPU reset. Note that HuC must be loaded before GuC.
+ *
+ * The firmware image should have already been fetched into memory by the
+ * earlier call tointel_uc_init_fw(), so here we need to only check that
+ * fetch succeeded, and then transfer the image to the h/w.
+ *
+ * Return: non-zero code on error
+ */drivers/gpu/drm/i915/intel_huc_fw.c new file +4
-0+int intel_huc_fw_upload (struct intel_huc *huc) +{ + return intel_uc_fw_upload(&huc->fw, huc_fw_xfer); +}drivers/gpu/drm/i915/intel_huc_fw.h new file +0
-0drivers/gpu/drm/i915/intel_huc_fw.h line 2
Quoted 2 lines
drivers/gpu/drm/i915/intel_huc_fw.h new file +2
-0@@ -0,0 +1,33 @@ +/* +* Copyright © 2014-2018 Intel Corporation use SPDX
Quoted 49 lines
drivers/gpu/drm/i915/intel_huc_fw.h new file +2
-0+* +* Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */drivers/gpu/drm/i915/intel_huc_fw.h new file +10
-0+ +#ifndef _INTEL_HUC_FW_H_ +#define _INTEL_HUC_FW_H_ + +struct intel_huc ; + +void intel_huc_fw_init_early (struct intel_huc *huc); +int intel_huc_fw_upload (struct intel_huc *huc); + +#endif drivers/gpu/drm/i915/intel_uc.c +0
-0drivers/gpu/drm/i915/intel_uc.c int intel_uc_init_hw(struct drm_i915_private · line 367
Quoted 8 lines
drivers/gpu/drm/i915/intel_uc.c +1
-1@@ -361,7 +361,7 @@ int intel_uc_init_hw(struct drm_i915_private *dev_priv) goto err_out; if (USES_HUC(dev_priv)) { - ret = intel_huc_init_hw(huc); + ret = intel_huc_fw_upload(huc); if (ret) goto err_out; }LGTM, and with SPDX fixes,
Quoted 1 line
Reviewed-by Michal Wajdeczko <[email protected]>
Thanks for the review
Signature · 7 lines
Thanks, Sagar _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [v2,1/1] drm/i915/uc: Make GuC/HuC fw fetch and loading functions/file structure symmetric
In reply to Sagar Arun Kamble== Series Details ==
== Series Details ==
Series: series starting with [v2,1/1] drm/i915/uc: Make GuC/HuC fw fetch and loading functions/file structure symmetric
URL : https://patchwork.freedesktop.org/series/39220/
State : success
== Summary ==
Series 39220v1 series starting with [v2,1/1] drm/i915/uc: Make GuC/HuC fw fetch and loading functions/file structure symmetric
https://patchwork.freedesktop.org/api/1.0/series/39220/revisions/1/mbox/
---- Known issues:
Test kms_chamelium:
Subgroup dp-hpd-fast:
fail -> PASS (fi-kbl-7500u) fdo#105310 +8
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927fdo#105310 https://bugs.freedesktop.org/show_bug.cgi?id=105310
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:416s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:421s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:370s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:492s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:279s fi-bxt-dsi total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:26 fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:485s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:468s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:459s fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:390s fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:560s fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:572s fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:413s fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:290s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:510s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:386s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:411s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:454s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:409s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:452s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:492s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:460s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:497s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:588s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:435s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:497s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:520s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:489s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:478s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:407s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:429s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:522s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:392s
Blacklisted hosts:
fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:500s
61da3e8943e4b5e643e3d72f3a925227fe4cb84c drm-tip: 2018y-03m-01d-13h-30m-46s UTC integration manifest 99fb8616aeef drm/i915/uc: Make GuC/HuC fw fetch and loading functions/file structure symmetric
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8200/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for series starting with [v2,1/1] drm/i915/uc: Make GuC/HuC fw fetch and loading functions/file structure symmetric
In reply to Sagar Arun Kamble== Series Details ==
== Series Details ==
Series: series starting with [v2,1/1] drm/i915/uc: Make GuC/HuC fw fetch and loading functions/file structure symmetric
URL : https://patchwork.freedesktop.org/series/39220/
State : failure
== Summary ==
---- Possible new issues:
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-mmap-gtt:
dmesg-fail -> PASS (shard-apl)
Test kms_vblank:
Subgroup pipe-b-ts-continuation-suspend:
pass -> INCOMPLETE (shard-hsw)---- Known issues:
Test drv_hangman:
Subgroup error-state-capture-blt:
pass -> DMESG-WARN (shard-snb) fdo#104058
Test kms_chv_cursor_fail:
Subgroup pipe-b-64x64-left-edge:
pass -> DMESG-WARN (shard-snb) fdo#105185 +4
Test kms_cursor_crc:
Subgroup cursor-256x256-suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103375
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-atomic:
pass -> FAIL (shard-hsw) fdo#102670
Test kms_flip:
Subgroup 2x-flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887
Subgroup dpms-vs-vblank-race:
pass -> FAIL (shard-hsw) fdo#103060
Subgroup wf_vblank-ts-check:
pass -> FAIL (shard-hsw) fdo#100368
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-indfb-draw-render:
fail -> PASS (shard-apl) fdo#103167 +2
Test kms_sysfs_edid_timing:
warn -> PASS (shard-apl) fdo#100047
Test perf:
Subgroup enable-disable:
pass -> FAIL (shard-apl) fdo#103715fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#103715 https://bugs.freedesktop.org/show_bug.cgi?id=103715
shard-apl total:3461 pass:1820 dwarn:1 dfail:0 fail:8 skip:1632 time:12150s shard-hsw total:3367 pass:1717 dwarn:1 dfail:0 fail:4 skip:1642 time:10748s shard-snb total:3461 pass:1356 dwarn:4 dfail:0 fail:2 skip:2099 time:6671s
Blacklisted hosts:
shard-kbl total:3461 pass:1939 dwarn:6 dfail:0 fail:7 skip:1509 time:9564s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8200/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx