Patch "powerpc/pseries: Enable RAS hotplug events later" has been added to the 4.15-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
powerpc/pseries: Enable RAS hotplug events later
to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
powerpc-pseries-enable-ras-hotplug-events-later.patch
and it can be found in the queue-4.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
c9dccf1d074a67d36c510845f663980d69e3409bMon Sep 17 00:00:00 2001
From: Sam Bobroff <[email protected]>
Date: Mon, 12 Feb 2018 11:19:29 +1100
Subject: powerpc/pseries: Enable RAS hotplug events later
From: Sam Bobroff <[email protected]>
commit c9dccf1d074a67d36c510845f663980d69e3409b upstream.
Currently if the kernel receives a memory hot-unplug event early enough, it may get stuck in an infinite loop in dissolve_free_huge_pages(). This appears as a stall just after:
pseries-hotplug-mem: Attempting to hot-remove XX LMB(s) at YYYYYYYY
It appears to be caused by "minimum_order" being uninitialized, due to init_ras_IRQ() executing before hugetlb_init().
To correct this, extract the part of init_ras_IRQ() that enables hotplug event processing and place it in the machine_late_initcall phase, which is guaranteed to be after hugetlb_init() is called.
--- arch/powerpc/platforms/pseries/ras.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-)
arch/powerpc/platforms/pseries/ras.c +22 -9
@@ -49,6 +49,28 @@ static irqreturn_t ras_error_interrupt(i/* +* Enable the hotplug interrupt late because processing them may touch other +* devices or systems (e.g. hugepages) that have not been initialized at the +* subsys stage. +*/ +int __init init_ras_hotplug_IRQ (void ) +{ +struct device_node *np; + +/* Hotplug Events */ + np =of_find_node_by_path ("/event-sources/hot-plug-events" ); +if (np !=NULL ) { +if (dlpar_workqueue_init () ==0 ) +request_event_sources_irqs (np, ras_hotplug_interrupt, +"RAS_HOTPLUG" ); +of_node_put (np); + } + +return 0 ; +} +machine_late_initcall (pseries, init_ras_hotplug_IRQ); + +/* * Initialize handlers for the set of interrupts caused by hardware errors * and power system events. */
@@ -66,15 +88,6 @@ static int __init init_ras_IRQ(void)of_node_put (np); } -/* Hotplug Events */ - np =of_find_node_by_path ("/event-sources/hot-plug-events" ); -if (np !=NULL ) { -if (dlpar_workqueue_init () ==0 ) -request_event_sources_irqs (np, ras_hotplug_interrupt, -"RAS_HOTPLUG" ); -of_node_put (np); - } -/* EPOW Events */ np =of_find_node_by_path ("/event-sources/epow-events" );if (np !=NULL ) {
Patches currently in stable-queue which might be from [email protected] are
queue-4.15/powerpc-pseries-enable-ras-hotplug-events-later.patch