Skip to contentSkip to conversation

x86/kconfig: Remove residual "no-hlt" boot parameter reference

PATCH In review zhenwei.pi 2 participants 2 messages Mar 5, 2018 x86

lore
Share & tools
lore

zhenwei.pi

author
#0 lore raw

PATCH 1/1 x86/kconfig: Remove residual "no-hlt" boot parameter reference

The "no-hlt" boot parameter has been removed ~5 years ago :

	The commit 27be457000211a6903968dfce06d5f73f051a217
	("x86 idle: remove 32-bit-only "no-hlt" parameter, hlt_works_ok flag")

Remove a stale reference from the documentation as well.

---
 arch/x86/Kconfig | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)
arch/x86/Kconfig +10 -11
index eb7f43f..bdb17b7 100644
@@ -2494,19 +2494,18 @@ menuconfig APM
 
 	  1) make sure that you have enough swap space and that it is
 	  enabled.
-	  2) pass the "no-hlt" option to the kernel
-	  3) switch on floating point emulation in the kernel and pass
+	  2) switch on floating point emulation in the kernel and pass
 	  the "no387" option to the kernel
-	  4) pass the "floppy=nodma" option to the kernel
-	  5) pass the "mem=4M" option to the kernel (thereby disabling
+	  3) pass the "floppy=nodma" option to the kernel
+	  4) pass the "mem=4M" option to the kernel (thereby disabling
 	  all but the first 4 MB of RAM)
-	  6) make sure that the CPU is not over clocked.
-	  7) read the sig11 FAQ at <http://www.bitwizard.nl/sig11/>
-	  8) disable the cache from your BIOS settings
-	  9) install a fan for the video card or exchange video RAM
-	  10) install a better fan for the CPU
-	  11) exchange RAM chips
-	  12) exchange the motherboard.
+	  5) make sure that the CPU is not over clocked.
+	  6) read the sig11 FAQ at <http://www.bitwizard.nl/sig11/>
+	  7) disable the cache from your BIOS settings
+	  8) install a fan for the video card or exchange video RAM
+	  9) install a better fan for the CPU
+	  10) exchange RAM chips
+	  11) exchange the motherboard.
 
 	  To compile this driver as a module, choose M here: the
 	  module will be called apm.
Signature · 1 line
2.7.4
#1 lore raw
Quoted 32 lines · zhenwei.pi

The "no-hlt" boot parameter has been removed ~5 years ago :

	The commit 27be457000211a6903968dfce06d5f73f051a217
	("x86 idle: remove 32-bit-only "no-hlt" parameter, hlt_works_ok flag")

Remove a stale reference from the documentation as well.

---
 arch/x86/Kconfig | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)
arch/x86/Kconfig +3 -8
index eb7f43f..bdb17b7 100644
@@ -2494,19 +2494,18 @@ menuconfig APM
 
 	  1) make sure that you have enough swap space and that it is
 	  enabled.
-	  2) pass the "no-hlt" option to the kernel
-	  3) switch on floating point emulation in the kernel and pass
+	  2) switch on floating point emulation in the kernel and pass
 	  the "no387" option to the kernel
-	  4) pass the "floppy=nodma" option to the kernel
-	  5) pass the "mem=4M" option to the kernel (thereby disabling
+	  3) pass the "floppy=nodma" option to the kernel
+	  4) pass the "mem=4M" option to the kernel (thereby disabling
 	  all but the first 4 MB of RAM)
-	  6) make sure that the CPU is not over clocked.
-	  7) read the sig11 FAQ at <http://www.bitwizard.nl/sig11/>
-	  8) disable the cache from your BIOS settings
-	  9) install a fan for the video card or exchange video RAM

arch/x86/Kconfig menuconfig APM · line 2508

Quoted 10 lines
arch/x86/Kconfig +7 -3
-	  10) install a better fan for the CPU
-	  11) exchange RAM chips
-	  12) exchange the motherboard.
+	  5) make sure that the CPU is not over clocked.
+	  6) read the sig11 FAQ at <http://www.bitwizard.nl/sig11/>
+	  7) disable the cache from your BIOS settings
+	  8) install a fan for the video card or exchange video RAM
+	  9) install a better fan for the CPU
+	  10) exchange RAM chips
+	  11) exchange the motherboard.

That description is stale in other ways as well (nobody uses floppies anymore), I'd just remove it altogether, starting with this:

If you get
random kernel OOPSes or reboots that don't seem to be related to anything, try disabling/enabling this option (or disabling/enabling APM in your BIOS).
[...]

Thanks,

Ingo