FAILED: patch "[PATCH] vfio: disable filesystem-dax page pinning" failed to apply to 4.4-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
94db151dc89262bfa82922c44e8320cea2334667Mon Sep 17 00:00:00 2001
From: Dan Williams <[email protected]>
Date: Sun, 4 Feb 2018 10:34:02 -0800
Subject: [PATCH] vfio: disable filesystem-dax page pinning
Filesystem-DAX is incompatible with 'longterm' page pinning. Without page cache indirection a DAX mapping maps filesystem blocks directly. This means that the filesystem must not modify a file's block map while any page in a mapping is pinned. In order to prevent the situation of userspace holding of filesystem operations indefinitely, disallow 'longterm' Filesystem-DAX mappings.
RDMA has the same conflict and the plan there is to add a 'with lease' mechanism to allow the kernel to notify userspace that the mapping is being torn down for block-map maintenance. Perhaps something similar can be put in place for vfio.
Note that xfs and ext4 still report:
"DAX enabled. Warning: EXPERIMENTAL, use at your own risk"
...at mount time, and resolving the dax-dma-vs-truncate problem is one of the last hurdles to remove that designation.
drivers/vfio/vfio_iommu_type1.c +15 -3
@@ -338,11 +338,12 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsigned long vaddr, {struct page *page[1 ];struct vm_area_struct *vma; +struct vm_area_struct *vmas[1 ];int ret;if (mm == current->mm) { - ret =get_user_pages_fast (vaddr,1 , !!(prot &IOMMU_WRITE ), - page); + ret =get_user_pages_longterm (vaddr,1 , !!(prot &IOMMU_WRITE ), + page, vmas); }else {unsigned int flags =0 ;
@@ -351,7 +352,18 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsigned long vaddr,down_read (&mm->mmap_sem); ret =get_user_pages_remote (NULL , mm, vaddr,1 , flags, page, -NULL ,NULL ); + vmas,NULL ); +/* +* The lifetime of a vaddr_get_pfn() page pin is +* userspace-controlled. In the fs-dax case this could +* lead to indefinite stalls in filesystem operations. +* Disallow attempts to pin fs-dax pages via this +* interface. +*/ +if (ret >0 &&vma_is_fsdax (vmas[0 ])) { + ret = -EOPNOTSUPP ; +put_page (page[0 ]); + }up_read (&mm->mmap_sem); }