Skip to contentSkip to conversation

Patch "ALSA: x86: Fix missing spinlock and mutex initializations" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Mar 6, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: x86: Fix missing spinlock and mutex initializations

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-x86-fix-missing-spinlock-and-mutex-initializations.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 350144069abf351c743d766b2fba9cb9b7cd32a1 Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Wed, 28 Feb 2018 08:36:06 +0100
Subject: ALSA: x86: Fix missing spinlock and mutex initializations

From: Takashi Iwai <[email protected]>

commit 350144069abf351c743d766b2fba9cb9b7cd32a1 upstream.

The commit change for supporting the multiple ports moved involved some code shuffling, and there the initializations of spinlock and mutex in snd_intelhad object were dropped mistakenly.

This patch adds the missing initializations again for each port.

Fixes b4eb0d522fcb ("ALSA: x86: Split snd_intelhad into card and PCM specific structures")
---
 sound/x86/intel_hdmi_audio.c |    2 ++
 1 file changed, 2 insertions(+)
sound/x86/intel_hdmi_audio.c +2 -0
@@ -1827,6 +1827,8 @@ static int hdmi_lpe_audio_probe(struct p
 		ctx->port = port;
 		ctx->pipe = -1;
 
+		spin_lock_init(&ctx->had_spinlock);
+		mutex_init(&ctx->mutex);
 		INIT_WORK(&ctx->hdmi_audio_wq, had_audio_wq);
 
 		ret = snd_pcm_new(card, INTEL_HAD, port, MAX_PB_STREAMS,

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/alsa-hda-add-a-power_save-blacklist.patch queue-4.14/alsa-hda-fix-pincfg-at-resume-on-lenovo-t470-dock.patch queue-4.14/alsa-x86-fix-missing-spinlock-and-mutex-initializations.patch queue-4.14/alsa-usb-audio-add-a-quirck-for-b-w-px-headphones.patch queue-4.14/alsa-control-fix-memory-corruption-risk-in-snd_ctl_elem_read.patch