Patch "Revert "s390/qeth: fix using of ref counter for rxip addresses"" has been added to the 4.14-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
Revert "s390/qeth: fix using of ref counter for rxip addresses"
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-s390-qeth-fix-using-of-ref-counter-for-rxip-addresses.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Mar 6 19:02:12 PST 2018
From: Julian Wiedmann <[email protected]>
Date: Tue, 27 Feb 2018 18:58:15 +0100
Subject: Revert "s390/qeth: fix using of ref counter for rxip addresses"
From: Julian Wiedmann <[email protected]>
[ Upstream commit 4964c66fd49b2e2342da35358f2ff74614bcbaee ]
This reverts commit cb816192d986f7596009dedcf2201fe2e5bc2aa7.
The issue this attempted to fix never actually occurs. l3_add_rxip() checks (via l3_ip_from_hash()) if the requested address was previously added to the card. If so, it returns -EEXIST and doesn't call l3_add_ip().
As a result, the "address exists" path in l3_add_ip() is never taken for rxip addresses, and this patch had no effect.
--- drivers/s390/net/qeth_l3_main.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/s390/net/qeth_l3_main.c +3 -5
@@ -249,8 +249,7 @@ int qeth_l3_delete_ip(struct qeth_card *return -ENOENT ; addr->ref_counter--; -if (addr->ref_counter >0 && (addr->type ==QETH_IP_TYPE_NORMAL || - addr->type ==QETH_IP_TYPE_RXIP )) +if (addr->type ==QETH_IP_TYPE_NORMAL && addr->ref_counter >0 )return rc;if (addr->in_progress)return -EINPROGRESS ;
@@ -328,9 +327,8 @@ int qeth_l3_add_ip(struct qeth_card *carkfree (addr); } }else { -if (addr->type ==QETH_IP_TYPE_NORMAL || - addr->type ==QETH_IP_TYPE_RXIP ) - addr->ref_counter++; +if (addr->type ==QETH_IP_TYPE_NORMAL ) + addr->ref_counter++; }return rc;
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/s390-qeth-fix-setip-command-handling.patch queue-4.14/s390-qeth-fix-ip-address-lookup-for-l3-devices.patch queue-4.14/s390-qeth-fix-ipa-command-submission-race.patch queue-4.14/revert-s390-qeth-fix-using-of-ref-counter-for-rxip-addresses.patch queue-4.14/s390-qeth-fix-overestimated-count-of-buffer-elements.patch queue-4.14/s390-qeth-fix-double-free-on-ip-add-remove-race.patch queue-4.14/s390-qeth-fix-ip-removal-on-offline-cards.patch queue-4.14/s390-qeth-fix-underestimated-count-of-buffer-elements.patch