Patch "sctp: do not pr_err for the duplicated node in transport rhlist" has been added to the 4.15-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
sctp: do not pr_err for the duplicated node in transport rhlist
to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
sctp-do-not-pr_err-for-the-duplicated-node-in-transport-rhlist.patch
and it can be found in the queue-4.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Mar 6 19:02:56 PST 2018
From: Xin Long <[email protected]>
Date: Mon, 12 Feb 2018 18:29:06 +0800
Subject: sctp: do not pr_err for the duplicated node in transport rhlist
From: Xin Long <[email protected]>
[ Upstream commit 27af86bb038d9c8b8066cd17854ddaf2ea92bce1 ]
The pr_err in sctp_hash_transport was supposed to report a sctp bug for using rhashtable/rhlist.
The err '-EEXIST' introduced in Commit cd2b70875058 ("sctp: check duplicate node before inserting a new transport") doesn't belong to that case.
So just return -EEXIST back without pr_err any kmsg.
--- net/sctp/input.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
net/sctp/input.c +1 -4
@@ -897,15 +897,12 @@ int sctp_hash_transport(struct sctp_tranrhl_for_each_entry_rcu (transport, tmp, list, node)if (transport->asoc->ep == t->asoc->ep) {rcu_read_unlock (); - err = -EEXIST ; - goto out; +return -EEXIST ; }rcu_read_unlock (); err =rhltable_insert_key (&sctp_transport_hashtable, &arg, &t->node, sctp_hash_params); - -out:if (err)pr_err_once ("insert transport fail, errno %d\n" , err);
Patches currently in stable-queue which might be from [email protected] are
queue-4.15/bridge-check-brport-attr-show-in-brport_show.patch queue-4.15/sctp-do-not-pr_err-for-the-duplicated-node-in-transport-rhlist.patch