watchdog: f71808e_wdt: Fix WD_EN register read
PATCH 1/1 watchdog: f71808e_wdt: Fix WD_EN register read
F71808FG_FLAG_WD_EN defines bit position, not a bitmask
Signed-off-by Igor Pylypiv <[email protected]>
--- drivers/watchdog/f71808e_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/f71808e_wdt.c +1 -1
@@ -496,7 +496,7 @@ static bool watchdog_is_running(void) is_running = (superio_inb (watchdog.sioaddr,SIO_REG_ENABLE ) &BIT (0 )) && (superio_inb (watchdog.sioaddr,F71808FG_REG_WDT_CONF ) - &F71808FG_FLAG_WD_EN ); + &BIT (F71808FG_FLAG_WD_EN ));superio_exit (watchdog.sioaddr);
Signature · 1 line
2.7.4
Quoted 3 lines · Igor Pylypiv
F71808FG_FLAG_WD_ENdefines bit position, not a bitmaskSigned-off-by Igor Pylypiv <[email protected]>
Good catch. Wim - candidate for v4.16-rc and stable.
Reviewed-by Guenter Roeck <[email protected]>
Quoted 18 lines
--- drivers/watchdog/f71808e_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/f71808e_wdt.c +1
-1@@ -496,7 +496,7 @@ static bool watchdog_is_running(void) is_running = (superio_inb (watchdog.sioaddr,SIO_REG_ENABLE ) &BIT (0 )) && (superio_inb (watchdog.sioaddr,F71808FG_REG_WDT_CONF ) - &F71808FG_FLAG_WD_EN ); + &BIT (F71808FG_FLAG_WD_EN ));superio_exit (watchdog.sioaddr);