Patch "leds: do not overflow sysfs buffer in led_trigger_show" has been added to the 3.18-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
leds: do not overflow sysfs buffer in led_trigger_show
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
leds-do-not-overflow-sysfs-buffer-in-led_trigger_show.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
3b9b95363c45365d606ad4bbba16acca75fdf6d3Mon Sep 17 00:00:00 2001
From: Nathan Sullivan <[email protected]>
Date: Mon, 15 Aug 2016 17:20:14 -0500
Subject: leds: do not overflow sysfs buffer in led_trigger_show
From: Nathan Sullivan <[email protected]>
commit 3b9b95363c45365d606ad4bbba16acca75fdf6d3 upstream.
Per the documentation, use scnprintf instead of sprintf to ensure there is never more than PAGE_SIZE bytes of trigger names put into the buffer.
--- drivers/leds/led-triggers.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/leds/led-triggers.c +7 -5
@@ -78,21 +78,23 @@ ssize_t led_trigger_show(struct device *down_read (&led_cdev->trigger_lock);if (!led_cdev->trigger) - len +=sprintf (buf+len,"[none] " ); + len +=scnprintf (buf+len,PAGE_SIZE - len,"[none] " );else - len +=sprintf (buf+len,"none " ); + len +=scnprintf (buf+len,PAGE_SIZE - len,"none " );list_for_each_entry (trig, &trigger_list, next_trig) {if (led_cdev->trigger && !strcmp (led_cdev->trigger->name, trig->name)) - len +=sprintf (buf+len,"[%s] " , trig->name); + len +=scnprintf (buf+len,PAGE_SIZE - len,"[%s] " , + trig->name);else - len +=sprintf (buf+len,"%s " , trig->name); + len +=scnprintf (buf+len,PAGE_SIZE - len,"%s " , + trig->name); }up_read (&led_cdev->trigger_lock);up_read (&triggers_list_lock); - len +=sprintf (len+buf,"\n" ); + len +=scnprintf (len+buf,PAGE_SIZE - len,"\n" );return len; }EXPORT_SYMBOL_GPL (led_trigger_show);
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/leds-do-not-overflow-sysfs-buffer-in-led_trigger_show.patch