Skip to contentSkip to conversation

perf/x86/uncore: Add missing filter constraint for SKX CHA event

PATCH In review Kan Liang 3 participants 4 messages Mar 12, 2018 – Mar 20, 2018

Subsystems (2)
x86 perf events
lore
Share & tools
lore

Kan Liang

author
#0 lore raw

PATCH 1/1 perf/x86/uncore: Add missing filter constraint for SKX CHA event

From: Stephane Eranian <[email protected]>

Adding a filter constraint for Intel Skylake CHA event UNC_CHA_UPI_CREDITS_ACQUIRED (0x38).
The event supports core-id/thread-id and link filtering.

Signed-off-by Stephane Eranian <[email protected]>
Signed-off-by Kan Liang <[email protected]>
---
 arch/x86/events/intel/uncore_snbep.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/events/intel/uncore_snbep.c +1 -0
index 8ff1aac..d4672ed 100644
@@ -3355,6 +3355,7 @@ static struct extra_reg skx_uncore_cha_extra_regs[] = {
 	SNBEP_CBO_EVENT_EXTRA_REG(0x9134, 0xffff, 0x4),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x35, 0xff, 0x8),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x36, 0xff, 0x8),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x38, 0xff, 0x3),
 	EVENT_EXTRA_END
 };
Signature · 1 line
2.7.4
author
#2 lore raw
Quoted 11 lines · Peter Zijlstra
Quoted 5 lines · Kan Liang

From: Stephane Eranian <[email protected]>

Adding a filter constraint for Intel Skylake CHA event UNC_CHA_UPI_CREDITS_ACQUIRED (0x38).
The event supports core-id/thread-id and link filtering.

Could you also comment on the other CHA patch?

https://lkml.kernel.org/r/CS1PR84MB01182561B15688095C4DBF30F6D80@CS1PR84MB0118.NAMPRD84.PROD.OUTLOOK.COM

Now, there is a recommended way in uncore document to query the number of CHAs by reading bits 27:0 in the CAPID6 register located at Device 30, Function 3, Offset 0x9C. I have implemented a patch and sent it to Gary. It should fix his issue.

Thanks,
Kan

merge bot
#3 lore raw

[tip:perf/urgent] perf/x86/intel/uncore: Add missing filter constraint for SKX CHA event

In reply to Kan Liang
perf/x86/intel/uncore: Add missing filter constraint for SKX CHA event
Commit-ID:  e340895c9ed0b44548f08bbaaee4afc7bfacd354
Gitweb:     https://git.kernel.org/tip/e340895c9ed0b44548f08bbaaee4afc7bfacd354
Author:     Stephane Eranian <[email protected]>
AuthorDate: Mon, 12 Mar 2018 08:41:34 -0700
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 20 Mar 2018 08:53:32 +0100

perf/x86/intel/uncore: Add missing filter constraint for SKX CHA event

Adding a filter constraint for Intel Skylake CHA event UNC_CHA_UPI_CREDITS_ACQUIRED (0x38).

The event supports core-id/thread-id and link filtering.

Signed-off-by Stephane Eranian <[email protected]>
Signed-off-by Kan Liang <[email protected]>
Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Cc Alexander Shishkin <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vince Weaver <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Ingo Molnar <[email protected]>
---
 arch/x86/events/intel/uncore_snbep.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/events/intel/uncore_snbep.c +1 -0
index 22ec65bc033a..0876798f2ac9 100644
@@ -3343,6 +3343,7 @@ static struct extra_reg skx_uncore_cha_extra_regs[] = {
 	SNBEP_CBO_EVENT_EXTRA_REG(0x9134, 0xffff, 0x4),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x35, 0xff, 0x8),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x36, 0xff, 0x8),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x38, 0xff, 0x3),
 	EVENT_EXTRA_END
 };