Skip to contentSkip to conversation

Patch "[media] tc358743: fix register i2c_rd/wr function fix" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 13, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[media] tc358743: fix register i2c_rd/wr function fix

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     tc358743-fix-register-i2c_rd-wr-function-fix.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From f2c61f98e0b5f8b53b8fb860e5dcdd661bde7d0b Mon Sep 17 00:00:00 2001

From: Philipp Zabel <[email protected]>
Date: Thu, 4 May 2017 12:20:17 -0300
Subject: [media] tc358743: fix register i2c_rd/wr function fix

From: Philipp Zabel <[email protected]>

commit f2c61f98e0b5f8b53b8fb860e5dcdd661bde7d0b upstream.

The below mentioned fix contains a small but severe bug, fix it to make the driver work again.

Fixes 3538aa6ecfb2 ("[media] tc358743: fix register i2c_rd/wr functions")
---
 drivers/media/i2c/tc358743.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/tc358743.c +1 -1
@@ -226,7 +226,7 @@ static void i2c_wr8(struct v4l2_subdev *
 static void i2c_wr8_and_or(struct v4l2_subdev *sd, u16 reg,
 		u8 mask, u8 val)
 {
-	i2c_wrreg(sd, reg, (i2c_rdreg(sd, reg, 2) & mask) | val, 2);
+	i2c_wrreg(sd, reg, (i2c_rdreg(sd, reg, 1) & mask) | val, 1);
 }
 
 static u16 i2c_rd16(struct v4l2_subdev *sd, u16 reg)

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/tc358743-fix-register-i2c_rd-wr-function-fix.patch