Skip to contentSkip to conversation

Patch "Input: tca8418_keypad - remove double read of key event register" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Mar 13, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Input: tca8418_keypad - remove double read of key event register

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
input-tca8418_keypad-remove-double-read-of-key-event-register.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9dd46c02532a6bed6240101ecf4bbc407f8c6adf Mon Sep 17 00:00:00 2001

From: Dmitry Torokhov <[email protected]>
Date: Mon, 13 Feb 2017 15:45:59 -0800
Subject: Input: tca8418_keypad - remove double read of key event register

From: Dmitry Torokhov <[email protected]>

commit 9dd46c02532a6bed6240101ecf4bbc407f8c6adf upstream.

There is no need to tread the same register twice in a row.

Fixes ea4348c8462a ("Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-un ...")
Cc Ben Hutchings <[email protected]>
---
 drivers/input/keyboard/tca8418_keypad.c |    2 --
 1 file changed, 2 deletions(-)
drivers/input/keyboard/tca8418_keypad.c +0 -2
@@ -189,8 +189,6 @@ static void tca8418_read_keypad(struct t
 		input_event(input, EV_MSC, MSC_SCAN, code);
 		input_report_key(input, keymap[code], state);
 
-		/* Read for next loop */
-		error = tca8418_read_byte(keypad_data, REG_KEY_EVENT_A, &reg);
 	} while (1);
 
 	input_sync(input);

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/input-tca8418_keypad-remove-double-read-of-key-event-register.patch queue-4.9/input-matrix_keypad-fix-race-when-disabling-interrupts.patch