Skip to contentSkip to conversation

tst-atomic

DISCUSSION Alexey Brodkin 2 participants 3 messages Mar 13, 2018 – Apr 4, 2018 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

Hi Waldemar,

I see in commit e65912f8b2a6 ("rework most tests to work as standalone package") "tst-atomic" and "tst-atomic-long" were marked as disabled for all architectures as opposed to previously (in times of test-suite being a part of uClibc) disabled only for selected arches (IA64, MIPS and SPARC).

The only guess I have it was done due to inability to refer not-exported "atomic.h". Is that correct? But anyways I'm looking at a possibility to revive those as they might be of use especially in case of emulation of atomics.

Any thoughts on how that could be done?

-Alexey

#1 lore raw

Hi Alexey,
Alexey Brodkin wrote,

Quoted 7 lines

Hi Waldemar,

I see in commit e65912f8b2a6 ("rework most tests to work as standalone package") "tst-atomic" and "tst-atomic-long" were marked as disabled for all architectures as opposed to previously (in times of test-suite being a part of uClibc) disabled only for selected arches (IA64, MIPS and SPARC).

Quoted 5 lines

The only guess I have it was done due to inability to refer not-exported "atomic.h". Is that correct? But anyways I'm looking at a possibility to revive those as they might be of use especially in case of emulation of atomics.

Any thoughts on how that could be done?

Should we export atomic.h again?
The header is removed since
536a0e3a05a0c7d9a4d741d9401c220900cf1e04.

See
https://www.mail-archive.com/uclibc at uclibc.org/msg09694.html

What other solution we could imagine?

best regards
Waldemar

#2 lore raw

Hi Waldemar,

Quoted 14 lines · Waldemar Brodkorb

Hi Alexey,
Alexey Brodkin wrote,

Quoted 11 lines

Hi Waldemar,

I see in commit e65912f8b2a6 ("rework most tests to work as standalone package") "tst-atomic" and "tst-atomic-long" were marked as disabled for all architectures as opposed to previously (in times of test-suite being a part of uClibc) disabled only for selected arches (IA64, MIPS and SPARC).

The only guess I have it was done due to inability to refer not-exported "atomic.h". Is that correct? But anyways I'm looking at a possibility to revive those as they might be of use especially in case of emulation of atomics.

Quoted 5 lines
Quoted 1 line

Any thoughts on how that could be done?

Should we export atomic.h again?
The header is removed since
536a0e3a05a0c7d9a4d741d9401c220900cf1e04.

Probably not as this will open again a can with worms. Fortunately I was able to get my problem understood and almost solved, I guess you're on Cc list of that discussion here:
http://lists.infradead.org/pipermail/linux-snps-arc/2018-March/003583.html

But then why don't we get rid of ./test/silly/tst-atomic*.c at all?

-Alexey