Skip to contentSkip to conversation

drivers/misc: Add Intel interrupt latency counter driver

PATCH In review Ooi, Joyce 3 participants 3 messages Mar 14, 2018 – Mar 21, 2018

Subsystems (2)
lore
Share & tools
lore

Ooi, Joyce

author
#0 lore raw

PATCH 1/1 drivers/misc: Add Intel interrupt latency counter driver

Adding Intel interrupt latency counter driver support. This driver works together with the Intel interrupt latency driver soft IP to measure the time from the interrupt being asserted to the execution of the interrupt service routine. This driver and soft ip supports for both edge and level interrupt.

---
 .../misc/intel-interrupt-latency-counter.txt       |   49 ++++
 drivers/misc/intel_ilc.c                           |  299 ++++++++++++++++++++
 2 files changed, 348 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/misc/intel-interrupt-latency-counter.txt
 create mode 100644 drivers/misc/intel_ilc.c
Documentation/devicetree/bindings/misc/intel-interrupt-latency-counter.txt new file +49 -0
new file mode 100644
index 0000000..9955550
@@ -0,0 +1,49 @@
+Intel Interrupt Latency Counter soft IP
+Intel Interrupt Latency Counter IP core driver provides a sysfs interface
+for user to obtain interrupt latency values from Intel Interrupt Latency
+Counter soft IP.
+
+The sysfs interface is located at path,
+/sys/bus/platform/devices/{addr}.ilc/ilc_data/{int_#}
+with
+- {addr}  = the base address of the soft ip
+- {int_#} = the interrupt number
+
+Example use case:
+# cat /sys/bus/platform/devices/c0010000.ilc/ilc_data/40
+
+Required properties:
+- compatible :
+  - "altr,ilc-1.0"
+- reg :
+  - physical base address of the soft ip and length of memory mapped region
+- interrupt-parent :
+  - interrupt source phandle similar to the interrupt source node
+- interrupts :
+  -interrupt number. The interrupt specifier format depends on the interrupt
+   controller parent
+
+Intel specific properties:
+- altr,sw-fifo-depth :
+  - define software fifo depth needed to record latency values
+
+Note:
+- For edge triggered interrupt, the order of loading the ILC driver relative
+ to driver of the actual interrupt source affects the meaning of the ILC
+ values. If the ILC driver is loaded first, then the count values represent
+ the time to the start of the interrupt handler of the of the interrupt source.
+ If the order is switched, then the counts represent the time to finish the
+ interrupt handler for the interrupt source.
+
+- The driver for the interrupt source must be changed to request a shared irq.
+
+Example:
+	interrupt_latency_counter_0: intc@0x10000000 {
+		compatible = "altr,ilc-1.0";
+		reg = <0x10000000 0x00000100>;
+		interrupt-parent = < &interrupt_parent >;
+		interrupts = < 0 1 4 >;
+		altr,sw-fifo-depth = < 32 >;
+	};
+
+
drivers/misc/intel_ilc.c new file +299 -0

299 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw
Quoted 7 lines · Joyce

Adding Intel interrupt latency counter driver support. This driver works together with the Intel interrupt latency driver soft IP to measure the time from the interrupt being asserted to the execution of the interrupt service routine. This driver and soft ip supports for both edge and level interrupt.

Why has no one else from Intel reviewed this and signed-off on the patch? Please always do that, don't make me do Intel-internal-review :)

Documentation/devicetree/bindings/misc/intel-interrupt-latency-counter.txt

Quoted 12 lines
---
 .../misc/intel-interrupt-latency-counter.txt       |   49 ++++
 drivers/misc/intel_ilc.c                           |  299 ++++++++++++++++++++
 2 files changed, 348 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/misc/intel-interrupt-latency-counter.txt
 create mode 100644 drivers/misc/intel_ilc.c
Documentation/devicetree/bindings/misc/intel-interrupt-latency-counter.txt new file +0 -0
new file mode 100644
index 0000000..9955550

You forgot to cc: the correct device tree people :(

Quoted 8 lines
drivers/misc/intel_ilc.c new file +5 -0
@@ -0,0 +1,299 @@
+/*
+ * Copyright (C) 2018 Intel Corporation. All rights reserved
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,

drivers/misc/intel_ilc.c line 15

Quoted 10 lines
drivers/misc/intel_ilc.c new file +10 -0
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program.  If not, see <http://www.gnu.org/licenses/>.
+ */

Please just use the SPDX single line for this, as documented in the kernel Documentation/ directory.

Quoted 57 lines
drivers/misc/intel_ilc.c new file +57 -0
+
+#include <linux/device.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
+#include <linux/kfifo.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/sysfs.h>
+
+#define DRV_NAME			"intel_ilc"
+#define	CTRL_REG			0x80
+#define FREQ_REG			0x84
+#define	STP_REG				0x88
+#define VLD_REG				0x8C
+#define	ILC_MAX_PORTS		32
+#define ILC_FIFO_DEFAULT	32
+#define ILC_ENABLE			0x01
+#define	CHAR_SIZE			10
+#define POLL_INTERVAL		1
+#define GET_PORT_COUNT(_val)		((_val & 0x7C) >> 2)
+#define GET_VLD_BIT(_val, _offset)	(((_val) >> _offset) & 0x1)
+
+struct intel_ilc {
+	struct platform_device	*pdev;
+	void __iomem			*regs;
+	unsigned int			port_count;
+	unsigned int			irq;
+	unsigned int			channel_offset;
+	unsigned int			interrupt_channels[ILC_MAX_PORTS];
+	struct kfifo			kfifos[ILC_MAX_PORTS];
+	struct device_attribute dev_attr[ILC_MAX_PORTS];
+	struct delayed_work     ilc_work;
+	char					sysfs[ILC_MAX_PORTS][CHAR_SIZE];
+	u32						fifo_depth;
+};
+
+static int ilc_irq_lookup(struct intel_ilc *ilc, int irq)
+{
+	int i;
+	for (i = 0; i < ilc->port_count; i++) {
+		if (irq == platform_get_irq(ilc->pdev, i))
+			return i;
+	}
+	return -EPERM;
+}
+
+static ssize_t ilc_show_counter(struct device *dev,
+		struct device_attribute *attr, char *buf)
+{
+	int ret, i, id, fifo_len;
+	unsigned int fifo_buf[ILC_MAX_PORTS];
+	char	temp[10];
+	struct  intel_ilc *ilc = dev_get_drvdata(dev);
+
+	fifo_len = 0;

drivers/misc/intel_ilc.c line 82

Quoted 10 lines
drivers/misc/intel_ilc.c new file +10 -0
+	ret = kstrtouint(attr->attr.name, 0, &id);
+
+	for (i = 0; i < ilc->port_count; i++) {
+		if (id == (ilc->interrupt_channels[i])) {
+			/*Check for kfifo length*/
+			fifo_len = kfifo_len(&ilc->kfifos[i])
+				/sizeof(unsigned int);
+			if (fifo_len <= 0) {
+				dev_info(&ilc->pdev->dev, "Fifo for interrupt %s is empty\n",
+					attr->attr.name);

dev_err()? What can someone do with this information?

drivers/misc/intel_ilc.c line 84

Quoted 2 lines
drivers/misc/intel_ilc.c new file +2 -0
+			return 0;
+			}

Are you sure you ran checkpatch.pl on this code before sending it out? Please do so.

drivers/misc/intel_ilc.c line 94

Quoted 10 lines
drivers/misc/intel_ilc.c new file +10 -0
+			/*Read from kfifo*/
+			ret = kfifo_out(&ilc->kfifos[i], &fifo_buf,
+				kfifo_len(&ilc->kfifos[i]));
+		}
+	}
+
+	for (i = 0; i < fifo_len; i++) {
+		sprintf(temp, "%u\n", fifo_buf[i]);
+		strcat(buf, temp);
+	}

sysfs is "one value per file", which I don't think you are doing here :(

Again, go get internal review of your code, this just makes me really grumpy as you have access to resources that not many others do, yet you do not take advantage of it and force the community to do their work for them :(

Also, you forgot Documentation/ABI/ entries for all of your new sysfs files, which are requried.

Please do all of this and then resend, and I'm going to require multiple
signed-off-by: lines from other Intel developers before I will accept this.

thanks,

greg k-h

#2 lore raw
In reply to Ooi, Joyce
Quoted 11 lines · Joyce

Adding Intel interrupt latency counter driver support. This driver works together with the Intel interrupt latency driver soft IP to measure the time from the interrupt being asserted to the execution of the interrupt service routine. This driver and soft ip supports for both edge and level interrupt.

---
 .../misc/intel-interrupt-latency-counter.txt       |   49 ++++
 drivers/misc/intel_ilc.c                           |  299 ++++++++++++++++++++

Should this go near "perf" somewhere?

Documentation/devicetree/bindings/misc/intel-interrupt-latency-counter.txt line 4

Quoted 6 lines

+++ b/Documentation/devicetree/bindings/misc/intel-interrupt-latency-counter.txt

Documentation/devicetree/bindings/misc/intel-interrupt-latency-counter.txt new file +4 -0
@@ -0,0 +1,49 @@
+Intel Interrupt Latency Counter soft IP
+Intel Interrupt Latency Counter IP core driver provides a sysfs interface
+for user to obtain interrupt latency values from Intel Interrupt Latency
+Counter soft IP.

Needs to be sent to devicetree people.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html