Patch "NFC: nfcmrvl: double free on error path" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
NFC: nfcmrvl: double free on error path
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
nfc-nfcmrvl-double-free-on-error-path.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Sun Mar 18 16:55:33 CET 2018
From: Dan Carpenter <[email protected]>
Date: Wed, 8 Mar 2017 08:22:37 +0300
Subject: NFC: nfcmrvl: double free on error path
From: Dan Carpenter <[email protected]>
[ Upstream commit ca42fb9e52d155547e6cf18cf26bce3e1a6af4ea ]
The nci_spi_send() function calls kfree_skb(skb) on both error and success so this extra kfree_skb() is a double free.
--- drivers/nfc/nfcmrvl/spi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/nfc/nfcmrvl/spi.c +2 -3
@@ -96,10 +96,9 @@ static int nfcmrvl_spi_nci_send(struct n/* Send the SPI packet */ err =nci_spi_send (drv_data->nci_spi, &drv_data->handshake_completion, skb); -if (err !=0 ) { +if (err)nfc_err (priv->dev,"spi_send failed %d" , err); -kfree_skb (skb); - } +return err; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/media-cpia2-fix-a-couple-off-by-one-bugs.patch queue-4.9/nfc-nfcmrvl-double-free-on-error-path.patch queue-4.9/asoc-nuc900-fix-a-loop-timeout-test.patch