Patch "wil6210: fix memory access violation in wil_memcpy_from/toio_32" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
wil6210: fix memory access violation in wil_memcpy_from/toio_32
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
wil6210-fix-memory-access-violation-in-wil_memcpy_from-toio_32.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Sun Mar 18 16:55:33 CET 2018
From: Dedy Lansky <[email protected]>
Date: Wed, 5 Apr 2017 14:58:11 +0300
Subject: wil6210: fix memory access violation in wil_memcpy_from/toio_32
From: Dedy Lansky <[email protected]>
[ Upstream commit 0f6edfe2bbbb59d161580cb4870fcc46f5490f85 ]
In case count is not multiple of 4, there is a read access in wil_memcpy_toio_32() from outside src buffer boundary.
In wil_memcpy_fromio_32(), in case count is not multiple of 4, there is a write access to outside dst io memory boundary.
Fix these issues with proper handling of the last 1 to 4 copied bytes.
--- drivers/net/wireless/ath/wil6210/main.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/wil6210/main.c +17 -3
@@ -129,9 +129,15 @@ void wil_memcpy_fromio_32(void *dst, conu32 *d = dst;const volatile u32 __iomem *s = src; -/* size_t is unsigned, if (count%4 != 0) it will wrap */ -for (count +=4 ; count >4 ; count -=4 ) +for (; count >=4 ; count -=4 ) *d++ =__raw_readl (s++); + +if (unlikely (count)) { +/* count can be 1..3 */ +u32 tmp =__raw_readl (s); + +memcpy (d, &tmp, count); + } } void wil_memcpy_fromio_halp_vote(struct wil6210_priv *wil, void *dst,
@@ -148,8 +154,16 @@ void wil_memcpy_toio_32(volatile void __volatile u32 __iomem *d = dst;const u32 *s = src; -for (count +=4 ; count >4 ; count -=4 ) +for (; count >=4 ; count -=4 )__raw_writel (*s++, d++); + +if (unlikely (count)) { +/* count can be 1..3 */ +u32 tmp =0 ; + +memcpy (&tmp, s, count); +__raw_writel (tmp, d); + } } void wil_memcpy_toio_halp_vote(struct wil6210_priv *wil,
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/wil6210-fix-memory-access-violation-in-wil_memcpy_from-toio_32.patch