Skip to contentSkip to conversation

Patch "SMB3: Validate negotiate request must always be signed" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 22, 2018 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

SMB3: Validate negotiate request must always be signed

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
smb3-validate-negotiate-request-must-always-be-signed.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd Mon Sep 17 00:00:00 2001

From: Steve French <[email protected]>
Date: Wed, 25 Oct 2017 15:58:31 -0500
Subject: SMB3: Validate negotiate request must always be signed

From: Steve French <[email protected]>

commit 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd upstream.

According to MS-SMB2 3.2.55 validate_negotiate request must always be signed. Some Windows can fail the request if you send it unsigned

See kernel bugzilla bug 197311

CC Stable <[email protected]>
Acked-by Ronnie Sahlberg <lsahlber.redhat.com>
---
 fs/cifs/smb2pdu.c |    3 +++
 1 file changed, 3 insertions(+)
fs/cifs/smb2pdu.c +3 -0
@@ -1558,6 +1558,9 @@ SMB2_ioctl(const unsigned int xid, struc
 	} else
 		iov[0].iov_len = get_rfc1002_length(req) + 4;
 
+	/* validate negotiate request must be signed - see MS-SMB2 3.2.5.5 */
+	if (opcode == FSCTL_VALIDATE_NEGOTIATE_INFO)
+		req->hdr.Flags |= SMB2_FLAGS_SIGNED;
 
 	rc = SendReceive2(xid, ses, iov, num_iovecs, &resp_buftype, 0);
 	rsp = (struct smb2_ioctl_rsp *)iov[0].iov_base;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/smb3-validate-negotiate-request-must-always-be-signed.patch queue-4.4/cifs-enable-encryption-during-session-setup-phase.patch