Skip to contentSkip to conversation

Patch "IB/ipoib: Warn when one port fails to initialize" has been added to the 4.15-stable tree

PATCH [email protected] 1 participant 1 message Mar 22, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

IB/ipoib: Warn when one port fails to initialize

to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ib-ipoib-warn-when-one-port-fails-to-initialize.patch
and it can be found in the queue-4.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Mar 22 14:03:39 CET 2018

From: Yuval Shaia <[email protected]>
Date: Wed, 29 Nov 2017 08:34:02 +0200
Subject: IB/ipoib: Warn when one port fails to initialize

From: Yuval Shaia <[email protected]>

[ Upstream commit ac6dbf7fa4707c75a247b540cc0b5c881f3d0ba8 ]

If one port fails to initialize an error message should indicate the reason and driver should continue serving the working port(s) and other HCA(s).

Fixes e4b2d06892c7 ("IB/ipoib: Remove device when one port fails to init").
---
 drivers/infiniband/ulp/ipoib/ipoib_main.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_main.c +4 -3
@@ -2207,8 +2207,10 @@ static struct net_device *ipoib_add_port
 	int result = -ENOMEM;
 
 	priv = ipoib_intf_alloc(hca, port, format);
-	if (!priv)
+	if (!priv) {
+		pr_warn("%s, %d: ipoib_intf_alloc failed\n", hca->name, port);
 		goto alloc_mem_failed;
+	}
 
 	SET_NETDEV_DEV(priv->dev, hca->dev.parent);
 	priv->dev->dev_id = port - 1;
@@ -2337,8 +2339,7 @@ static void ipoib_add_one(struct ib_devi
 	}
 
 	if (!count) {
-		pr_err("Failed to init port, removing it\n");
-		ipoib_remove_one(device, dev_list);
+		kfree(dev_list);
 		return;
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.15/ib-ipoib-warn-when-one-port-fails-to-initialize.patch