Skip to contentSkip to conversation

Patch "ACPI/processor: Fix error handling in __acpi_processor_start()" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Mar 22, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ACPI/processor: Fix error handling in __acpi_processor_start()

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
acpi-processor-fix-error-handling-in-__acpi_processor_start.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Mar 22 14:40:23 CET 2018

From: Thomas Gleixner <[email protected]>
Date: Wed, 12 Apr 2017 22:07:33 +0200
Subject: ACPI/processor: Fix error handling in __acpi_processor_start()

From: Thomas Gleixner <[email protected]>

[ Upstream commit a5cbdf693a60d5b86d4d21dfedd90f17754eb273 ]

When acpi_install_notify_handler() fails the cooling device stays registered and the sysfs files created via acpi_pss_perf_init() are leaked and the function returns success.

Undo acpi_pss_perf_init() and return a proper error code.

Cc Fenghua Yu <[email protected]>
Cc Tony Luck <[email protected]>
Cc Herbert Xu <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Sebastian Siewior <[email protected]>
Cc Lai Jiangshan <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Tejun Heo <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Len Brown <[email protected]>
---
 drivers/acpi/processor_driver.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/acpi/processor_driver.c +3 -0
@@ -251,6 +251,9 @@ static int __acpi_processor_start(struct
 	if (ACPI_SUCCESS(status))
 		return 0;
 
+	result = -ENODEV;
+	acpi_pss_perf_exit(pr, device);
+
 err_power_exit:
 	acpi_processor_power_exit(pr);
 	return result;

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/acpi-processor-fix-error-handling-in-__acpi_processor_start.patch queue-4.9/x86-reboot-turn-off-kvm-when-halting-a-cpu.patch queue-4.9/acpi-processor-replace-racy-task-affinity-logic.patch queue-4.9/time-change-posix-clocks-ops-interfaces-to-use-timespec64.patch queue-4.9/genirq-use-irqd_get_trigger_type-to-compare-the-trigger-type-for-shared-irqs.patch queue-4.9/cpufreq-sh-replace-racy-task-affinity-logic.patch queue-4.9/irqchip-mips-gic-separate-ipi-reservation-usage-tracking.patch queue-4.9/x86-kaslr-fix-kexec-kernel-boot-crash-when-kaslr-randomization-fails.patch