Patch "gpio: gpio-wcove: fix GPIO IRQ status mask" has been added to the 4.9-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
gpio: gpio-wcove: fix GPIO IRQ status mask
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
gpio-gpio-wcove-fix-gpio-irq-status-mask.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Mar 22 14:40:23 CET 2018
From: Kuppuswamy Sathyanarayanan <[email protected]>
Date: Mon, 24 Apr 2017 12:15:04 -0700
Subject: gpio: gpio-wcove: fix GPIO IRQ status mask
From: Kuppuswamy Sathyanarayanan <[email protected]>
[ Upstream commit 881ebd229f4a5ea88f269c1225245e50db9ba303 ]
According to Whiskey Cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to battery IO. So we should skip this bit when checking for GPIO IRQ pending status. Otherwise, wcove_gpio_irq_handler() might go into the infinite loop until IRQ "pending" status becomes 0. This patch fixes this issue.
--- drivers/gpio/gpio-wcove.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpio/gpio-wcove.c +4 -2
@@ -51,6 +51,8 @@#define GROUP1_NR_IRQS 6#define IRQ_MASK_BASE 0x4e19#define IRQ_STATUS_BASE 0x4e0b +#define GPIO_IRQ0_MASK GENMASK(6, 0) +#define GPIO_IRQ1_MASK GENMASK(5, 0)#define UPDATE_IRQ_TYPE BIT(0)#define UPDATE_IRQ_MASK BIT(1)
@@ -310,7 +312,7 @@ static irqreturn_t wcove_gpio_irq_handlereturn IRQ_NONE ; } - pending = p[0 ] | (p[1 ] <<8 ); + pending = (p[0 ] &GPIO_IRQ0_MASK ) | ((p[1 ] &GPIO_IRQ1_MASK ) <<7 );if (!pending)return IRQ_NONE ;
@@ -334,7 +336,7 @@ static irqreturn_t wcove_gpio_irq_handlebreak ; } - pending = p[0 ] | (p[1 ] <<8 ); + pending = (p[0 ] &GPIO_IRQ0_MASK ) | ((p[1 ] &GPIO_IRQ1_MASK ) <<7 ); }return IRQ_HANDLED ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/gpio-gpio-wcove-fix-gpio-irq-status-mask.patch queue-4.9/gpio-gpio-wcove-fix-irq-pending-status-bit-width.patch