Patch "pinctrl: samsung: Validate alias coming from DT" has been added to the 4.14-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
pinctrl: samsung: Validate alias coming from DT
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pinctrl-samsung-validate-alias-coming-from-dt.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
93b0beae721b3344923b4b8317e9d83b542f4ca6Mon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Tue, 20 Feb 2018 19:17:51 +0100
Subject: pinctrl: samsung: Validate alias coming from DT
From: Krzysztof Kozlowski <[email protected]>
commit 93b0beae721b3344923b4b8317e9d83b542f4ca6 upstream.
Driver uses alias from Device Tree as an index of pin controller data array. In case of a wrong DTB or an out-of-tree DTB, the alias could be outside of this data array leading to out-of-bounds access.
Depending on binary and memory layout, this could be handled properly (showing error like "samsung-pinctrl 3860000.pinctrl: driver data not available") or could lead to exceptions.
--- drivers/pinctrl/samsung/pinctrl-exynos-arm.c | 56 +++++++++++++++++++--- drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 14 ++++- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 28 +++++++++-- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 7 ++ drivers/pinctrl/samsung/pinctrl-samsung.c | 61 +++++++++++++++---------- drivers/pinctrl/samsung/pinctrl-samsung.h | 40 ++++++++++------ 6 files changed, 154 insertions(+), 52 deletions(-)
drivers/pinctrl/samsung/pinctrl-exynos-arm.c +48 -8
@@ -129,7 +129,7 @@ static const struct samsung_pin_bank_dat EXYNOS_PIN_BANK_EINTW(8, 0xc60, "gph3", 0x0c), }; -const struct samsung_pin_ctrl s5pv210_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl s5pv210_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = s5pv210_pin_bank,
@@ -142,6 +142,11 @@ const struct samsung_pin_ctrl s5pv210_pi }, }; +const struct samsung_pinctrl_of_match_data s5pv210_of_data__initconst = { + .ctrl = s5pv210_pin_ctrl, + .num_ctrl =ARRAY_SIZE (s5pv210_pin_ctrl), +}; +/* Pad retention control code for accessing PMU regmap */ static atomic_t exynos_shared_retention_refcnt;
@@ -204,7 +209,7 @@ static const struct samsung_retention_da* Samsung pinctrl driver data for Exynos3250 SoC. Exynos3250 SoC includes * two gpio/pin-mux/pinconfig controllers. */ -const struct samsung_pin_ctrl exynos3250_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos3250_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = exynos3250_pin_banks0,
@@ -225,6 +230,11 @@ const struct samsung_pin_ctrl exynos3250 }, }; +const struct samsung_pinctrl_of_match_data exynos3250_of_data__initconst = { + .ctrl = exynos3250_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos3250_pin_ctrl), +}; +/* pin banks of exynos4210 pin-controller 0 */ static const struct samsung_pin_bank_data exynos4210_pin_banks0[]__initconst = {EXYNOS_PIN_BANK_EINTG (8 ,0x000 ,"gpa0" ,0x00 ),
@@ -308,7 +318,7 @@ static const struct samsung_retention_da* Samsung pinctrl driver data for Exynos4210 SoC. Exynos4210 SoC includes * three gpio/pin-mux/pinconfig controllers. */ -const struct samsung_pin_ctrl exynos4210_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos4210_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = exynos4210_pin_banks0,
@@ -334,6 +344,11 @@ const struct samsung_pin_ctrl exynos4210 }, }; +const struct samsung_pinctrl_of_match_data exynos4210_of_data__initconst = { + .ctrl = exynos4210_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos4210_pin_ctrl), +}; +/* pin banks of exynos4x12 pin-controller 0 */ static const struct samsung_pin_bank_data exynos4x12_pin_banks0[]__initconst = {EXYNOS_PIN_BANK_EINTG (8 ,0x000 ,"gpa0" ,0x00 ),
@@ -396,7 +411,7 @@ static const struct samsung_pin_bank_dat* Samsung pinctrl driver data for Exynos4x12 SoC. Exynos4x12 SoC includes * four gpio/pin-mux/pinconfig controllers. */ -const struct samsung_pin_ctrl exynos4x12_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos4x12_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = exynos4x12_pin_banks0,
@@ -432,6 +447,11 @@ const struct samsung_pin_ctrl exynos4x12 }, }; +const struct samsung_pinctrl_of_match_data exynos4x12_of_data__initconst = { + .ctrl = exynos4x12_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos4x12_pin_ctrl), +}; +/* pin banks of exynos5250 pin-controller 0 */ static const struct samsung_pin_bank_data exynos5250_pin_banks0[]__initconst = {EXYNOS_PIN_BANK_EINTG (8 ,0x000 ,"gpa0" ,0x00 ),
@@ -492,7 +512,7 @@ static const struct samsung_pin_bank_dat* Samsung pinctrl driver data for Exynos5250 SoC. Exynos5250 SoC includes * four gpio/pin-mux/pinconfig controllers. */ -const struct samsung_pin_ctrl exynos5250_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos5250_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = exynos5250_pin_banks0,
@@ -528,6 +548,11 @@ const struct samsung_pin_ctrl exynos5250 }, }; +const struct samsung_pinctrl_of_match_data exynos5250_of_data__initconst = { + .ctrl = exynos5250_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos5250_pin_ctrl), +}; +/* pin banks of exynos5260 pin-controller 0 */ static const struct samsung_pin_bank_data exynos5260_pin_banks0[]__initconst = {EXYNOS_PIN_BANK_EINTG (4 ,0x000 ,"gpa0" ,0x00 ),
@@ -572,7 +597,7 @@ static const struct samsung_pin_bank_dat* Samsung pinctrl driver data for Exynos5260 SoC. Exynos5260 SoC includes * three gpio/pin-mux/pinconfig controllers. */ -const struct samsung_pin_ctrl exynos5260_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos5260_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = exynos5260_pin_banks0,
@@ -592,6 +617,11 @@ const struct samsung_pin_ctrl exynos5260 }, }; +const struct samsung_pinctrl_of_match_data exynos5260_of_data__initconst = { + .ctrl = exynos5260_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos5260_pin_ctrl), +}; +/* pin banks of exynos5410 pin-controller 0 */ static const struct samsung_pin_bank_data exynos5410_pin_banks0[]__initconst = {EXYNOS_PIN_BANK_EINTG (8 ,0x000 ,"gpa0" ,0x00 ),
@@ -662,7 +692,7 @@ static const struct samsung_pin_bank_dat* Samsung pinctrl driver data for Exynos5410 SoC. Exynos5410 SoC includes * four gpio/pin-mux/pinconfig controllers. */ -const struct samsung_pin_ctrl exynos5410_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos5410_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = exynos5410_pin_banks0,
@@ -695,6 +725,11 @@ const struct samsung_pin_ctrl exynos5410 }, }; +const struct samsung_pinctrl_of_match_data exynos5410_of_data__initconst = { + .ctrl = exynos5410_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos5410_pin_ctrl), +}; +/* pin banks of exynos5420 pin-controller 0 */ static const struct samsung_pin_bank_data exynos5420_pin_banks0[]__initconst = {EXYNOS_PIN_BANK_EINTG (8 ,0x000 ,"gpy7" ,0x00 ),
@@ -779,7 +814,7 @@ static const struct samsung_retention_da* Samsung pinctrl driver data for Exynos5420 SoC. Exynos5420 SoC includes * four gpio/pin-mux/pinconfig controllers. */ -const struct samsung_pin_ctrl exynos5420_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos5420_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = exynos5420_pin_banks0,
@@ -813,3 +848,8 @@ const struct samsung_pin_ctrl exynos5420 .retention_data = &exynos4_audio_retention_data, }, }; + +const struct samsung_pinctrl_of_match_data exynos5420_of_data__initconst = { + .ctrl = exynos5420_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos5420_pin_ctrl), +};
drivers/pinctrl/samsung/pinctrl-exynos-arm64.c +12 -2
@@ -180,7 +180,7 @@ static const struct samsung_retention_da* Samsung pinctrl driver data for Exynos5433 SoC. Exynos5433 SoC includes * ten gpio/pin-mux/pinconfig controllers. */ -const struct samsung_pin_ctrl exynos5433_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos5433_pin_ctrl[]__initconst = { {/* pin-controller instance 0 data */ .pin_banks = exynos5433_pin_banks0,
@@ -265,6 +265,11 @@ const struct samsung_pin_ctrl exynos5433 }, }; +const struct samsung_pinctrl_of_match_data exynos5433_of_data__initconst = { + .ctrl = exynos5433_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos5433_pin_ctrl), +}; +/* pin banks of exynos7 pin-controller - ALIVE */ static const struct samsung_pin_bank_data exynos7_pin_banks0[]__initconst = {EXYNOS_PIN_BANK_EINTW (8 ,0x000 ,"gpa0" ,0x00 ),
@@ -344,7 +349,7 @@ static const struct samsung_pin_bank_dat EXYNOS_PIN_BANK_EINTG(4, 0x020, "gpz1", 0x04), }; -const struct samsung_pin_ctrl exynos7_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl exynos7_pin_ctrl[]__initconst = { {/* pin-controller instance 0 Alive data */ .pin_banks = exynos7_pin_banks0,
@@ -397,3 +402,8 @@ const struct samsung_pin_ctrl exynos7_pi .eint_gpio_init = exynos_eint_gpio_init, }, }; + +const struct samsung_pinctrl_of_match_data exynos7_of_data__initconst = { + .ctrl = exynos7_pin_ctrl, + .num_ctrl =ARRAY_SIZE (exynos7_pin_ctrl), +};
drivers/pinctrl/samsung/pinctrl-s3c24xx.c +24 -4
@@ -570,7 +570,7 @@ static const struct samsung_pin_bank_dat PIN_BANK_2BIT(13, 0x080, "gpj"), }; -const struct samsung_pin_ctrl s3c2412_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl s3c2412_pin_ctrl[]__initconst = { { .pin_banks = s3c2412_pin_banks, .nr_banks =ARRAY_SIZE (s3c2412_pin_banks),
@@ -578,6 +578,11 @@ const struct samsung_pin_ctrl s3c2412_pi }, }; +const struct samsung_pinctrl_of_match_data s3c2412_of_data__initconst = { + .ctrl = s3c2412_pin_ctrl, + .num_ctrl =ARRAY_SIZE (s3c2412_pin_ctrl), +}; +static const struct samsung_pin_bank_data s3c2416_pin_banks[]__initconst = {PIN_BANK_A (27 ,0x000 ,"gpa" ),PIN_BANK_2BIT (11 ,0x010 ,"gpb" ),
@@ -592,7 +597,7 @@ static const struct samsung_pin_bank_dat PIN_BANK_2BIT(2, 0x100, "gpm"), }; -const struct samsung_pin_ctrl s3c2416_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl s3c2416_pin_ctrl[]__initconst = { { .pin_banks = s3c2416_pin_banks, .nr_banks =ARRAY_SIZE (s3c2416_pin_banks),
@@ -600,6 +605,11 @@ const struct samsung_pin_ctrl s3c2416_pi }, }; +const struct samsung_pinctrl_of_match_data s3c2416_of_data__initconst = { + .ctrl = s3c2416_pin_ctrl, + .num_ctrl =ARRAY_SIZE (s3c2416_pin_ctrl), +}; +static const struct samsung_pin_bank_data s3c2440_pin_banks[]__initconst = {PIN_BANK_A (25 ,0x000 ,"gpa" ),PIN_BANK_2BIT (11 ,0x010 ,"gpb" ),
@@ -612,7 +622,7 @@ static const struct samsung_pin_bank_dat PIN_BANK_2BIT(13, 0x0d0, "gpj"), }; -const struct samsung_pin_ctrl s3c2440_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl s3c2440_pin_ctrl[]__initconst = { { .pin_banks = s3c2440_pin_banks, .nr_banks =ARRAY_SIZE (s3c2440_pin_banks),
@@ -620,6 +630,11 @@ const struct samsung_pin_ctrl s3c2440_pi }, }; +const struct samsung_pinctrl_of_match_data s3c2440_of_data__initconst = { + .ctrl = s3c2440_pin_ctrl, + .num_ctrl =ARRAY_SIZE (s3c2440_pin_ctrl), +}; +static const struct samsung_pin_bank_data s3c2450_pin_banks[]__initconst = {PIN_BANK_A (28 ,0x000 ,"gpa" ),PIN_BANK_2BIT (11 ,0x010 ,"gpb" ),
@@ -635,10 +650,15 @@ static const struct samsung_pin_bank_dat PIN_BANK_2BIT(2, 0x100, "gpm"), }; -const struct samsung_pin_ctrl s3c2450_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl s3c2450_pin_ctrl[]__initconst = { { .pin_banks = s3c2450_pin_banks, .nr_banks =ARRAY_SIZE (s3c2450_pin_banks), .eint_wkup_init = s3c24xx_eint_init, }, }; + +const struct samsung_pinctrl_of_match_data s3c2450_of_data__initconst = { + .ctrl = s3c2450_pin_ctrl, + .num_ctrl =ARRAY_SIZE (s3c2450_pin_ctrl), +};
drivers/pinctrl/samsung/pinctrl-s3c64xx.c +6 -1
@@ -794,7 +794,7 @@ static const struct samsung_pin_bank_dat* Samsung pinctrl driver data for S3C64xx SoC. S3C64xx SoC includes * one gpio/pin-mux/pinconfig controller. */ -const struct samsung_pin_ctrl s3c64xx_pin_ctrl[]__initconst = { +static const struct samsung_pin_ctrl s3c64xx_pin_ctrl[]__initconst = { {/* pin-controller instance 1 data */ .pin_banks = s3c64xx_pin_banks0,
@@ -803,3 +803,8 @@ const struct samsung_pin_ctrl s3c64xx_pi .eint_wkup_init = s3c64xx_eint_eint0_init, }, }; + +const struct samsung_pinctrl_of_match_data s3c64xx_of_data__initconst = { + .ctrl = s3c64xx_pin_ctrl, + .num_ctrl =ARRAY_SIZE (s3c64xx_pin_ctrl), +};
drivers/pinctrl/samsung/pinctrl-samsung.c +39 -22
105 lines not on this page · raw message
drivers/pinctrl/samsung/pinctrl-samsung.h +25 -15
@@ -286,6 +286,16 @@ struct samsung_pinctrl_drv_data { };/** +* struct samsung_pinctrl_of_match_data: OF match device specific configuration data. +* @ctrl: array of pin controller data. +* @num_ctrl: size of array @ctrl. +*/ +struct samsung_pinctrl_of_match_data { +const struct samsung_pin_ctrl *ctrl; +unsigned int num_ctrl; +}; + +/** * struct samsung_pin_group: represent group of pins of a pinmux function. * @name: name of the pin group, used to lookup the group. * @pins: the pins included in this group.
@@ -313,20 +323,20 @@ struct samsung_pmx_func { };/* list of all exported SoC specific data */ -extern const struct samsung_pin_ctrl exynos3250_pin_ctrl[]; -extern const struct samsung_pin_ctrl exynos4210_pin_ctrl[]; -extern const struct samsung_pin_ctrl exynos4x12_pin_ctrl[]; -extern const struct samsung_pin_ctrl exynos5250_pin_ctrl[]; -extern const struct samsung_pin_ctrl exynos5260_pin_ctrl[]; -extern const struct samsung_pin_ctrl exynos5410_pin_ctrl[]; -extern const struct samsung_pin_ctrl exynos5420_pin_ctrl[]; -extern const struct samsung_pin_ctrl exynos5433_pin_ctrl[]; -extern const struct samsung_pin_ctrl exynos7_pin_ctrl[]; -extern const struct samsung_pin_ctrl s3c64xx_pin_ctrl[]; -extern const struct samsung_pin_ctrl s3c2412_pin_ctrl[]; -extern const struct samsung_pin_ctrl s3c2416_pin_ctrl[]; -extern const struct samsung_pin_ctrl s3c2440_pin_ctrl[]; -extern const struct samsung_pin_ctrl s3c2450_pin_ctrl[]; -extern const struct samsung_pin_ctrl s5pv210_pin_ctrl[]; +extern const struct samsung_pinctrl_of_match_data exynos3250_of_data; +extern const struct samsung_pinctrl_of_match_data exynos4210_of_data; +extern const struct samsung_pinctrl_of_match_data exynos4x12_of_data; +extern const struct samsung_pinctrl_of_match_data exynos5250_of_data; +extern const struct samsung_pinctrl_of_match_data exynos5260_of_data; +extern const struct samsung_pinctrl_of_match_data exynos5410_of_data; +extern const struct samsung_pinctrl_of_match_data exynos5420_of_data; +extern const struct samsung_pinctrl_of_match_data exynos5433_of_data; +extern const struct samsung_pinctrl_of_match_data exynos7_of_data; +extern const struct samsung_pinctrl_of_match_data s3c64xx_of_data; +extern const struct samsung_pinctrl_of_match_data s3c2412_of_data; +extern const struct samsung_pinctrl_of_match_data s3c2416_of_data; +extern const struct samsung_pinctrl_of_match_data s3c2440_of_data; +extern const struct samsung_pinctrl_of_match_data s3c2450_of_data; +extern const struct samsung_pinctrl_of_match_data s5pv210_of_data;#endif /* __PINCTRL_SAMSUNG_H */
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/pinctrl-samsung-validate-alias-coming-from-dt.patch