Add NV12 support
Subsystems (2)
v16 cover Add NV12 support
This patch series is adding NV12 support for Broxton display after rebasing on latest drm-tip.
Initial series of the patches can be found here:
https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html
Previous revision history:
The first version of patches were reviewed when floated by Chandra in 2015 but currently there was a design change with respect to
- the way fb offset is handled
- the way rotation is handled
Current NV12 patch series has been ported as per the
current changes on drm-tip
Review comments from Ville (12th June 2017) have been addressed Review comments from Clinton A Taylor (7th July 2017) have been addressed
Review comments from Clinton A Taylor (10th July 2017)
have been addressed. Had missed out tested-by/reviewed-by in the patches. Fixed that error in this series.
Review comments from Ville (11th July 2017) addressed. Review comments from Paauwe, Bob (29th July 2017) addressed.
Update from rev 28 Aug 2017
Rebased the series.
Tested with IGT for rotation, sprite and tiling combinations. IGT Links:
https://patchwork.kernel.org/patch/9995943/
https://patchwork.kernel.org/patch/9995945/
Review comments by Maarten are addressed in this series. NV12 enabled for Gen10.
Review comments from Shashank Sharma are addressed. IGT debug_fs test failure fixed.
Added reviewed-by tag from Shashank Sharma for few patches Addressed comments from Juha-Pekka Heikkila in few patches (NV12 not to be supported for SKL)
Adding an additional patch Display WA 827 for underrun during NV12 Adding more WA implementation to see if it helps underruns Addressed review comments from Ville regarding the planar formats Added minimum src height for yuv 420 planar formats Added NV12 in skl_mod_supported
(review comments from Kristian Høgsberg <[email protected]>
Update from previous series:
Rebased the series
Addressed review comments from Maarten (add checks to primary plane)
Chandra Konduru (6):
drm/i915: Set scaler mode for NV12
drm/i915: Update format_is_yuv() to include NV12 drm/i915: Upscale scaler max scale for NV12 drm/i915: Add NV12 as supported format for primary plane drm/i915: Add NV12 as supported format for sprite plane drm/i915: Add NV12 support to intel_framebuffer_init
Mahesh Kumar (9):
drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values drm/i915/skl+: refactor WM calculation for NV12 drm/i915/skl+: add NV12 in skl_format_to_fourcc drm/i915/skl+: support verification of DDB HW state for NV12 drm/i915/skl+: NV12 related changes for WM drm/i915/skl+: pass skl_wm_level struct to wm compute func drm/i915/skl+: make sure higher latency level has higher wm value drm/i915/skl+: nv12 workaround disable WM level 1-7 drm/i915/skl: split skl_compute_ddb function
Vidya Srinivas (3):
drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg drm/i915: Display WA 827
drm/i915: Add checks to primary plane
drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/i915_reg.h | 5 + drivers/gpu/drm/i915/intel_atomic.c | 14 +- drivers/gpu/drm/i915/intel_display.c | 284 +++++++++++++++++++++-- drivers/gpu/drm/i915/intel_drv.h | 13 +- drivers/gpu/drm/i915/intel_pm.c | 438 ++++++++++++++++++++++------------- drivers/gpu/drm/i915/intel_sprite.c | 30 ++- 7 files changed, 603 insertions(+), 191 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 1/18 drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
From: Mahesh Kumar <[email protected]>
skl_wm_values struct contains values of pipe/plane DDB only. so rename it for better readability of code. Similarly skl_copy_wm_for_pipe copies DDB values.
s/skl_wm_values/skl_ddb_values
s/skl_copy_wm_for_pipe/skl_copy_ddb_for_pipe
Changes since V1:
- also change name of skl_copy_wm_for_pipe
v2: Added reviewed by from Juha-Pekka Heikkila
v3: Rebased the series
--- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 16 ++++++++-------- 3 files changed, 11 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -2
@@ -1186,7 +1186,7 @@ struct skl_ddb_allocation {struct skl_ddb_entry y_plane[I915_MAX_PIPES ][I915_MAX_PLANES ]; }; -struct skl_wm_values { +struct skl_ddb_values {unsigned dirty_pipes;struct skl_ddb_allocation ddb; };
@@ -1885,7 +1885,7 @@ struct drm_i915_private {/* current hardware state */ union {struct ilk_wm_values hw; -struct skl_wm_values skl_hw; +struct skl_ddb_values skl_hw;struct vlv_wm_values vlv;struct g4x_wm_values g4x; };
drivers/gpu/drm/i915/intel_drv.h +1 -1
@@ -482,7 +482,7 @@ struct intel_atomic_state {bool skip_intermediate_wm;/* Gen9+ only */ -struct skl_wm_values wm_results; +struct skl_ddb_values wm_results;struct i915_sw_fence commit_ready;
drivers/gpu/drm/i915/intel_pm.c +8 -8
@@ -5042,9 +5042,9 @@ skl_compute_ddb(struct drm_atomic_state *state) }static void -skl_copy_wm_for_pipe (struct skl_wm_values *dst, -struct skl_wm_values *src, -enum pipe pipe) +skl_copy_ddb_for_pipe (struct skl_ddb_values *dst, +struct skl_ddb_values *src, +enum pipe pipe) {memcpy (dst->ddb.y_plane[pipe], src->ddb.y_plane[pipe],sizeof (dst->ddb.y_plane[pipe]));
@@ -5095,7 +5095,7 @@ skl_compute_wm(struct drm_atomic_state *state)struct drm_crtc *crtc;struct drm_crtc_state *cstate;struct intel_atomic_state *intel_state =to_intel_atomic_state (state); -struct skl_wm_values *results = &intel_state->wm_results; +struct skl_ddb_values *results = &intel_state->wm_results;struct drm_device *dev = state->dev;struct skl_pipe_wm *pipe_wm;bool changed = false;
@@ -5197,8 +5197,8 @@ static void skl_initial_wm(struct intel_atomic_state *state,struct intel_crtc *intel_crtc =to_intel_crtc (cstate->base.crtc);struct drm_device *dev = intel_crtc->base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); -struct skl_wm_values *results = &state->wm_results; -struct skl_wm_values *hw_vals = &dev_priv->wm.skl_hw; +struct skl_ddb_values *results = &state->wm_results; +struct skl_ddb_values *hw_vals = &dev_priv->wm.skl_hw;enum pipe pipe = intel_crtc->pipe;if ((results->dirty_pipes &drm_crtc_mask (&intel_crtc->base)) ==0 )
@@ -5209,7 +5209,7 @@ static void skl_initial_wm(struct intel_atomic_state *state,if (cstate->base.active_changed)skl_atomic_update_crtc_wm (state, cstate); -skl_copy_wm_for_pipe (hw_vals, results, pipe); +skl_copy_ddb_for_pipe (hw_vals, results, pipe);mutex_unlock (&dev_priv->wm.wm_mutex); }
@@ -5341,7 +5341,7 @@ void skl_pipe_wm_get_hw_state(struct drm_crtc *crtc,void skl_wm_get_hw_state (struct drm_device *dev) {struct drm_i915_private *dev_priv =to_i915 (dev); -struct skl_wm_values *hw = &dev_priv->wm.skl_hw; +struct skl_ddb_values *hw = &dev_priv->wm.skl_hw;struct skl_ddb_allocation *ddb = &dev_priv->wm.skl_hw.ddb;struct drm_crtc *crtc;struct intel_crtc *intel_crtc;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 2/18 drm/i915/skl+: refactor WM calculation for NV12
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
Current code calculates DDB for planar formats in such a way that we store DDB of plane-0 in plane 1 & vice-versa.
In order to make this clean this patch refactors WM/DDB calculation for NV12 planar formats.
v2: Addressed review comments by Maarten
v3: Rebased and addressed review comments by Maarten
v4: Fixed a compilation issue of string replacement is_nv12 to is_planar
v5: Added reviewed by from Juha-Pekka Heikkila
v6: Rebased the series
--- drivers/gpu/drm/i915/i915_drv.h | 5 +- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 121 ++++++++++++++++++++------------------- 3 files changed, 66 insertions(+), 61 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +3 -2
@@ -1182,8 +1182,9 @@ static inline bool skl_ddb_entry_equal(const struct skl_ddb_entry *e1, }struct skl_ddb_allocation { -struct skl_ddb_entry plane[I915_MAX_PIPES ][I915_MAX_PLANES ];/* packed/uv */ -struct skl_ddb_entry y_plane[I915_MAX_PIPES ][I915_MAX_PLANES ]; +/* packed/y */ +struct skl_ddb_entry plane[I915_MAX_PIPES ][I915_MAX_PLANES ]; +struct skl_ddb_entry uv_plane[I915_MAX_PIPES ][I915_MAX_PLANES ]; };struct skl_ddb_values {
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -603,6 +603,7 @@ struct intel_pipe_wm {struct skl_plane_wm {struct skl_wm_level wm[8 ];struct skl_wm_level trans_wm; +bool is_planar; };struct skl_pipe_wm {
drivers/gpu/drm/i915/intel_pm.c +62 -59
275 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 3/18 drm/i915/skl+: add NV12 in skl_format_to_fourcc
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
Add support of recognizing DRM_FORMAT_NV12 from plane_format register value.
v2: Added reviewed by tag from Mika Kahola
v3: Added reviewed by from Juha-Pekka Heikkila
v4: Rebased the series
--- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_display.c +2 -0
@@ -2662,6 +2662,8 @@ static int skl_format_to_fourcc(int format, bool rgb_order, bool alpha)switch (format) {case PLANE_CTL_FORMAT_RGB_565 :return DRM_FORMAT_RGB565 ; +case PLANE_CTL_FORMAT_NV12 : +return DRM_FORMAT_NV12 ;default :case PLANE_CTL_FORMAT_XRGB_8888 :if (rgb_order) {
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 4/18 drm/i915/skl+: support verification of DDB HW state for NV12
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
For YUV 420 Planar formats like NV12,
buffer allocation is done for Y and UV surfaces separately. For NV12 plane formats, the UV buffer
allocation must be programmed in the Plane Buffer Config register and the Y buffer allocation must be programmed in the Plane NV12 Buffer Config register. Both register values should be verified during verify_wm_state.
v2: Addressed review comments by Maarten.
v3: Addressed review comments by Shashank Sharma.
v4: Adding reviewed by tag from Shashank Sharma
v5: Added reviewed by from Juha-Pekka Heikkila
v6: Rebased the series
--- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 51 +++++++++++++++++++++++++++++------- 3 files changed, 43 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -2657,7 +2657,7 @@ static int i9xx_format_to_fourcc(int format) } } -static int skl_format_to_fourcc (int format,bool rgb_order,bool alpha) +int skl_format_to_fourcc (int format,bool rgb_order,bool alpha) {switch (format) {case PLANE_CTL_FORMAT_RGB_565 :
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -1612,6 +1612,7 @@ u32 skl_plane_stride(const struct drm_framebuffer *fb, int plane,int skl_check_plane_surface (const struct intel_crtc_state *crtc_state,struct intel_plane_state *plane_state);int i9xx_check_plane_surface (struct intel_plane_state *plane_state); +int skl_format_to_fourcc (int format,bool rgb_order,bool alpha);/* intel_csr.c */ void intel_csr_ucode_init (struct drm_i915_private *);
drivers/gpu/drm/i915/intel_pm.c +41 -10
63 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 5/18 drm/i915/skl+: NV12 related changes for WM
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
NV12 requires WM calculation for UV plane as well.
UV plane WM should also fulfill all the WM related restrictions.
v2: Addressed review comments from Shashank Sharma.
v3: Addressed review comments from Shashank Sharma Changed plane_num to plane_id in skl_compute_plane_wm_params and skl_compute_plane_wm.
Adding reviewed by tag from Shashank Sharma
v4: Added reviewed by from Juha-Pekka Heikkila
v5: Rebased the series
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 50 +++++++++++++++++++++++++++++++++------- 3 files changed, 44 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -1202,6 +1202,7 @@ struct skl_wm_level {struct skl_wm_params {bool x_tiled, y_tiled;bool rc_surface; +bool is_planar;uint32_t width;uint8_t cpp;uint32_t plane_pixel_rate;
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -602,6 +602,7 @@ struct intel_pipe_wm {struct skl_plane_wm {struct skl_wm_level wm[8 ]; +struct skl_wm_level uv_wm[8 ];struct skl_wm_level trans_wm;bool is_planar; };
drivers/gpu/drm/i915/intel_pm.c +42 -8
110 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 6/18 drm/i915/skl+: pass skl_wm_level struct to wm compute func
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
This patch passes skl_wm_level structure itself to watermark computation function skl_compute_plane_wm function (instead of its internal parameters). It reduces number of arguments required to be passed.
v2: Addressed review comments by Shashank Sharma
v3: Adding reviewed by tag from Shashank Sharma
v4: Added reviewed by from Juha-Pekka Heikkila
v5: Rebased the series
--- drivers/gpu/drm/i915/intel_pm.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +7 -11
@@ -4529,9 +4529,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,uint16_t ddb_allocation, int level, const struct skl_wm_params *wp, - uint16_t *out_blocks, /* out */ - uint8_t *out_lines, /* out */ - bool *enabled /* out */) + struct skl_wm_level *result /* out */) { const struct drm_plane_state *pstate = &intel_pstate->base;uint32_t latency = dev_priv->wm.skl_latency[level];
@@ -4545,7 +4543,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,if (latency ==0 || !intel_wm_plane_visible (cstate, intel_pstate)) { - *enabled = false; + result->plane_en = false;return 0 ; }
@@ -4626,7 +4624,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,if ((level >0 && res_lines >31 ) || res_blocks >= ddb_allocation || min_disp_buf_needed >= ddb_allocation) { - *enabled = false; + result->plane_en = false;/* * If there are no valid level 0 watermarks, then we can't
@@ -4646,9 +4644,9 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, }/* The number of lines are ignored for the level 0 watermark. */ - *out_lines = level ? res_lines :0 ; - *out_blocks = res_blocks; - *enabled = true; + result->plane_res_b = res_blocks; + result->plane_res_l = res_lines; + result->plane_en = true;return 0 ; }
@@ -4688,9 +4686,7 @@ skl_compute_wm_levels(const struct drm_i915_private *dev_priv, ddb_blocks, level, wm_params, - &result->plane_res_b, - &result->plane_res_l, - &result->plane_en); + result);if (ret)return ret; }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 7/18 drm/i915/skl+: make sure higher latency level has higher wm value
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
DDB allocation optimization algorithm requires/assumes ddb allocation for any memory C-state level DDB value to be as high as level below the current level. Render decompression requires level WM to be as high as wm level-0. This patch fulfils both the requirements.
v2: Changed plane_num to plane_id in skl_compute_wm_levels
v3: Addressed review comments from Shashank Sharma Changed the commit message "statement can be more clear, "DDB value to be as high as level below " what is level below ?"
v4: Added reviewed by tag from Shashank Sharma
v5: Added reviewed by from Juha-Pekka Heikkila
v6: Rebased the series
--- drivers/gpu/drm/i915/intel_pm.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +18 -0
@@ -4529,6 +4529,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,uint16_t ddb_allocation, int level, const struct skl_wm_params *wp, + const struct skl_wm_level *result_prev, struct skl_wm_level *result /* out */) { const struct drm_plane_state *pstate = &intel_pstate->base;
@@ -4596,6 +4597,15 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, }else { res_blocks++; } + +/* +* Make sure result blocks for higher latency levels are atleast +* as high as level below the current level. +* Assumption in DDB algorithm optimization for special cases. +* Also covers Display WA #1125 for RC. +*/ +if (result_prev->plane_res_b > res_blocks) + res_blocks = result_prev->plane_res_b; }if (INTEL_GEN (dev_priv) >=11 ) {
@@ -4679,6 +4689,13 @@ skl_compute_wm_levels(const struct drm_i915_private *dev_priv,for (level =0 ; level <= max_level; level++) {struct skl_wm_level *result = plane_id ? &wm->uv_wm[level] : &wm->wm[level]; +struct skl_wm_level *result_prev; + +if (level) + result_prev = plane_id ? &wm->uv_wm[level -1 ] : + &wm->wm[level -1 ]; +else + result_prev = plane_id ? &wm->uv_wm[0 ] : &wm->wm[0 ]; ret = skl_compute_plane_wm(dev_priv, cstate,
@@ -4686,6 +4703,7 @@ skl_compute_wm_levels(const struct drm_i915_private *dev_priv, ddb_blocks, level, wm_params, + result_prev, result);if (ret)return ret;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 8/18 drm/i915/skl+: nv12 workaround disable WM level 1-7
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A) Hardware sometimes fails to wake memory from pkg C states fetching the last few lines of planar YUV 420 (NV12) planes. This causes intermittent underflow and corruption.
WA: Disable package C states or do not enable latency levels 1 through 7 (WM1 - WM7) on NV12 planes.
v2: Addressed review comments by Maarten.
v3: Adding reviewed by tag from Shashank Sharma
v4: Added reviewed by from Juha-Pekka Heikkila
v5: Rebased the series
--- drivers/gpu/drm/i915/intel_pm.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +11 -0
@@ -4653,6 +4653,17 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, } } +/* +* Display WA #826 (SKL:ALL, BXT:ALL) & #1059 (CNL:A) +* disable wm level 1-7 on NV12 planes +*/ +if (wp->is_planar && level >=1 && + (IS_SKYLAKE (dev_priv) ||IS_BROXTON (dev_priv) || +IS_CNL_REVID (dev_priv,CNL_REVID_A0 ,CNL_REVID_A0 ))) { + result->plane_en = false; +return 0 ; + } +/* The number of lines are ignored for the level 0 watermark. */ result->plane_res_b = res_blocks; result->plane_res_l = res_lines;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 9/18 drm/i915/skl: split skl_compute_ddb function
In reply to Vidya SrinivasFrom: Mahesh Kumar <[email protected]>
This patch splits skl_compute_wm/ddb functions into two parts. One adds all affected pipes after the commit to atomic_state structure and second part does compute the DDB.
v2: Added reviewed by tag from Shashank Sharma
v3: Added reviewed by from Juha-Pekka Heikkila
v4: Rebased the series
--- drivers/gpu/drm/i915/intel_pm.c | 157 ++++++++++++++++++++++------------------ 1 file changed, 88 insertions(+), 69 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +88 -69
@@ -5059,69 +5059,16 @@ skl_ddb_add_affected_planes(struct intel_crtc_state *cstate)static int skl_compute_ddb (struct drm_atomic_state *state) { -struct drm_device *dev = state->dev; -struct drm_i915_private *dev_priv =to_i915 (dev); +const struct drm_i915_private *dev_priv =to_i915 (state->dev);struct intel_atomic_state *intel_state =to_intel_atomic_state (state); -struct intel_crtc *intel_crtc;struct skl_ddb_allocation *ddb = &intel_state->wm_results.ddb; -uint32_t realloc_pipes =pipes_modified (state); -int ret; - -/* -* If this is our first atomic update following hardware readout, -* we can't trust the DDB that the BIOS programmed for us. Let's -* pretend that all pipes switched active status so that we'll -* ensure a full DDB recompute. -*/ -if (dev_priv->wm.distrust_bios_wm) { - ret =drm_modeset_lock (&dev->mode_config.connection_mutex, - state->acquire_ctx); -if (ret) -return ret; - - intel_state->active_pipe_changes = ~0 ; - -/* -* We usually only initialize intel_state->active_crtcs if we -* we're doing a modeset; make sure this field is always -* initialized during the sanitization process that happens -* on the first commit too. -*/ -if (!intel_state->modeset) - intel_state->active_crtcs = dev_priv->active_crtcs; - } - -/* -* If the modeset changes which CRTC's are active, we need to -* recompute the DDB allocation for *all* active pipes, even -* those that weren't otherwise being modified in any way by this -* atomic commit. Due to the shrinking of the per-pipe allocations -* when new active CRTC's are added, it's possible for a pipe that -* we were already using and aren't changing at all here to suddenly -* become invalid if its DDB needs exceeds its new allocation. -* -* Note that if we wind up doing a full DDB recompute, we can't let -* any other display updates race with this transaction, so we need -* to grab the lock on *all* CRTC's. -*/ -if (intel_state->active_pipe_changes) { - realloc_pipes = ~0 ; - intel_state->wm_results.dirty_pipes = ~0 ; - } +struct intel_crtc *crtc; +struct intel_crtc_state *cstate; +int ret, i; -/* -* We're not recomputing for the pipes not included in the commit, so -* make sure we start with the current state. -*/ memcpy (ddb, &dev_priv->wm.skl_hw.ddb,sizeof (*ddb)); -for_each_intel_crtc_mask (dev, intel_crtc, realloc_pipes) { -struct intel_crtc_state *cstate; - - cstate =intel_atomic_get_crtc_state (state, intel_crtc); -if (IS_ERR (cstate)) -return PTR_ERR (cstate); - +for_each_new_intel_crtc_in_state (intel_state, crtc, cstate, i) { ret =skl_allocate_pipe_ddb (cstate, ddb);if (ret)return ret;
@@ -5183,23 +5130,23 @@ skl_print_wm_changes(const struct drm_atomic_state *state) }static int -skl_compute_wm (struct drm_atomic_state *state) +skl_ddb_add_affected_pipes (struct drm_atomic_state *state,bool *changed) { -struct drm_crtc *crtc; -struct drm_crtc_state *cstate; -struct intel_atomic_state *intel_state =to_intel_atomic_state (state); -struct skl_ddb_values *results = &intel_state->wm_results;struct drm_device *dev = state->dev; -struct skl_pipe_wm *pipe_wm; -bool changed = false; +const struct drm_i915_private *dev_priv =to_i915 (dev); +const struct drm_crtc *crtc; +const struct drm_crtc_state *cstate; +struct intel_crtc *intel_crtc; +struct intel_atomic_state *intel_state =to_intel_atomic_state (state); +uint32_t realloc_pipes =pipes_modified (state);int ret, i;/* * When we distrust bios wm we always need to recompute to set the * expected DDB allocations for each CRTC. */ -if (to_i915 (dev)->wm.distrust_bios_wm) - changed = true; +if (dev_priv->wm.distrust_bios_wm) + *changed = true;/* * If this transaction isn't actually touching any CRTC's, don't
@@ -5210,14 +5157,86 @@ skl_compute_wm(struct drm_atomic_state *state)* hold _all_ CRTC state mutexes. */ for_each_new_crtc_in_state (state, crtc, cstate, i) - changed = true; + *changed = true; -if (!changed) +if (!*changed)return 0 ; +/* +* If this is our first atomic update following hardware readout, +* we can't trust the DDB that the BIOS programmed for us. Let's +* pretend that all pipes switched active status so that we'll +* ensure a full DDB recompute. +*/ +if (dev_priv->wm.distrust_bios_wm) { + ret =drm_modeset_lock (&dev->mode_config.connection_mutex, + state->acquire_ctx); +if (ret) +return ret; + + intel_state->active_pipe_changes = ~0 ; + +/* +* We usually only initialize intel_state->active_crtcs if we +* we're doing a modeset; make sure this field is always +* initialized during the sanitization process that happens +* on the first commit too. +*/ +if (!intel_state->modeset) + intel_state->active_crtcs = dev_priv->active_crtcs; + } + +/* +* If the modeset changes which CRTC's are active, we need to +* recompute the DDB allocation for *all* active pipes, even +* those that weren't otherwise being modified in any way by this +* atomic commit. Due to the shrinking of the per-pipe allocations +* when new active CRTC's are added, it's possible for a pipe that +* we were already using and aren't changing at all here to suddenly +* become invalid if its DDB needs exceeds its new allocation. +* +* Note that if we wind up doing a full DDB recompute, we can't let +* any other display updates race with this transaction, so we need +* to grab the lock on *all* CRTC's. +*/ +if (intel_state->active_pipe_changes) { + realloc_pipes = ~0 ; + intel_state->wm_results.dirty_pipes = ~0 ; + } + +/* +* We're not recomputing for the pipes not included in the commit, so +* make sure we start with the current state. +*/ +for_each_intel_crtc_mask (dev, intel_crtc, realloc_pipes) { +struct intel_crtc_state *cstate; + + cstate =intel_atomic_get_crtc_state (state, intel_crtc); +if (IS_ERR (cstate)) +return PTR_ERR (cstate); + } + +return 0 ; +} + +static int +skl_compute_wm (struct drm_atomic_state *state) +{ +struct drm_crtc *crtc; +struct drm_crtc_state *cstate; +struct intel_atomic_state *intel_state =to_intel_atomic_state (state); +struct skl_ddb_values *results = &intel_state->wm_results; +struct skl_pipe_wm *pipe_wm; +bool changed = false; +int ret, i; +/* Clear all dirty flags */ results->dirty_pipes =0 ; + ret =skl_ddb_add_affected_pipes (state, &changed); +if (ret || !changed) +return ret; + ret =skl_compute_ddb (state);if (ret)return ret;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 10/18 drm/i915: Set scaler mode for NV12
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling
v2: Review comments from Ville addressed
NV12 case to be checked first for setting
the scaler
v3: Rebased (me)
v4: Rebased (me)
v5: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version.
v6: Rebased (me)
v7: Rebased (me)
v8: Rebased (me)
Restricting the NV12 change for scaler to BXT and KBL in this series.
v9: Rebased (me)
v10: As of now, NV12 has been tested on Gen9 and Gen10. However, code is applicable to all GEN >= 9. Hence making
that change to keep it generic.
Comments under v8 is not valid anymore.
v11: Addressed review comments by Shashank Sharma. For Gen10+, the scaler mode to be set it planar or normal (single bit). Changed the code to be applicable to all Gen.
v12: Addressed review comments from Shashank Sharma For Gen9 (apart from GLK) bits 28:29 to be programmed in PS_CTRL for NV12. For GLK and Gen10+, bit 29 to be set for all Planar.
v13: Addressed review comments from Juha-Pekka Heikkila "NV12 not to be supported by SKL"
Adding Reviewed by tag from Shashank Shamr
v14: Added reviewed by from Juha-Pekka Heikkila
v15: Rebased the series
--- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_atomic.c | 14 ++++++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +2 -0
@@ -6640,6 +6640,8 @@ enum {#define PS_SCALER_MODE_MASK (3 << 28)#define PS_SCALER_MODE_DYN (0 << 28)#define PS_SCALER_MODE_HQ (1 << 28) +#define SKL_PS_SCALER_MODE_NV12 (2 << 28) +#define PS_SCALER_MODE_PLANAR (1 << 29)#define PS_PLANE_SEL_MASK (7 << 25)#define PS_PLANE_SEL (plane) (((plane) + 1) << 25)#define PS_FILTER_MASK (3 << 23)
drivers/gpu/drm/i915/intel_atomic.c +12 -2
@@ -328,8 +328,18 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, }/* set scaler mode */ -if (IS_GEMINILAKE (dev_priv) ||IS_CANNONLAKE (dev_priv)) { - scaler_state->scalers[*scaler_id].mode =0 ; +if ((INTEL_GEN (dev_priv) >=9 ) && + plane_state && plane_state->base.fb && + plane_state->base.fb->format->format == +DRM_FORMAT_NV12 ) { +if (INTEL_GEN (dev_priv) ==9 && + !IS_GEMINILAKE (dev_priv) && + !IS_SKYLAKE (dev_priv)) + scaler_state->scalers[*scaler_id].mode = +SKL_PS_SCALER_MODE_NV12 ; +else + scaler_state->scalers[*scaler_id].mode = +PS_SCALER_MODE_PLANAR ; }else if (num_scalers_need ==1 && intel_crtc->pipe !=PIPE_C ) {/* * when only 1 scaler is in use on either pipe A or B,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 11/18 drm/i915: Update format_is_yuv() to include NV12
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch adds NV12 to format_is_yuv() function
for sprite planes.
v2:
-Use intel_ prefix for format_is_yuv (Ville)
v3: Rebased (me)
v4: Rebased and addressed review comments from Clinton A Taylor. "static function in intel_sprite.c is not available
to the primary plane functions".
Changed commit message - function modified for
sprite planes.
v5: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version.
v6: Rebased (me)
v7: Rebased (me)
v8: Rebased (me)
v9: Rebased (me)
v10: Changed intel_format_is_yuv function from static to non-static. We need to use it later from other files for check.
v11: Rebased the patch. format_is_yuv has already been renamed to intel_format_is_yuv in the color patch series which is already merged. This function which was previously static has already been made non-static. So this patch after rebase just adds NV12 to intel_format_is_yuv function.
v12: Added reviewed by from Juha-Pekka Heikkila
v13/v14/v15: Rebased the series
--- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_sprite.c | 1 + 2 files changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -2054,6 +2054,7 @@ void skl_disable_plane(struct intel_plane *plane, struct intel_crtc *crtc);bool skl_plane_get_hw_state (struct intel_plane *plane);bool skl_plane_has_ccs (struct drm_i915_private *dev_priv,enum pipe pipe,enum plane_id plane_id); +bool intel_format_is_yuv (uint32_t format);/* intel_tv.c */ void intel_tv_init (struct drm_i915_private *dev_priv);
drivers/gpu/drm/i915/intel_sprite.c +1 -0
@@ -48,6 +48,7 @@ bool intel_format_is_yuv(u32 format)case DRM_FORMAT_UYVY :case DRM_FORMAT_VYUY :case DRM_FORMAT_YVYU : +case DRM_FORMAT_NV12 :return true;default :return false;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 12/18 drm/i915: Upscale scaler max scale for NV12
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch updates scaler max limit support for NV12
v2: Rebased (me)
v3: Rebased (me)
v4: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version.
v5: Addressed review comments from Ville and rebased
- calculation of max_scale to be made
less convoluted by splitting it up a bit
- Indentation errors to be fixed in the series
v6: Rebased (me)
Fixed review comments from Paauwe, Bob J
Previous version, where a split of calculation
was done, was wrong. Fixed that issue here.
v7: Rebased (me)
v8: Rebased (me)
v9: Rebased (me)
v10: Rebased (me)
v11: Addressed review comments from Shashank Sharma Alignment issues fixed.
When call to skl_update_scaler is made, 0 was being sent instead of pixel_format.
When crtc update scaler is called, we dont have the fb to derive the pixel format. Added the function parameter bool plane_scaler_check to account for this.
v12: Fixed failure in IGT debugfs_test.
fb is NULL in skl_update_scaler_plane
Due to this, accessing fb->format caused failure.
Patch checks fb before using.
v13: In the previous version there was a flaw.
In skl_update_scaler during plane_scaler_check
if the format was non-NV12, it would set need_scaling to false. This could reset the previously set need_scaling from a previous condition check. Patch fixes this. Patch also adds minimum src height for YUV 420 formats to 16 (as defined in BSpec) and adds for checking this range.
v14: Addressed review comments from Maarten Just add a check for NV12 min src height in skl_update_scaler and retain the remaining checks as is. Added Reviewed By from Juha-Pekka Heikkila.
v15: Rebased the series.
--- drivers/gpu/drm/i915/intel_display.c | 47 +++++++++++++++++++++++++++--------- drivers/gpu/drm/i915/intel_drv.h | 5 +++- drivers/gpu/drm/i915/intel_sprite.c | 5 +++- 3 files changed, 44 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/intel_display.c +36 -11
@@ -3468,6 +3468,8 @@ static u32 skl_plane_ctl_format(uint32_t pixel_format)return PLANE_CTL_FORMAT_YUV422 |PLANE_CTL_YUV422_UYVY ;case DRM_FORMAT_VYUY :return PLANE_CTL_FORMAT_YUV422 |PLANE_CTL_YUV422_VYUY ; +case DRM_FORMAT_NV12 : +return PLANE_CTL_FORMAT_NV12 ;default :MISSING_CASE (pixel_format); }
@@ -4707,7 +4709,9 @@ static void cpt_verify_modeset(struct drm_device *dev, int pipe)static int skl_update_scaler (struct intel_crtc_state *crtc_state,bool force_detach,unsigned int scaler_user,int *scaler_id, -int src_w,int src_h,int dst_w,int dst_h) +int src_w,int src_h,int dst_w,int dst_h, +bool plane_scaler_check, +uint32_t pixel_format) {struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state;
@@ -4725,6 +4729,10 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,*/ need_scaling = src_w != dst_w || src_h != dst_h; +if (plane_scaler_check) +if (pixel_format ==DRM_FORMAT_NV12 ) + need_scaling = true; +if (crtc_state->ycbcr420 && scaler_user ==SKL_CRTC_INDEX ) need_scaling = true;
@@ -4764,6 +4772,12 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,return 0 ; } +if (plane_scaler_check && pixel_format ==DRM_FORMAT_NV12 && + src_h <=SKL_MIN_YUV_420_SRC_H ) { +DRM_DEBUG_KMS ("NV12: scaler out of range\n" ); +return -EINVAL ; + } +/* range checks */ if (src_w < SKL_MIN_SRC_W || src_h < SKL_MIN_SRC_H || dst_w < SKL_MIN_DST_W || dst_h < SKL_MIN_DST_H ||
@@ -4803,9 +4817,10 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state)const struct drm_display_mode *adjusted_mode = &state->base.adjusted_mode;return skl_update_scaler (state, !state->base.active,SKL_CRTC_INDEX , - &state->scaler_state.scaler_id, - state->pipe_src_w, state->pipe_src_h, - adjusted_mode->crtc_hdisplay, adjusted_mode->crtc_vdisplay); + &state->scaler_state.scaler_id, + state->pipe_src_w, state->pipe_src_h, + adjusted_mode->crtc_hdisplay, + adjusted_mode->crtc_vdisplay, false,0 ); }/**
@@ -4834,7 +4849,8 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,drm_rect_width (&plane_state->base.src) >>16 ,drm_rect_height (&plane_state->base.src) >>16 ,drm_rect_width (&plane_state->base.dst), - drm_rect_height(&plane_state->base.dst)); +drm_rect_height (&plane_state->base.dst), + fb ? true : false, fb ? fb->format->format : 0);if (ret || plane_state->scaler_id <0 )return ret;
@@ -4860,6 +4876,7 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,case DRM_FORMAT_YVYU :case DRM_FORMAT_UYVY :case DRM_FORMAT_VYUY : +case DRM_FORMAT_NV12 :break ;default : DRM_DEBUG_KMS("[PLANE:%d:%s] FB:%d unsupported scaling format 0x%x\n",
@@ -12841,11 +12858,13 @@ intel_cleanup_plane_fb(struct drm_plane *plane, }int -skl_max_scale (struct intel_crtc *intel_crtc,struct intel_crtc_state *crtc_state) +skl_max_scale (struct intel_crtc *intel_crtc, +struct intel_crtc_state *crtc_state, +uint32_t pixel_format) {struct drm_i915_private *dev_priv; -int max_scale; -int crtc_clock, max_dotclk; +int max_scale, mult; +int crtc_clock, max_dotclk, tmpclk1, tmpclk2;if (!intel_crtc || !crtc_state->base.enable)return DRM_PLANE_HELPER_NO_SCALING ;
@@ -12867,8 +12886,10 @@ skl_max_scale(struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state* or * cdclk/crtc_clock */ - max_scale =min ((1 <<16 ) *3 -1 , - (1 <<8 ) * ((max_dotclk <<8 ) / crtc_clock)); + mult = pixel_format ==DRM_FORMAT_NV12 ?2 :3 ; + tmpclk1 = (1 <<16 ) * mult -1 ; + tmpclk2 = (1 <<8 ) * ((max_dotclk <<8 ) / crtc_clock); + max_scale =min (tmpclk1, tmpclk2);return max_scale; }
@@ -12884,12 +12905,16 @@ intel_check_primary_plane(struct intel_plane *plane,int max_scale =DRM_PLANE_HELPER_NO_SCALING ;bool can_position = false;int ret; +uint32_t pixel_format =0 ;if (INTEL_GEN (dev_priv) >=9 ) {/* use scaler when colorkey is not required */ if (!state->ckey.flags) { min_scale =1 ; - max_scale =skl_max_scale (to_intel_crtc (crtc), crtc_state); +if (state->base.fb) + pixel_format = state->base.fb->format->format; + max_scale =skl_max_scale (to_intel_crtc (crtc), + crtc_state, pixel_format); } can_position = true; }
drivers/gpu/drm/i915/intel_drv.h +4 -1
@@ -552,6 +552,8 @@ struct intel_initial_plane_config {#define ICL_MAX_SRC_H 4096#define ICL_MAX_DST_W 5120#define ICL_MAX_DST_H 4096 +#define SKL_MIN_YUV_420_SRC_W 16 +#define SKL_MIN_YUV_420_SRC_H 16struct intel_scaler {int in_use;
@@ -1596,7 +1598,8 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode, struct intel_crtc_state *pipe_config);int skl_update_scaler_crtc (struct intel_crtc_state *crtc_state); -int skl_max_scale (struct intel_crtc *crtc,struct intel_crtc_state *crtc_state); +int skl_max_scale (struct intel_crtc *crtc,struct intel_crtc_state *crtc_state, +uint32_t pixel_format);static inline u32 intel_plane_ggtt_offset (const struct intel_plane_state *state) {
drivers/gpu/drm/i915/intel_sprite.c +4 -1
@@ -947,6 +947,7 @@ intel_check_sprite_plane(struct intel_plane *plane,int max_scale, min_scale;bool can_scale;int ret; +uint32_t pixel_format =0 ; *src =drm_plane_state_src (&state->base); *dst =drm_plane_state_dest (&state->base);
@@ -970,11 +971,13 @@ intel_check_sprite_plane(struct intel_plane *plane,/* setup can_scale, min_scale, max_scale */ if (INTEL_GEN (dev_priv) >=9 ) { +if (state->base.fb) + pixel_format = state->base.fb->format->format;/* use scaler when colorkey is not required */ if (!state->ckey.flags) { can_scale =1 ; min_scale =1 ; - max_scale =skl_max_scale (crtc, crtc_state); + max_scale =skl_max_scale (crtc, crtc_state, pixel_format); }else { can_scale =0 ; min_scale =DRM_PLANE_HELPER_NO_SCALING ;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 13/18 drm/i915: Add NV12 as supported format for primary plane
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch adds NV12 to list of supported formats for primary plane
v2: Rebased (Chandra Konduru)
v3: Rebased (me)
v4: Review comments by Ville addressed
Removed the skl_primary_formats_with_nv12 and
added NV12 case in existing skl_primary_formats
v5: Rebased (me)
v6: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version.
v7: Review comments by Ville addressed
Restricting the NV12 for BXT and on PIPE A and B
Rebased (me)
v8: Rebased (me)
Modified restricting the NV12 support for both BXT and KBL.
v9: Rebased (me)
v10: Addressed review comments from Maarten.
Adding NV12 inside skl_primary_formats itself.
v11: Adding Reviewed By tag from Shashank Sharma
v12: Addressed review comments from Juha-Pekka Heikkila "NV12 not to be supported by SKL"
v13: Addressed review comments from Ville
Added skl_pri_planar_formats to include NV12
and skl_plane_has_planar function to check for
NV12 support on plane. Added NV12 format toskl_mod_supported. These were review comments
from Kristian Høgsberg <[email protected]>
v14: Added reviewed by from Juha-Pekka Heikkila
v15: Rebased the series
--- drivers/gpu/drm/i915/intel_display.c | 50 ++++++++++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_drv.h | 2 ++ 2 files changed, 50 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +48 -2
@@ -88,6 +88,22 @@ static const uint32_t skl_primary_formats[] = { DRM_FORMAT_VYUY, }; +static const uint32_t skl_pri_planar_formats[] = { +DRM_FORMAT_C8 , +DRM_FORMAT_RGB565 , +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_XBGR8888 , +DRM_FORMAT_ARGB8888 , +DRM_FORMAT_ABGR8888 , +DRM_FORMAT_XRGB2101010 , +DRM_FORMAT_XBGR2101010 , +DRM_FORMAT_YUYV , +DRM_FORMAT_YVYU , +DRM_FORMAT_UYVY , +DRM_FORMAT_VYUY , +DRM_FORMAT_NV12 , +}; +static const uint64_t skl_format_modifiers_noccs[] = { I915_FORMAT_MOD_Yf_TILED,I915_FORMAT_MOD_Y_TILED ,
@@ -13075,6 +13091,7 @@ static bool skl_mod_supported(uint32_t format, uint64_t modifier)case DRM_FORMAT_YVYU :case DRM_FORMAT_UYVY :case DRM_FORMAT_VYUY : +case DRM_FORMAT_NV12 :if (modifier == I915_FORMAT_MOD_Yf_TILED)return true;/* fall through */
@@ -13282,6 +13299,30 @@ static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv,return pipe ==PIPE_A && plane_id ==PLANE_PRIMARY ; } +bool skl_plane_has_planar (struct drm_i915_private *dev_priv, +enum pipe pipe,enum plane_id plane_id) +{ +if (plane_id ==PLANE_PRIMARY ) { +if (IS_SKYLAKE (dev_priv)) +return false; +else if ((INTEL_GEN (dev_priv) ==9 && pipe ==PIPE_C ) && + !IS_GEMINILAKE (dev_priv)) +return false; + }else if (plane_id >=PLANE_SPRITE0 ) { +if (plane_id ==PLANE_CURSOR ) +return false; +if (IS_GEMINILAKE (dev_priv) ||INTEL_GEN (dev_priv) ==10 ) { +if (plane_id !=PLANE_SPRITE0 ) +return false; + }else { +if (plane_id !=PLANE_SPRITE0 || pipe ==PIPE_C || +IS_SKYLAKE (dev_priv)) +return false; + } + } +return true; +} +static struct intel_plane *intel_primary_plane_create (struct drm_i915_private *dev_priv,enum pipe pipe) {
@@ -13342,8 +13383,13 @@ intel_primary_plane_create(struct drm_i915_private *dev_priv, enum pipe pipe) primary->check_plane = intel_check_primary_plane;if (INTEL_GEN (dev_priv) >=9 ) { - intel_primary_formats = skl_primary_formats; - num_formats =ARRAY_SIZE (skl_primary_formats); +if (skl_plane_has_planar (dev_priv, pipe,PLANE_PRIMARY )) { + intel_primary_formats = skl_pri_planar_formats; + num_formats =ARRAY_SIZE (skl_pri_planar_formats); + }else { + intel_primary_formats = skl_primary_formats; + num_formats =ARRAY_SIZE (skl_primary_formats); + }if (skl_plane_has_ccs (dev_priv, pipe,PLANE_PRIMARY )) modifiers = skl_format_modifiers_ccs;
drivers/gpu/drm/i915/intel_drv.h +2 -0
@@ -2058,6 +2058,8 @@ bool skl_plane_get_hw_state(struct intel_plane *plane);bool skl_plane_has_ccs (struct drm_i915_private *dev_priv,enum pipe pipe,enum plane_id plane_id);bool intel_format_is_yuv (uint32_t format); +bool skl_plane_has_planar (struct drm_i915_private *dev_priv, +enum pipe pipe,enum plane_id plane_id);/* intel_tv.c */ void intel_tv_init (struct drm_i915_private *dev_priv);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 14/18 drm/i915: Add NV12 as supported format for sprite plane
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch adds NV12 to list of supported formats for sprite plane.
v2: Rebased (me)
v3: Review comments by Ville addressed
- Removed skl_plane_formats_with_nv12 and added
NV12 case in existing skl_plane_formats
- Added the 10bpc RGB formats
v4: Addressed review comments from Clinton A Taylor
"Why are we adding 10 bit RGB formats with the NV12 series patches? Trying to set XR30 or AB30 results in error returned even though the modes are advertised for the planes"
- Removed 10bit RGB formats added previously with NV12 series
v5: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version. Addressed review comments from Clinton A Taylor
"Why are we adding 10 bit RGB formats with the NV12 series patches? Trying to set XR30 or AB30 results in error returned even though the modes are advertised for the planes"
- Previous version has 10bit RGB format removed from VLV formats by mistake. Fixing that in this version.
Removed 10bit RGB formats added previously with NV12 series for SKL.
v6: Addressed review comments by Ville
Restricting the NV12 to BXT and PIPE A and B
v7: Rebased (me)
v8: Rebased (me)
Restricting NV12 changes to BXT and KBL
Restricting NV12 changes for plane 0 (overlay)
v9: Rebased (me)
v10: Addressed review comments from Maarten.
Adding NV12 to skl_plane_formats itself.
v11: Addressed review comments from Shashank Sharma
v12: Addressed review comments from Shashank Sharma Made the condition in intel_sprite_plane_create simple and easy to read as suggested.
v13: Adding reviewed by tag from Shashank Sharma Addressed review comments from Juha-Pekka Heikkila "NV12 not to be supported by SKL"
v14: Addressed review comments from Ville
Added skl_planar_formats to include NV12
and a check skl_plane_has_planar in sprite create Added NV12 format to skl_mod_supported. These were review comments from Kristian Høgsberg <[email protected]>
v15: Added reviewed by from Juha-Pekka Heikkila
v16: Rebased the series
--- drivers/gpu/drm/i915/intel_sprite.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_sprite.c +22 -2
@@ -1252,6 +1252,19 @@ static uint32_t skl_plane_formats[] = { DRM_FORMAT_VYUY, }; +static uint32_t skl_planar_formats[] = { +DRM_FORMAT_RGB565 , +DRM_FORMAT_ABGR8888 , +DRM_FORMAT_ARGB8888 , +DRM_FORMAT_XBGR8888 , +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_YUYV , +DRM_FORMAT_YVYU , +DRM_FORMAT_UYVY , +DRM_FORMAT_VYUY , +DRM_FORMAT_NV12 , +}; +static const uint64_t skl_plane_format_modifiers_noccs[] = { I915_FORMAT_MOD_Yf_TILED,I915_FORMAT_MOD_Y_TILED ,
@@ -1346,6 +1359,7 @@ static bool skl_mod_supported(uint32_t format, uint64_t modifier)case DRM_FORMAT_YVYU :case DRM_FORMAT_UYVY :case DRM_FORMAT_VYUY : +case DRM_FORMAT_NV12 :if (modifier == I915_FORMAT_MOD_Yf_TILED)return true;/* fall through */
@@ -1445,8 +1459,14 @@ intel_sprite_plane_create(struct drm_i915_private *dev_priv, intel_plane->disable_plane = skl_disable_plane; intel_plane->get_hw_state = skl_plane_get_hw_state; - plane_formats = skl_plane_formats; - num_plane_formats =ARRAY_SIZE (skl_plane_formats); +if (skl_plane_has_planar (dev_priv, pipe, +PLANE_SPRITE0 + plane)) { + plane_formats = skl_planar_formats; + num_plane_formats =ARRAY_SIZE (skl_planar_formats); + }else { + plane_formats = skl_plane_formats; + num_plane_formats =ARRAY_SIZE (skl_plane_formats); + }if (skl_plane_has_ccs (dev_priv, pipe,PLANE_SPRITE0 + plane)) modifiers = skl_plane_format_modifiers_ccs;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 15/18 drm/i915: Add NV12 support to intel_framebuffer_init
In reply to Vidya SrinivasFrom: Chandra Konduru <[email protected]>
This patch adds NV12 as supported format
to intel_framebuffer_init and performs various checks.
v2:
-Fix an issue in checks added (Chandra Konduru)
v3: rebased (me)
v4: Review comments by Ville addressed
Added platform check for NV12 in intel_framebuffer_init Removed offset checks for NV12 case
v5: Addressed review comments by Clinton A Taylor
This NV12 support only correctly works on SKL.
Plane color space conversion is different on GLK and later platforms causing the colors to display incorrectly.
Ville's plane color space property patch series
in review will fix this issue.
- Restricted the NV12 case in intel_framebuffer_init to SKL and BXT only.
v6: Rebased (me)
v7: Addressed review comments by Ville
Restricting the NV12 to BXT for now.
v8: Rebased (me)
Restricting the NV12 changes to BXT and KBL for now.
v9: Rebased (me)
v10: NV12 supported by all GEN >= 9.
Making this change in intel_framebuffer_init. This is part of addressing Maarten's review comments. Comment under v8 no longer applicable
v11: Addressed review comments from Shashank Sharma
v12: Adding Reviewed By from Shashank Sharma
v13: Addressed review comments from Juha-Pekka Heikkila "NV12 not to be supported by SKL"
v14: Addressed review comments from Maarten. Add checks for fb width height for NV12 and fail the fb creation if check fails. Added reviewed by from Juha-Pekka Heikkila
v15: Rebased the series
--- drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/gpu/drm/i915/intel_display.c +15 -0
@@ -14210,6 +14210,14 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, goto err; }break ; +case DRM_FORMAT_NV12 : +if (INTEL_GEN (dev_priv) <9 ||IS_SKYLAKE (dev_priv)) { +DRM_DEBUG_KMS ("unsupported pixel format: %s\n" , +drm_get_format_name (mode_cmd->pixel_format, + &format_name)); + goto err; + } +break ;default :DRM_DEBUG_KMS ("unsupported pixel format: %s\n" ,drm_get_format_name (mode_cmd->pixel_format, &format_name));
@@ -14222,6 +14230,13 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,drm_helper_mode_fill_fb_struct (&dev_priv->drm, fb, mode_cmd); +if (fb->format->format ==DRM_FORMAT_NV12 && + (fb->width <=SKL_MIN_YUV_420_SRC_W || + fb->height <=SKL_MIN_YUV_420_SRC_H )) { +DRM_DEBUG_KMS ("Min fb dimensions not met for planar format\n" ); +return -EINVAL ; + } +for (i =0 ; i < fb->format->num_planes; i++) {u32 stride_alignment;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 16/18 drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg
In reply to Vidya SrinivasIf the fb format is YUV, enable the plane CSC mode bits for the conversion.
v2: Addressed review comments from Shashank Sharma Alignment issue fixed in i915_reg.h
v3: Adding Reviewed By from Shashank Sharma
v4: Rebased the patch. As part of rebasing, re-using the color series defines which are already merged. plane_state->base.color_encoding might not be set for NV12. For now, just using PLANE_COLOR_CSC_MODE_YUV709_TO_RGB709 in glk_plane_color_ctl if format is NV12.
v5: Added reviewed by from Juha-Pekka Heikkila
v6: Rebased the series
--- drivers/gpu/drm/i915/intel_display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +6 -1
@@ -3633,6 +3633,11 @@ u32 glk_plane_color_ctl(const struct intel_crtc_state *crtc_state, plane_color_ctl |=glk_plane_color_ctl_alpha (fb->format->format);if (intel_format_is_yuv (fb->format->format)) { +if (fb->format->format ==DRM_FORMAT_NV12 ) { + plane_color_ctl |= +PLANE_COLOR_CSC_MODE_YUV709_TO_RGB709 ; + goto out; + }if (plane_state->base.color_encoding ==DRM_COLOR_YCBCR_BT709 ) plane_color_ctl |=PLANE_COLOR_CSC_MODE_YUV709_TO_RGB709 ;else
@@ -3641,7 +3646,7 @@ u32 glk_plane_color_ctl(const struct intel_crtc_state *crtc_state,if (plane_state->base.color_range ==DRM_COLOR_YCBCR_FULL_RANGE ) plane_color_ctl |=PLANE_COLOR_YUV_RANGE_CORRECTION_DISABLE ; } - +out:return plane_color_ctl; }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 17/18 drm/i915: Display WA 827
In reply to Vidya SrinivasDisplay WA 827 applies to GEN9 (excluede GLK) and CNL. Switching the plane format from NV12 to RGB and leaving system idle results in display underrun and corruption.
WA: Set the bit 15 & bit 19 to 1b in the CLKGATE_DIS_PSL register for the pipe in which NV12 plane is enabled.
v2: Addressed review comments from Maarten and
Juha-Pekka Heikkila. Added reviewed by from
Juha-Pekka Heikkila.
v3: Rebased the series
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_display.c | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -3806,6 +3806,9 @@ enum {#define _CLKGATE_DIS_PSL_A 0x46520#define _CLKGATE_DIS_PSL_B 0x46524#define _CLKGATE_DIS_PSL_C 0x46528 +#define DUPS1_GATING_DIS (1 << 15) +#define DUPS2_GATING_DIS (1 << 19) +#define DUPS3_GATING_DIS (1 << 23)#define DPF_GATING_DIS (1 << 10)#define DPF_RAM_GATING_DIS (1 << 9)#define DPFR_GATING_DIS (1 << 8)
drivers/gpu/drm/i915/intel_display.c +34 -0
@@ -504,6 +504,21 @@ static const struct intel_limit intel_limits_bxt = { .p2 = { .p2_slow = 1, .p2_fast = 20 }, }; +static void +skl_wa_clkgate (struct drm_i915_private *dev_priv,int pipe,bool enable) +{ +if (IS_SKYLAKE (dev_priv)) +return ; + +if (enable) +I915_WRITE (CLKGATE_DIS_PSL (pipe), +DUPS1_GATING_DIS |DUPS2_GATING_DIS ); +else +I915_WRITE (CLKGATE_DIS_PSL (pipe), +I915_READ (CLKGATE_DIS_PSL (pipe)) & + ~(DUPS1_GATING_DIS |DUPS2_GATING_DIS )); +} +static bool needs_modeset (const struct drm_crtc_state *state) {
@@ -5144,6 +5159,8 @@ static bool hsw_post_update_enable_ips(const struct intel_crtc_state *old_crtc_sstatic void intel_post_plane_update (struct intel_crtc_state *old_crtc_state) {struct intel_crtc *crtc =to_intel_crtc (old_crtc_state->base.crtc); +struct drm_device *dev = crtc->base.dev; +struct drm_i915_private *dev_priv =to_i915 (dev);struct drm_atomic_state *old_state = old_crtc_state->base.state;struct intel_crtc_state *pipe_config = intel_atomic_get_new_crtc_state(to_intel_atomic_state(old_state),
@@ -5166,6 +5183,7 @@ static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state) to_intel_plane(primary));struct intel_plane_state *old_primary_state =to_intel_plane_state (old_pri_state); +struct drm_framebuffer *fb = primary_state->base.fb;intel_fbc_post_update (crtc);
@@ -5173,6 +5191,14 @@ static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state) (needs_modeset(&pipe_config->base) || !old_primary_state->base.visible))intel_post_enable_primary (&crtc->base, pipe_config); + +/* Display WA 827 */ +if ((INTEL_GEN (dev_priv) ==9 && !IS_GEMINILAKE (dev_priv)) || +IS_CANNONLAKE (dev_priv)) { +if (fb && fb->format->format ==DRM_FORMAT_NV12 ) +skl_wa_clkgate (dev_priv, crtc->pipe, false); + } + } }
@@ -5199,6 +5225,14 @@ static void intel_pre_plane_update(struct intel_crtc_state *old_crtc_state, to_intel_plane(primary));struct intel_plane_state *old_primary_state =to_intel_plane_state (old_pri_state); +struct drm_framebuffer *fb = primary_state->base.fb; + +/* Display WA 827 */ +if ((INTEL_GEN (dev_priv) ==9 && !IS_GEMINILAKE (dev_priv)) || +IS_CANNONLAKE (dev_priv)) { +if (fb && fb->format->format ==DRM_FORMAT_NV12 ) +skl_wa_clkgate (dev_priv, crtc->pipe, true); + }intel_fbc_pre_update (crtc, pipe_config, primary_state);/*
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v16 18/18 drm/i915: Add checks to primary plane
In reply to Vidya SrinivasPatch adds checks to primary plane related
to scaling, clipping, rotation and fb formats. These checks currently, were being done only for sprites. These are required for primary plane as well.
Credits-to: Maarten Lankhorst <[email protected]>
--- drivers/gpu/drm/i915/intel_display.c | 127 ++++++++++++++++++++++++++++++++++- 1 file changed, 125 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +125 -2
@@ -12956,11 +12956,16 @@ intel_check_primary_plane(struct intel_plane *plane, {struct drm_i915_private *dev_priv =to_i915 (plane->base.dev);struct drm_crtc *crtc = state->base.crtc; +struct drm_framebuffer *fb = state->base.fb;int min_scale =DRM_PLANE_HELPER_NO_SCALING ;int max_scale =DRM_PLANE_HELPER_NO_SCALING ; -bool can_position = false; -int ret; +bool can_position = false, can_scale = false;uint32_t pixel_format =0 ; +int crtc_x, crtc_y, hscale, vscale, ret; +uint32_t src_x, src_y, src_w, src_h, crtc_w, crtc_h; +struct drm_rect *src = &state->base.src; +struct drm_rect *dst = &state->base.dst; +struct drm_rect clip = {};if (INTEL_GEN (dev_priv) >=9 ) {/* use scaler when colorkey is not required */
@@ -12972,6 +12977,7 @@ intel_check_primary_plane(struct intel_plane *plane, crtc_state, pixel_format); } can_position = true; + can_scale = true; } ret = drm_atomic_helper_check_plane_state(&state->base,
@@ -12984,6 +12990,123 @@ intel_check_primary_plane(struct intel_plane *plane,if (!state->base.fb)return 0 ; + *src =drm_plane_state_src (&state->base); + *dst =drm_plane_state_dest (&state->base); + +drm_rect_rotate (src, fb->width <<16 , fb->height <<16 , + state->base.rotation); + + hscale =drm_rect_calc_hscale_relaxed (src, dst, min_scale, max_scale); +WARN_ON (hscale <0 ); + + vscale =drm_rect_calc_vscale_relaxed (src, dst, min_scale, max_scale); +WARN_ON (vscale <0 ); + +if (crtc_state->base.enable) +drm_mode_get_hv_timing (&crtc_state->base.mode, + &clip.x2, &clip.y2); + + state->base.visible = +drm_rect_clip_scaled (src, dst, &clip, hscale, vscale); + + crtc_x = dst->x1; + crtc_y = dst->y1; + crtc_w =drm_rect_width (dst); + crtc_h =drm_rect_height (dst); + +if (state->base.visible) { +/* check again in case clipping clamped the results */ + hscale =drm_rect_calc_hscale (src, dst, min_scale, max_scale); +if (hscale <0 ) { +DRM_DEBUG_KMS ("Horizontal scaling factor out of limits\n" ); +drm_rect_debug_print ("src: " , src, true); +drm_rect_debug_print ("dst: " , dst, false); + +return hscale; + } + + vscale =drm_rect_calc_vscale (src, dst, min_scale, max_scale); +if (vscale <0 ) { +DRM_DEBUG_KMS ("Vertical scaling factor out of limits\n" ); +drm_rect_debug_print ("src: " , src, true); +drm_rect_debug_print ("dst: " , dst, false); + +return vscale; + } + +/* +* Make the source viewport size an exact +* multiple of the scaling factors. +*/ +drm_rect_adjust_size (src, +drm_rect_width (dst) * hscale -drm_rect_width (src), +drm_rect_height (dst) * vscale -drm_rect_height (src)); + +drm_rect_rotate_inv (src, fb->width <<16 , fb->height <<16 , + state->base.rotation); + +/* +* sanity check to make sure the src +* viewport wasn't enlarged +*/ +WARN_ON (src->x1 < (int ) state->base.src_x || + src->y1 < (int ) state->base.src_y || + src->x2 > (int ) state->base.src_x + state->base.src_w || + src->y2 > (int ) state->base.src_y + state->base.src_h); + + src_x = src->x1 >>16 ; + src_w =drm_rect_width (src) >>16 ; + src_y = src->y1 >>16 ; + src_h =drm_rect_height (src) >>16 ; + +if (intel_format_is_yuv (fb->format->format)) { + src_x &= ~1 ; + src_w &= ~1 ; + +if (!can_scale) + crtc_w &= ~1 ; + +if (crtc_w ==0 ) + state->base.visible = false; + } + } + +/* Check size restrictions when scaling */ +if (state->base.visible && (src_w != crtc_w || src_h != crtc_h)) { +unsigned int width_bytes; +int cpp = fb->format->cpp[0 ]; + +WARN_ON (!can_scale); + +/* FIXME interlacing min height is 6 */ + +if (crtc_w <3 || crtc_h <3 ) + state->base.visible = false; + +if (src_w <3 || src_h <3 ) + state->base.visible = false; + + width_bytes = ((src_x * cpp) &63 ) + src_w * cpp; + +if (INTEL_GEN (dev_priv) <9 && (src_w >2048 || src_h >2048 || + width_bytes >4096 || fb->pitches[0 ] >4096 )) { +DRM_DEBUG_KMS ("Source dimensions exceed hardware limits\n" ); +return -EINVAL ; + } + } + +if (state->base.visible) { + src->x1 = src_x <<16 ; + src->x2 = (src_x + src_w) <<16 ; + src->y1 = src_y <<16 ; + src->y2 = (src_y + src_h) <<16 ; + } + + dst->x1 = crtc_x; + dst->x2 = crtc_x + crtc_w; + dst->y1 = crtc_y; + dst->y2 = crtc_y + crtc_h; +if (INTEL_GEN (dev_priv) >=9 ) { ret =skl_check_plane_surface (crtc_state, state);if (ret)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for Add NV12 support (rev4)
In reply to Vidya Srinivas== Series Details ==
== Series Details ==
Series: Add NV12 support (rev4)
URL : https://patchwork.freedesktop.org/series/39670/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 0503b1db737a drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values de530aafc1d7 drm/i915/skl+: refactor WM calculation for NV12 7ca6efaada2b drm/i915/skl+: add NV12 in skl_format_to_fourcc 4863044b11a5 drm/i915/skl+: support verification of DDB HW state for NV12 4c4d4f07274c drm/i915/skl+: NV12 related changes for WM 1995882fa722 drm/i915/skl+: pass skl_wm_level struct to wm compute func 7a53eb021631 drm/i915/skl+: make sure higher latency level has higher wm value b756f5e1b974 drm/i915/skl+: nv12 workaround disable WM level 1-7 2f6264f9349f drm/i915/skl: split skl_compute_ddb function -:137: CHECK:SPACING: spaces preferred around that '*' (ctx:ExV) #137: FILE: drivers/gpu/drm/i915/intel_pm.c:5160: + *changed = true; ^
total: 0 errors, 0 warnings, 1 checks, 194 lines checked d87f6cf26fea drm/i915: Set scaler mode for NV12 ccc7a37f5e0a drm/i915: Update format_is_yuv() to include NV12 17490b4ce656 drm/i915: Upscale scaler max scale for NV12 e155048376b9 drm/i915: Add NV12 as supported format for primary plane d7af95f5e1d4 drm/i915: Add NV12 as supported format for sprite plane 483020f92c69 drm/i915: Add NV12 support to intel_framebuffer_init 4ca02e5f9bd0 drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg a7f9ce556ab2 drm/i915: Display WA 827545fe6ed4604 drm/i915: Add checks to primary plane
-:108: CHECK:SPACING: No space is necessary after a cast #108: FILE: drivers/gpu/drm/i915/intel_display.c:13052:
+ WARN_ON(src->x1 < (int) state->base.src_x ||
-:109: CHECK:SPACING: No space is necessary after a cast #109: FILE: drivers/gpu/drm/i915/intel_display.c:13053:
+ src->y1 < (int) state->base.src_y ||
-:110: CHECK:SPACING: No space is necessary after a cast #110: FILE: drivers/gpu/drm/i915/intel_display.c:13054:
+ src->x2 > (int) state->base.src_x + state->base.src_w ||
-:111: CHECK:SPACING: No space is necessary after a cast #111: FILE: drivers/gpu/drm/i915/intel_display.c:13055:
+ src->y2 > (int) state->base.src_y + state->base.src_h);
-:148: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #148: FILE: drivers/gpu/drm/i915/intel_display.c:13092:
+ if (INTEL_GEN(dev_priv) < 9 && (src_w > 2048 || src_h > 2048 ||
+ width_bytes > 4096 || fb->pitches[0] > 4096)) {
total: 0 errors, 0 warnings, 5 checks, 148 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: ✗ Fi.CI.CHECKPATCH: warning for Add NV12 support (rev4)
Quoted 20 lines · Patchwork
== Series Details ==
Series: Add NV12 support (rev4)
URL : https://patchwork.freedesktop.org/series/39670/
State : warning== Summary ==
$ dim checkpatch origin/drm-tip 0503b1db737a drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values de530aafc1d7 drm/i915/skl+: refactor WM calculation for NV12 7ca6efaada2b drm/i915/skl+: add NV12 in skl_format_to_fourcc 4863044b11a5 drm/i915/skl+: support verification of DDB HW state for NV12 4c4d4f07274c drm/i915/skl+: NV12 related changes for WM 1995882fa722 drm/i915/skl+: pass skl_wm_level struct to wm compute func 7a53eb021631 drm/i915/skl+: make sure higher latency level has higher wm value b756f5e1b974 drm/i915/skl+: nv12 workaround disable WM level 1-7 2f6264f9349f drm/i915/skl: split skl_compute_ddb function -:137: CHECK:SPACING: spaces preferred around that '*' (ctx:ExV) #137: FILE: drivers/gpu/drm/i915/intel_pm.c:5160:
Review
Quoted 2 lines
(quoted diff) +1
-0+ *changed = true; ^
Checkpatch being clueless.
Quoted 26 lines
total: 0 errors, 0 warnings, 1 checks, 194 lines checked
d87f6cf26feadrm/i915: Set scaler mode for NV12ccc7a37f5e0adrm/i915: Updateformat_is_yuv()to include NV1217490b4ce656drm/i915: Upscale scaler max scale for NV12e155048376b9drm/i915: Add NV12 as supported format for primary planed7af95f5e1d4drm/i915: Add NV12 as supported format for sprite plane483020f92c69drm/i915: Add NV12 support tointel_framebuffer_init4ca02e5f9bd0drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Rega7f9ce556ab2drm/i915: Display WA 827545fe6ed4604drm/i915: Add checks to primary plane
-:108: CHECK:SPACING: No space is necessary after a cast #108: FILE:drivers/gpu/drm/i915/intel_display.c:13052:(quoted diff) +1
-1+ WARN_ON(src->x1 < (int) state->base.src_x || -:109: CHECK:SPACING: No space is necessary after a cast#109: FILE:
drivers/gpu/drm/i915/intel_display.c:13053:(quoted diff) +1
-1+ src->y1 < (int) state->base.src_y || -:110: CHECK:SPACING: No space is necessary after a cast#110: FILE:
drivers/gpu/drm/i915/intel_display.c:13054:(quoted diff) +1
-1+ src->x2 > (int) state->base.src_x + state->base.src_w || -:111: CHECK:SPACING: No space is necessary after a cast#111: FILE:
drivers/gpu/drm/i915/intel_display.c:13055:
Review
Quoted 1 line
(quoted diff) +1
-0+ src->y2 > (int) state->base.src_y + state->base.src_h);
I don't mind the spaces after a cast; sadly SPACING category is not something I'm willing to ignore completely.
Review
Quoted 4 lines
-:148: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #148: FILE:
drivers/gpu/drm/i915/intel_display.c:13092:(quoted diff) +2
-0+ if (INTEL_GEN(dev_priv) < 9 && (src_w > 2048 || src_h > 2048 || + width_bytes > 4096 || fb->pitches[0] > 4096)) {
Pedantically a valid warning, but can be ignored in favor of getting the series finally merged.
BR,
Jani.
Quoted 7 lines
total: 0 errors, 0 warnings, 5 checks, 148 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.CHECKPATCH: warning for Add NV12 support (rev4)
Quoted 79 lines
-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Monday, March 26, 2018 7:19 PM
To: Patchwork <[email protected]>; Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add NV12 support (rev4)Quoted 23 lines · Patchwork
== Series Details ==
Series: Add NV12 support (rev4)
URL : https://patchwork.freedesktop.org/series/39670/
State : warning== Summary ==
$ dim checkpatch origin/drm-tip 0503b1db737a drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values de530aafc1d7 drm/i915/skl+: refactor WM calculation for NV12 7ca6efaada2b drm/i915/skl+: add NV12 in skl_format_to_fourcc 4863044b11a5 drm/i915/skl+: support verification of DDB HW state for NV12 4c4d4f07274c drm/i915/skl+: NV12 related changes for WM 1995882fa722 drm/i915/skl+: pass skl_wm_level struct to wm compute func 7a53eb021631 drm/i915/skl+: make sure higher latency level has higher wm value b756f5e1b974 drm/i915/skl+: nv12 workaround disable WM level 1-7 2f6264f9349f drm/i915/skl: split skl_compute_ddb function -:137: CHECK:SPACING: spaces preferred around that '*' (ctx:ExV) #137: FILE: drivers/gpu/drm/i915/intel_pm.c:5160:Review
Quoted 2 lines
(quoted diff) +1
-0+ *changed = true; ^Checkpatch being clueless.
Quoted 21 lines
total: 0 errors, 0 warnings, 1 checks, 194 lines checked
d87f6cf26feadrm/i915: Set scaler mode for NV12ccc7a37f5e0adrm/i915: Updateformat_is_yuv()to include NV1217490b4ce656drm/i915: Upscale scaler max scale for NV12e155048376b9drm/i915: Add NV12 as supported format for primary planed7af95f5e1d4drm/i915: Add NV12 as supported format for sprite plane483020f92c69drm/i915: Add NV12 support tointel_framebuffer_init4ca02e5f9bd0drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Rega7f9ce556ab2drm/i915: Display WA 827545fe6ed4604drm/i915: Add checks to primary plane
-:108: CHECK:SPACING: No space is necessary after a cast #108: FILE:drivers/gpu/drm/i915/intel_display.c:13052:(quoted diff) +1
-1+ WARN_ON(src->x1 < (int) state->base.src_x || -:109: CHECK:SPACING: No space is necessary after a cast#109: FILE:
drivers/gpu/drm/i915/intel_display.c:13053:(quoted diff) +1
-1+ src->y1 < (int) state->base.src_y || -:110: CHECK:SPACING: No space is necessary after a cast#110: FILE:
drivers/gpu/drm/i915/intel_display.c:13054:Review
Quoted 1 line
(quoted diff) +1
-0+ src->x2 > (int) state->base.src_x + state->base.src_w||
Quoted 6 lines
-:111: CHECK:SPACING: No space is necessary after a cast #111: FILE:
drivers/gpu/drm/i915/intel_display.c:13055:(quoted diff) +1
-0+ src->y2 > (int) state->base.src_y + state-base.src_h);
I don't mind the spaces after a cast; sadly SPACING category is not something I'm willing to ignore completely.
Review
Quoted 4 lines
-:148: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#148: FILE:drivers/gpu/drm/i915/intel_display.c:13092:(quoted diff) +1
-0+ if (INTEL_GEN(dev_priv) < 9 && (src_w > 2048 || src_h >2048 ||
Quoted 4 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ width_bytes > 4096 || fb->pitches[0] > 4096)) {Pedantically a valid warning, but can be ignored in favor of getting the series finally merged.
Thank you. Since this is new patch (sorry, mostly I just copied code from intel_sprite.c) Still RB is needed on this patch. I will fix these mistakes during the next push.
Quoted 7 lines
BR,
Jani.Quoted 3 lines
total: 0 errors, 0 warnings, 5 checks, 148 lines checked
Quoted 7 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Add NV12 support (rev4)
In reply to Vidya Srinivas== Series Details ==
== Series Details ==
Series: Add NV12 support (rev4)
URL : https://patchwork.freedesktop.org/series/39670/
State : success
== Summary ==
Series 39670v4 Add NV12 support
https://patchwork.freedesktop.org/api/1.0/series/39670/revisions/4/mbox/
---- Known issues:
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
Subgroup suspend-read-crc-pipe-c:
incomplete -> PASS (fi-hsw-4770) fdo#104944fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104944 https://bugs.freedesktop.org/show_bug.cgi?id=104944
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:429s fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:445s fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:380s fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:543s fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:296s fi-bxt-dsi total:243 pass:216 dwarn:0 dfail:0 fail:0 skip:26 fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:511s fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:525s fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:504s fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:409s fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:511s fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:427s fi-gdg-551 total:285 pass:177 dwarn:0 dfail:0 fail:0 skip:108 time:316s fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:538s fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:405s fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:417s fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:475s fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:430s fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:474s fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:466s fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:513s fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:653s fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:437s fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:536s fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:508s fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:490s fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:428s fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:442s fi-snb-2520m total:242 pass:208 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:401s Blacklisted hosts: fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:567s fi-cnl-psr total:224 pass:198 dwarn:0 dfail:0 fail:1 skip:24 fi-glk-j4005 total:285 pass:226 dwarn:30 dfail:0 fail:0 skip:29 time:489s
94f5d9189e61055e246c31106b3810dc17ddee9c drm-tip: 2018y-03m-23d-23h-41m-40s UTC integration manifest 545fe6ed4604 drm/i915: Add checks to primary planea7f9ce556ab2 drm/i915: Display WA 8274ca02e5f9bd0 drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg483020f92c69 drm/i915: Add NV12 support to intel_framebuffer_initd7af95f5e1d4 drm/i915: Add NV12 as supported format for sprite planee155048376b9 drm/i915: Add NV12 as supported format for primary plane17490b4ce656 drm/i915: Upscale scaler max scale for NV12ccc7a37f5e0a drm/i915: Update format_is_yuv() to include NV12d87f6cf26fea drm/i915: Set scaler mode for NV122f6264f9349f drm/i915/skl: split skl_compute_ddb functionb756f5e1b974 drm/i915/skl+: nv12 workaround disable WM level 1-77a53eb021631 drm/i915/skl+: make sure higher latency level has higher wm value 1995882fa722 drm/i915/skl+: pass skl_wm_level struct to wm compute func4c4d4f07274c drm/i915/skl+: NV12 related changes for WM4863044b11a5 drm/i915/skl+: support verification of DDB HW state for NV12 7ca6efaada2b drm/i915/skl+: add NV12 in skl_format_to_fourccde530aafc1d7 drm/i915/skl+: refactor WM calculation for NV120503b1db737a drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8487/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for Add NV12 support (rev4)
In reply to Vidya Srinivas== Series Details ==
== Series Details ==
Series: Add NV12 support (rev4)
URL : https://patchwork.freedesktop.org/series/39670/
State : failure
== Summary ==
---- Possible new issues:
Test kms_plane_scaling:
Subgroup pipe-a-scaler-with-pixel-format:
pass -> FAIL (shard-apl)
Subgroup pipe-a-scaler-with-rotation:
pass -> FAIL (shard-apl)
Subgroup pipe-b-scaler-with-pixel-format:
pass -> FAIL (shard-apl)
Subgroup pipe-b-scaler-with-rotation:
pass -> FAIL (shard-apl)---- Known issues:
Test kms_flip:
Subgroup 2x-dpms-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw) fdo#103060 +3
Subgroup 2x-flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887
Subgroup plain-flip-ts-check:
pass -> FAIL (shard-hsw) fdo#100368 +1
Test kms_rotation_crc:
Subgroup sprite-rotation-180:
fail -> PASS (shard-snb) fdo#103925
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-apl) fdo#99912fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-apl total:3484 pass:1816 dwarn:1 dfail:0 fail:11 skip:1655 time:13037s shard-hsw total:3484 pass:1772 dwarn:1 dfail:0 fail:3 skip:1707 time:11720s shard-snb total:3484 pass:1363 dwarn:1 dfail:0 fail:3 skip:2117 time:6999s
Blacklisted hosts:
shard-kbl total:3484 pass:1924 dwarn:13 dfail:0 fail:16 skip:1531 time:9936s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8487/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx