Patch "iio: imu: st_lsm6dsx: introduce conf_lock mutex" has been added to the 4.15-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
iio: imu: st_lsm6dsx: introduce conf_lock mutex
to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iio-imu-st_lsm6dsx-introduce-conf_lock-mutex.patch
and it can be found in the queue-4.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
335eaedce461c9092e133ce0c6247f5a0b0baf69Mon Sep 17 00:00:00 2001
From: Lorenzo Bianconi <[email protected]>
Date: Mon, 1 Jan 2018 19:54:43 +0100
Subject: iio: imu: st_lsm6dsx: introduce conf_lock mutex
From: Lorenzo Bianconi <[email protected]>
commit 335eaedce461c9092e133ce0c6247f5a0b0baf69 upstream.
Add conf_lock mutex to prevent concurrent FIFO configuration update
--- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 2 ++ drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 21 +++++++++++++-------- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 ++++++ 3 files changed, 21 insertions(+), 8 deletions(-)
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +2 -0
@@ -130,6 +130,7 @@ struct st_lsm6dsx_sensor {* @irq: Device interrupt line (I2C or SPI). * @lock: Mutex to protect read and write operations. * @fifo_lock: Mutex to prevent concurrent access to the hw FIFO. +* @conf_lock: Mutex to prevent concurrent FIFO configuration update. * @fifo_mode: FIFO operating mode supported by the device. * @enable_mask: Enabled sensor bitmask. * @sip: Total number of samples (acc/gyro) in a given pattern.
@@ -144,6 +145,7 @@ struct st_lsm6dsx_hw {struct mutex lock;struct mutex fifo_lock; +struct mutex conf_lock;enum st_lsm6dsx_fifo_mode fifo_mode;u8 enable_mask;
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c +13 -8
@@ -325,38 +325,40 @@ static int st_lsm6dsx_update_fifo(structstruct st_lsm6dsx_hw *hw = sensor->hw;int err; +mutex_lock (&hw->conf_lock); +if (hw->fifo_mode !=ST_LSM6DSX_FIFO_BYPASS ) { err =st_lsm6dsx_flush_fifo (hw);if (err <0 ) -return err; + goto out; }if (enable) { err =st_lsm6dsx_sensor_enable (sensor);if (err <0 ) -return err; + goto out; }else { err =st_lsm6dsx_sensor_disable (sensor);if (err <0 ) -return err; + goto out; } err =st_lsm6dsx_set_fifo_odr (sensor, enable);if (err <0 ) -return err; + goto out; err =st_lsm6dsx_update_decimators (hw);if (err <0 ) -return err; + goto out; err =st_lsm6dsx_update_watermark (sensor, sensor->watermark);if (err <0 ) -return err; + goto out;if (hw->enable_mask) { err =st_lsm6dsx_set_fifo_mode (hw,ST_LSM6DSX_FIFO_CONT );if (err <0 ) -return err; + goto out;/* * store enable buffer timestamp as reference to compute
@@ -365,7 +367,10 @@ static int st_lsm6dsx_update_fifo(struct sensor->ts =iio_get_time_ns (iio_dev); } -return 0 ; +out: +mutex_unlock (&hw->conf_lock); + +return err; }static irqreturn_t st_lsm6dsx_handler_irq (int irq,void *private)
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +6 -0
@@ -528,7 +528,12 @@ static int st_lsm6dsx_set_watermark(struif (val <1 || val > hw->settings->max_fifo_size)return -EINVAL ; +mutex_lock (&hw->conf_lock); + err =st_lsm6dsx_update_watermark (sensor, val); + +mutex_unlock (&hw->conf_lock); +if (err <0 )return err;
@@ -739,6 +744,7 @@ int st_lsm6dsx_probe(struct device *dev,mutex_init (&hw->lock);mutex_init (&hw->fifo_lock); +mutex_init (&hw->conf_lock); hw->dev = dev; hw->irq = irq;
Patches currently in stable-queue which might be from [email protected] are
queue-4.15/iio-imu-st_lsm6dsx-fix-endianness-in-st_lsm6dsx_read_oneshot.patch queue-4.15/iio-imu-st_lsm6dsx-introduce-conf_lock-mutex.patch