Skip to contentSkip to conversation

warp7: configs: enable CONFIG_CMD_FS_GENERIC

PATCH New Pierre-Jean TEXIER 2 participants 3 messages Mar 27, 2018 – Mar 28, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 warp7: configs: enable CONFIG_CMD_FS_GENERIC

This enable generic file system commands (load, ls).

---
 configs/warp7_defconfig        | 1 +
 configs/warp7_secure_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/warp7_defconfig +1 -0
index 29c4512..3856918 100644
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DFU_MMC=y
 CONFIG_USB=y
configs/warp7_secure_defconfig +1 -0
index 7310855..e894578 100644
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
 CONFIG_DFU_MMC=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 warp7: configs: enable CONFIG_CMD_FS_GENERIC

Hi Pierre-Jean,

Quoted 13 lines · Pierre-Jean TEXIER

This enable generic file system commands (load, ls).

---
 configs/warp7_defconfig        | 1 +
 configs/warp7_secure_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/warp7_defconfig +0 -0
index 29c4512..3856918 100644

configs/warp7_defconfig CONFIG_CMD_EXT2=y · line 29

Quoted 4 lines
configs/warp7_defconfig +1 -0
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y

It is OK to make this change, but please also change include/configs/warp.h so that is uses 'load' instead of 'fatload'.

Also, please run ./scripts/get_maintainer.pl so that you do not miss to Cc the board maintainer and also Stefano Babic.

Thanks

#2 lore raw

PATCH 1/1 warp7: configs: enable CONFIG_CMD_FS_GENERIC

Hi Fabio

Le 28/03/2018 à 03:02, Fabio Estevam a écrit :

Quoted 12 lines

Hi Pierre-Jean,

Quoted 8 lines · Pierre-Jean TEXIER

This enable generic file system commands (load, ls).

---
  configs/warp7_defconfig        | 1 +
  configs/warp7_secure_defconfig | 1 +
  2 files changed, 2 insertions(+)
Quoted 10 lines

configs/warp7_defconfig CONFIG_CMD_EXT2=y · line 29

Quoted 9 lines
configs/warp7_defconfig +1 -0
index 29c4512..3856918 100644
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
  CONFIG_CMD_EXT4=y
  CONFIG_CMD_EXT4_WRITE=y
  CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y

It is OK to make this change, but please also change

Ok thanks !

Quoted 1 line

include/configs/warp.h so that is uses 'load' instead of 'fatload'.

No problem, I will submit a patch for this part.

Quoted 3 lines

Also, please run ./scripts/get_maintainer.pl so that you do not miss to Cc the board maintainer and also Stefano Babic.

Indeed, sorry for that, this is an oversight.

Quoted 2 lines

Thanks

Thanks

---
Pierre-Jean