Skip to contentSkip to conversation

drm/msm: Remove unused variables

PATCH In review Rajesh Yadav 2 participants 2 messages Mar 28, 2018 – Apr 4, 2018 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 drm/msm: Remove unused variables

Fix compilation errors due to unused variables.

---
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c            | 2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c             | 1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c           | 1 -
 4 files changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +1 -1
index bf46cf1..51cffc4 100644
@@ -2587,7 +2587,7 @@ static void dpu_crtc_disable(struct drm_crtc *crtc)
 	struct dpu_crtc_irq_info *node = NULL;
 	struct drm_event event;
 	u32 power_on;
-	int ret, i;
+	int ret;
 
 	if (!crtc || !crtc->dev || !crtc->dev->dev_private || !crtc->state) {
 		DPU_ERROR("invalid crtc\n");
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +0 -1
index 2bc5894..3b1212b 100644
@@ -264,7 +264,6 @@ static void dpu_encoder_phys_wb_setup_fb(struct dpu_encoder_phys *phys_enc,
 	const struct msm_format *format;
 	int ret;
 	struct msm_gem_address_space *aspace;
-	u32 fb_mode;
 
 	if (!phys_enc || !phys_enc->dpu_kms || !phys_enc->dpu_kms->catalog ||
 			!phys_enc->connector) {
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +0 -1
index 7186c64..8ef75f5 100644
@@ -426,7 +426,6 @@ static void dpu_kms_commit(struct msm_kms *kms, struct drm_atomic_state *state)
 {
 	struct drm_crtc *crtc;
 	struct drm_crtc_state *crtc_state;
-	struct dpu_crtc_state *cstate;
 	int i;
 
 	for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +0 -1
index c657e6b..b11a918 100644
@@ -2742,7 +2742,6 @@ static void dpu_plane_destroy_state(struct drm_plane *plane,
 	struct dpu_plane *pdpu;
 	struct dpu_plane_state *pstate;
 	struct dpu_plane_state *old_state;
-	struct drm_property *drm_prop;
 
 	if (!plane) {
 		DPU_ERROR("invalid plane\n");
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

A message that is not in the archive (sent off-list or not yet received): 1522217866-2138-1-git-send-email-ryadav-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 3 lines · Rajesh Yadav

Fix compilation errors due to unused variables.

Quoted 60 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c            | 2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c             | 1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c           | 1 -
 4 files changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +1 -1
index bf46cf1..51cffc4 100644
@@ -2587,7 +2587,7 @@ static void dpu_crtc_disable(struct drm_crtc *crtc)
 	struct dpu_crtc_irq_info *node = NULL;
 	struct drm_event event;
 	u32 power_on;
-	int ret, i;
+	int ret;
 
 	if (!crtc || !crtc->dev || !crtc->dev->dev_private || !crtc->state) {
 		DPU_ERROR("invalid crtc\n");
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +0 -1
index 2bc5894..3b1212b 100644
@@ -264,7 +264,6 @@ static void dpu_encoder_phys_wb_setup_fb(struct dpu_encoder_phys *phys_enc,
 	const struct msm_format *format;
 	int ret;
 	struct msm_gem_address_space *aspace;
-	u32 fb_mode;
 
 	if (!phys_enc || !phys_enc->dpu_kms || !phys_enc->dpu_kms->catalog ||
 			!phys_enc->connector) {
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +0 -1
index 7186c64..8ef75f5 100644
@@ -426,7 +426,6 @@ static void dpu_kms_commit(struct msm_kms *kms, struct drm_atomic_state *state)
 {
 	struct drm_crtc *crtc;
 	struct drm_crtc_state *crtc_state;
-	struct dpu_crtc_state *cstate;
 	int i;
 
 	for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +0 -1
index c657e6b..b11a918 100644
@@ -2742,7 +2742,6 @@ static void dpu_plane_destroy_state(struct drm_plane *plane,
 	struct dpu_plane *pdpu;
 	struct dpu_plane_state *pstate;
 	struct dpu_plane_state *old_state;
-	struct drm_property *drm_prop;
 
 	if (!plane) {
 		DPU_ERROR("invalid plane\n");
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno