Skip to contentSkip to conversation

Patch "net: dsa: Fix dsa_is_user_port() test inversion" has been added to the 4.15-stable tree

PATCH [email protected] 1 participant 1 message Mar 28, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: dsa: Fix dsa_is_user_port() test inversion

to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-dsa-fix-dsa_is_user_port-test-inversion.patch
and it can be found in the queue-4.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Wed Mar 28 18:37:51 CEST 2018

From: Florian Fainelli <[email protected]>
Date: Mon, 12 Mar 2018 16:00:40 -0700
Subject: net: dsa: Fix dsa_is_user_port() test inversion

From: Florian Fainelli <[email protected]>

[ Upstream commit 5a9f8df68ee6927f21dd3f2c75c16feb8b53a9e8 ]

During the conversion to dsa_is_user_port(), a condition ended up being reversed, which would prevent the creation of any user port when using the legacy binding and/or platform data, fix that.

Fixes 4a5b85ffe2a0 ("net: dsa: use dsa_is_user_port everywhere")
---
 net/dsa/legacy.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/dsa/legacy.c +1 -1
@@ -194,7 +194,7 @@ static int dsa_switch_setup_one(struct d
 		ds->ports[i].dn = cd->port_dn[i];
 		ds->ports[i].cpu_dp = dst->cpu_dp;
 
-		if (dsa_is_user_port(ds, i))
+		if (!dsa_is_user_port(ds, i))
 			continue;
 
 		ret = dsa_slave_create(&ds->ports[i]);

Patches currently in stable-queue which might be from [email protected] are

queue-4.15/net-dsa-fix-dsa_is_user_port-test-inversion.patch queue-4.15/net-systemport-rewrite-__bcm_sysport_tx_reclaim.patch queue-4.15/sysfs-symlink-export-sysfs_create_link_nowarn.patch queue-4.15/net-fec-fix-unbalanced-pm-runtime-calls.patch queue-4.15/net-phy-relax-error-checking-when-creating-sysfs-link-netdev-phydev.patch