Skip to contentSkip to conversation

wireshark: update to 2.4.6 and add upstream check

PATCH Superseded Armin Kuster 3 participants 6 messages Apr 4, 2018 – Apr 6, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wireshark: update to 2.4.6 and add upstream check

Security fixes:

The following vulnerabilities have been fixed:
* [1]wnpa-sec-2018-15
The MP4 dissector could crash. ([2]Bug 13777)
* [3]wnpa-sec-2018-16
The ADB dissector could crash. ([4]Bug 14460)
* [5]wnpa-sec-2018-17
The IEEE 802.15.4 dissector could crash. ([6]Bug 14468)
* [7]wnpa-sec-2018-18
The NBAP dissector could crash. ([8]Bug 14471)
* [9]wnpa-sec-2018-19
The VLAN dissector could crash. ([10]Bug 14469)
* [11]wnpa-sec-2018-20
The LWAPP dissector could crash. ([12]Bug 14467)
* [13]wnpa-sec-2018-21
The TCP dissector could crash. ([14]Bug 14472)
* [15]wnpa-sec-2018-22
The CQL dissector could to into an infinite loop. ([16]Bug 14530)
* [17]wnpa-sec-2018-23
The Kerberos dissector could crash. ([18]Bug 14576)
* [19]wnpa-sec-2018-24
Multiple dissectors and other modules could leak memory. The TN3270 ([20]Bug 14480), ISUP ([21]Bug 14481), LAPD ([22]Bug 14482), SMB2 ([23]Bug 14483), GIOP ([24]Bug 14484), ASN.1 ([25]Bug 14485), MIME multipart ([26]Bug 14486), H.223 ([27]Bug 14487), and PCP ([28]Bug 14488) dissectors were susceptible along with Wireshark and TShark

---
 .../wireshark/{wireshark_2.4.5.bb => wireshark_2.4.6.bb}           | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
 rename meta-networking/recipes-support/wireshark/{wireshark_2.4.5.bb => wireshark_2.4.6.bb} (92%)
meta-networking/recipes-support/wireshark/wireshark_2.4.6.bb renamed from meta-networking/recipes-support/wireshark/wireshark_2.4.5.bb +5 -2
similarity index 92%
rename from meta-networking/recipes-support/wireshark/wireshark_2.4.5.bb
rename to meta-networking/recipes-support/wireshark/wireshark_2.4.6.bb
index e330b99..9a7978f 100644
@@ -9,8 +9,11 @@ DEPENDS = "pcre expat glib-2.0 glib-2.0-native libgcrypt libgpg-error"
 SRC_URI = "https://1.as.dl.wireshark.org/src/${BP}.tar.xz"
 SRC_URI += "file://libgcrypt.patch"
 
-SRC_URI[md5sum] = "2b6f1f37c72fa15a0a1863016a0abcc0"
-SRC_URI[sha256sum] = "b3b2ec29fba0f4a3a590438abe4054e56f19108d440fc2d61492db9d8ff16fd7"
+UPSTREAM_CHECK_URI = "https://1.as.dl.wireshark.org/src"
+UPSTREAM_CHECK_REGEX = "wireshark-(?P<pver>2\.4(\.\d+)+)\.tar\.xz"
+
+SRC_URI[md5sum] = "8cfb73e286dd6427ca4405e6e802d13e"
+SRC_URI[sha256sum] = "8e965fd282bc0c09e7c4eba5f08a555d0ccf40a7d1544b939e01b90bc893d5fe"
 
 PE = "1"
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 1 line · Armin Kuster

+UPSTREAM_CHECK_REGEX = "wireshark-(?P<pver>2\.4(\.\d+)+)\.tar\.xz"

Why restrict the version to only 2.4.x ?
(also including .xz at the end may not be a good idea if upstream decides to use a different compressor)

Alex

author
#2 lore raw
Quoted 5 lines · Alexander Kanavin
Quoted 1 line · Armin Kuster

+UPSTREAM_CHECK_REGEX = "wireshark-(?P<pver>2\.4(\.\d+)+)\.tar\.xz"

Why restrict the version to only 2.4.x ?

2.5.1 is beta.. I don't want to update to it.

Quoted 2 lines

(also including .xz at the end may not be a good idea if upstream decides to use a different compressor)

thanks input.

- armin

Quoted 2 lines

Alex

#3 lore raw
Quoted 9 lines · On 04/05/2018 03:23 AM, akuster808 wrote:
Quoted 5 lines · Alexander Kanavin
Quoted 1 line · Armin Kuster

+UPSTREAM_CHECK_REGEX = "wireshark-(?P<pver>2\.4(\.\d+)+)\.tar\.xz"

Why restrict the version to only 2.4.x ?

2.5.1 is beta.. I don't want to update to it.

It follows the odd/even versioning with odd being the development releases.

https://wiki.wireshark.org/Development/ReleaseNumbers

Perhaps you can use a regex similar to upstream-version-is-even so this is future-proof?

Quoted 9 lines
Quoted 3 lines

(also including .xz at the end may not be a good idea if upstream decides to use a different compressor)

thanks input.

- armin

Quoted 2 lines

Alex

#4 lore raw
Quoted 11 lines · Anuj Mittal
Quoted 4 lines
Quoted 3 lines
Quoted 1 line

+UPSTREAM_CHECK_REGEX = "wireshark-(?P<pver>2\.4(\.\d+)+)\.tar\.xz"

Why restrict the version to only 2.4.x ?

2.5.1 is beta.. I don't want to update to it.

It follows the odd/even versioning with odd being the development releases.

https://wiki.wireshark.org/Development/ReleaseNumbers

Perhaps you can use a regex similar to upstream-version-is-even so this is future-proof?

Yes, I think you can simply inherit upstream-version-is-even directly.

Alex

author
#5 lore raw
Quoted 9 lines · Alexander Kanavin
Quoted 8 lines · Anuj Mittal
Quoted 4 lines
Quoted 3 lines
Quoted 1 line

+UPSTREAM_CHECK_REGEX = "wireshark-(?P<pver>2\.4(\.\d+)+)\.tar\.xz"

Why restrict the version to only 2.4.x ?

2.5.1 is beta.. I don't want to update to it.

It follows the odd/even versioning with odd being the development releases.

Quoted 6 lines
Quoted 4 lines

https://wiki.wireshark.org/Development/ReleaseNumbers

Perhaps you can use a regex similar to upstream-version-is-even so this is future-proof?

Yes, I think you can simply inherit upstream-version-is-even directly.

Oh, cool. I will have to check it out.
Thanks.

- armin

Quoted 2 lines

Alex