Skip to contentSkip to conversation

sanity.bbclass: Improved error message

PATCH New Andre McCurdy 1 participant 1 message Apr 5, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sanity.bbclass: Improved error message

From: Juro Bystricky <[email protected]>

When a non-existing MACHINE is specified, sanity check issues the following message:

Please set a valid MACHINE in your local.conf or environment

However, MACHINE can also be set in multiconfig .conf file(s). Hence we may have several different MACHINE settings within one (multiconfig) build, so the present error message is fairly ambiguous.

This patch remedies this by explicitly naming the offending MACHINE and by amending the list of places where this erroneous MACHINE definition could have originated.

MACHINE=xyz is invalid. Please set a valid MACHINE in your local.conf, environment or other configuration file.

[YOCTO#10810]

(cherry picked from commit a7cb408dd784178197687a2129e936620bf6a0d3)
---
 meta/classes/sanity.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/sanity.bbclass +1 -1
index a11b581..68fd440 100644
@@ -816,7 +816,7 @@ def check_sanity_everybuild(status, d):
     machinevalid = True
     if d.getVar('MACHINE', True):
         if not check_conf_exists("conf/machine/${MACHINE}.conf", d):
-            status.addresult('Please set a valid MACHINE in your local.conf or environment\n')
+            status.addresult('MACHINE=%s is invalid. Please set a valid MACHINE in your local.conf, environment or other configuration file.\n' % (d.getVar('MACHINE', True)))
             machinevalid = False
         else:
             status.addresult(check_sanity_validmachine(d))
Signature · 1 line
1.9.1