Skip to contentSkip to conversation

ndctl: fix ndctl_persistence_domain declaration

PATCH Applied [email protected] 3 participants 3 messages Apr 6, 2018 libnvdimm: non-volatile memory device

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ndctl: fix ndctl_persistence_domain declaration

From: Łukasz Plewa <[email protected]>

the declaration of ndctl_persistence_domain should be above first use of this enum

---
 ndctl/libndctl.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
ndctl/libndctl.h +7 -7
index cf6a77f..684fcd4 100644
@@ -97,6 +97,13 @@ void ndctl_set_log_priority(struct ndctl_ctx *ctx, int priority);
 void ndctl_set_userdata(struct ndctl_ctx *ctx, void *userdata);
 void *ndctl_get_userdata(struct ndctl_ctx *ctx);
 
+enum ndctl_persistence_domain {
+	PERSISTENCE_NONE = 0,
+	PERSISTENCE_MEM_CTRL = 10,
+	PERSISTENCE_CPU_CACHE = 20,
+	PERSISTENCE_UNKNOWN = INT_MAX,
+};
+
 struct ndctl_bus;
 struct ndctl_bus *ndctl_bus_get_first(struct ndctl_ctx *ctx);
 struct ndctl_bus *ndctl_bus_get_next(struct ndctl_bus *bus);
@@ -309,13 +316,6 @@ struct badblock {
 	unsigned int len;
 };
 
-enum ndctl_persistence_domain {
-	PERSISTENCE_NONE = 0,
-	PERSISTENCE_MEM_CTRL = 10,
-	PERSISTENCE_CPU_CACHE = 20,
-	PERSISTENCE_UNKNOWN = INT_MAX,
-};
-
 struct ndctl_region;
 struct ndctl_region *ndctl_region_get_first(struct ndctl_bus *bus);
 struct ndctl_region *ndctl_region_get_next(struct ndctl_region *region);
Signature · 6 lines
2.7.4

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Fri, Apr 6, 2018 at 6:28 AM, <[email protected]> wrote:

From: Łukasz Plewa <[email protected]>

the declaration of ndctl_persistence_domain should be above first use of this enum

---
 ndctl/libndctl.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Looks good,

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

maintainer Applied
#2 lore raw
Quoted 12 lines · Dan Williams
Quoted 10 lines · On Fri, Apr 6, 2018 at 6:28 AM, <[email protected]> wrote:

From: Łukasz Plewa <[email protected]>

the declaration of ndctl_persistence_domain should be above first use of this enum

---
 ndctl/libndctl.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
Quoted 3 lines

Looks good,

Thanks, applied.

Quoted 4 lines

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm