fix meson specific flags for introspection
cover fix meson specific flags for introspection
Fix meson specific introspection build error on x32 for atk and at-spi2-core. Thanks to Alex for poiniting to the right direction.
Maxin B. John (2):
at-spi2-core: upgrade to version 2.28.0
atk: upgrade to version 2.28.1
.../0001-build-Add-with-systemduserunitdir.patch | 52 ---------------------- meta/recipes-support/atk/at-spi2-core_2.26.2.bb | 29 ------------ meta/recipes-support/atk/at-spi2-core_2.28.0.bb | 39 ++++++++++++++++ meta/recipes-support/atk/atk_2.26.1.bb | 19 -------- meta/recipes-support/atk/atk_2.28.1.bb | 32 +++++++++++++ 5 files changed, 71 insertions(+), 100 deletions(-) delete mode 100644 meta/recipes-support/atk/at-spi2-core/0001-build-Add-with-systemduserunitdir.patch delete mode 100644 meta/recipes-support/atk/at-spi2-core_2.26.2.bb create mode 100644 meta/recipes-support/atk/at-spi2-core_2.28.0.bb delete mode 100644 meta/recipes-support/atk/atk_2.26.1.bb create mode 100644 meta/recipes-support/atk/atk_2.28.1.bb
Signature · 1 line
2.4.0
PATCH v2 1/2 at-spi2-core: upgrade to version 2.28.0
1. Convert to meson build
2. Remove the following patch made obsolete by moving to meson:
0001-build-Add-with-systemduserunitdir.patch
3. Provide meson flags for introspection and documentation
--- .../0001-build-Add-with-systemduserunitdir.patch | 52 ---------------------- meta/recipes-support/atk/at-spi2-core_2.26.2.bb | 29 ------------ meta/recipes-support/atk/at-spi2-core_2.28.0.bb | 39 ++++++++++++++++ 3 files changed, 39 insertions(+), 81 deletions(-) delete mode 100644 meta/recipes-support/atk/at-spi2-core/0001-build-Add-with-systemduserunitdir.patch delete mode 100644 meta/recipes-support/atk/at-spi2-core_2.26.2.bb create mode 100644 meta/recipes-support/atk/at-spi2-core_2.28.0.bb
meta/recipes-support/atk/at-spi2-core/0001-build-Add-with-systemduserunitdir.patch deleted +0 -52
@@ -1,52 +0,0 @@ -From fa376762b92404b9e3c430054b8c3341ca0fdd8b Mon Sep 17 00:00:00 2001 -From: Jussi Kukkonen <[email protected]> -Date: Tue, 21 Jun 2016 16:00:02 +0300 -Subject: [PATCH] build: Add --with-systemduserunitdir - -Default to "pkg-config --variable=systemduserunitdir systemd" but -allow overriding the value. - -Upstream-Status: Submitted [https://bugzilla.gnome.org/show_bug.cgi?id=767911] -Signed-off-by: Jussi Kukkonen <[email protected]> - ---- - bus/Makefile.am | 2 +- - configure.ac | 9 +++++++++ - 2 files changed, 10 insertions(+), 1 deletion(-) - -diff --git a/bus/Makefile.am b/bus/Makefile.am -index 688f82a..10cde62 100644 ---- a/bus/Makefile.am -+++ b/bus/Makefile.am -@@ -29,7 +29,7 @@ org.a11y.Bus.service: org.a11y.Bus.service.in - EXTRA_DIST += org.a11y.Bus.service.in - CLEANFILES += org.a11y.Bus.service - --systemd_userdir = $(prefix)/lib/systemd/user -+systemd_userdir = $(systemduserunitdir) - systemd_user_DATA = at-spi-dbus-bus.service - at-spi-dbus-bus.service: at-spi-dbus-bus.service.in Makefile - $(AM_V_GEN) $(SED) -e $(substitutions) $< > [email protected] && mv [email protected] $@ -diff --git a/configure.ac b/configure.ac -index 8c4fca2..1415cca 100644 ---- a/configure.ac -+++ b/configure.ac -@@ -146,6 +146,15 @@ else - fi - AC_SUBST(DBUS_SERVICES_DIR) - -+AC_ARG_WITH([systemduserunitdir], -+ AS_HELP_STRING([--with-systemduserunitdir=DIR], -+ [Directory for systemd service files]), -+ [], -+ [with_systemduserunitdir=$($PKG_CONFIG --variable=systemduserunitdir systemd)]) -+AC_SUBST([systemduserunitdir], [$with_systemduserunitdir]) -+ -+AC_PATH_PROG(GLIB_MKENUMS, glib-mkenums) -+ - GOBJECT_INTROSPECTION_CHECK([1.32.0]) - - AC_SUBST(LIBTOOL_EXPORT_OPTIONS) --- -2.14.1 -
meta/recipes-support/atk/at-spi2-core_2.26.2.bb deleted +0 -29
@@ -1,29 +0,0 @@ -SUMMARY = "Assistive Technology Service Provider Interface (dbus core)" -HOMEPAGE = "https://wiki.linuxfoundation.org/accessibility/d-bus" -LICENSE = "LGPLv2" -LIC_FILES_CHKSUM = "file://COPYING;md5=e9f288ba982d60518f375b5898283886" - -MAJ_VER = "${@oe.utils.trim_version("${PV}", 2)}" - -SRC_URI = "${GNOME_MIRROR}/${BPN}/${MAJ_VER}/${BPN}-${PV}.tar.xz \ - file://0001-build-Add-with-systemduserunitdir.patch \ - " - -SRC_URI[md5sum] = "4a042e4c801fdb793788b749eab21485" -SRC_URI[sha256sum] = "c80e0cdf5e3d713400315b63c7deffa561032a6c37289211d8afcfaa267c2615" - -DEPENDS = "dbus glib-2.0 virtual/libx11 libxi libxtst" - -inherit autotools gtk-doc gettext systemd pkgconfig distro_features_check upstream-version-is-even gobject-introspection -# depends on virtual/libx11 -REQUIRED_DISTRO_FEATURES = "x11" - -EXTRA_OECONF = " \ - --with-systemduserunitdir=${systemd_user_unitdir} \ - --with-dbus-daemondir=${bindir}" - -FILES_${PN} += "${datadir}/dbus-1/services/*.service \ - ${datadir}/dbus-1/accessibility-services/*.service \ - ${datadir}/defaults/at-spi2 \ - ${systemd_user_unitdir}/at-spi-dbus-bus.service \ - "
meta/recipes-support/atk/at-spi2-core_2.28.0.bb new file +39 -0
@@ -0,0 +1,39 @@ +SUMMARY = "Assistive Technology Service Provider Interface (dbus core)" +HOMEPAGE = "https://wiki.linuxfoundation.org/accessibility/d-bus" +LICENSE = "LGPLv2" +LIC_FILES_CHKSUM = "file://COPYING;md5=e9f288ba982d60518f375b5898283886" + +MAJ_VER = "${@oe.utils.trim_version("${PV}", 2)}" + +SRC_URI = "${GNOME_MIRROR}/${BPN}/${MAJ_VER}/${BPN}-${PV}.tar.xz \ + " + +SRC_URI[md5sum] = "9c42f79636ed1c0e908b7483d789b32e" +SRC_URI[sha256sum] = "42a2487ab11ce43c288e73b2668ef8b1ab40a0e2b4f94e80fca04ad27b6f1c87" + +DEPENDS = "dbus glib-2.0 virtual/libx11 libxi libxtst" + +inherit meson gtk-doc gettext systemd pkgconfig distro_features_check upstream-version-is-even gobject-introspection +# depends on virtual/libx11 +REQUIRED_DISTRO_FEATURES = "x11" + +EXTRA_OEMESON = " -Dsystemd_user_dir=${systemd_user_unitdir} \ + -Ddbus_daemon=${bindir}" + +GTKDOC_ENABLE_FLAG = "-Denable_docs=true" +GTKDOC_DISABLE_FLAG = "-Denable_docs=false" + +GI_ENABLE_FLAG = "-Denable-introspection=yes" +GI_DISABLE_FLAG = "-Denable-introspection=no" + +EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \ + '${GI_DISABLE_FLAG}', d)} " + +EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \ + '${GTKDOC_DISABLE_FLAG}', d)} " + +FILES_${PN} += "${datadir}/dbus-1/services/*.service \ + ${datadir}/dbus-1/accessibility-services/*.service \ + ${datadir}/defaults/at-spi2 \ + ${systemd_user_unitdir}/at-spi-dbus-bus.service \ + "
Signature · 1 line
2.4.0
Re: [PATCH v2 1/2] at-spi2-core: upgrade to version 2.28.0
meta/recipes-support/atk/at-spi2-core_2.28.0.bb line 34
Quoted 12 lines · Maxin B. John
meta/recipes-support/atk/at-spi2-core_2.28.0.bb new file +12
-0+GTKDOC_ENABLE_FLAG = "-Denable_docs=true" +GTKDOC_DISABLE_FLAG = "-Denable_docs=false" + +GI_ENABLE_FLAG = "-Denable-introspection=yes" +GI_DISABLE_FLAG = "-Denable-introspection=no" + +EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \ + '${GI_DISABLE_FLAG}', d)} " + +EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \ + '${GTKDOC_DISABLE_FLAG}', d)} " +
At some point (once we have enough recipes), we can move EXTRA_OEMESON lines to g-i and gtkdoc classes. Hopefully the upstreams start converging on the flag names as well.
Alex
PATCH v2 2/2 atk: upgrade to version 2.28.1
In reply to Maxin B. Johnconvert to meson build and provide flags for introspection and documentation.
--- meta/recipes-support/atk/atk_2.26.1.bb | 19 ------------------- meta/recipes-support/atk/atk_2.28.1.bb | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 19 deletions(-) delete mode 100644 meta/recipes-support/atk/atk_2.26.1.bb create mode 100644 meta/recipes-support/atk/atk_2.28.1.bb
meta/recipes-support/atk/atk_2.26.1.bb deleted +0 -19
@@ -1,19 +0,0 @@ -SUMMARY = "Accessibility toolkit for GNOME" -HOMEPAGE = "http://live.gnome.org/GAP/" -BUGTRACKER = "https://bugzilla.gnome.org/" -SECTION = "x11/libs" - -LICENSE = "GPLv2+ & LGPLv2+" -LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \ - file://atk/atkutil.c;endline=18;md5=6fd31cd2fdc9b30f619ca8d819bc12d3 \ - file://atk/atk.h;endline=18;md5=fcd7710187e0eae485e356c30d1b0c3b" - -DEPENDS = "glib-2.0" - -inherit gnomebase gtk-doc gettext upstream-version-is-even gobject-introspection - -SRC_URI[archive.md5sum] = "7cddcc313b9a3efd19b2ddf079ba68f5" -SRC_URI[archive.sha256sum] = "ef00ff6b83851dddc8db38b4d9faeffb99572ba150b0664ee02e46f015ea97cb" - -BBCLASSEXTEND = "native" -
meta/recipes-support/atk/atk_2.28.1.bb new file +32 -0
@@ -0,0 +1,32 @@ +SUMMARY = "Accessibility toolkit for GNOME" +HOMEPAGE = "http://live.gnome.org/GAP/" +BUGTRACKER = "https://bugzilla.gnome.org/" +SECTION = "x11/libs" + +LICENSE = "GPLv2+ & LGPLv2+" +LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \ + file://atk/atkutil.c;endline=18;md5=6fd31cd2fdc9b30f619ca8d819bc12d3 \ + file://atk/atk.h;endline=18;md5=fcd7710187e0eae485e356c30d1b0c3b" + +DEPENDS = "glib-2.0" + +GNOMEBASEBUILDCLASS = "meson" +inherit gnomebase gtk-doc gettext upstream-version-is-even gobject-introspection + +GTKDOC_ENABLE_FLAG = "-Denable_docs=true" +GTKDOC_DISABLE_FLAG = "-Denable_docs=false" + +GI_ENABLE_FLAG = "-Ddisable_introspection=false" +GI_DISABLE_FLAG = "-Ddisable_introspection=true" + +EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \ + '${GI_DISABLE_FLAG}', d)} " + +EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \ + '${GTKDOC_DISABLE_FLAG}', d)} " + +SRC_URI[archive.md5sum] = "dfb5e7474220afa3f4ca7e45af9f3a11" +SRC_URI[archive.sha256sum] = "cd3a1ea6ecc268a2497f0cd018e970860de24a6d42086919d6bf6c8e8d53f4fc" + +BBCLASSEXTEND = "native" +
Signature · 1 line
2.4.0