Patch "mlxsw: spectrum: Avoid possible NULL pointer dereference" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
mlxsw: spectrum: Avoid possible NULL pointer dereference
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mlxsw-spectrum-avoid-possible-null-pointer-dereference.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon Apr 9 17:09:24 CEST 2018
From: Ido Schimmel <[email protected]>
Date: Thu, 18 May 2017 13:03:52 +0200
Subject: mlxsw: spectrum: Avoid possible NULL pointer dereference
From: Ido Schimmel <[email protected]>
[ Upstream commit c0e01eac7ada785fdeaea1ae5476ec1cf3b00374 ]
In case we got an FDB notification for a port that doesn't exist we execute an FDB entry delete to prevent it from re-appearing the next time we poll for notifications.
If the operation failed we would trigger a NULL pointer dereference as 'mlxsw_sp_port' is NULL.
Fix it by reporting the error using the underlying bus device instead.
--- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +2 -4
@@ -1448,8 +1448,7 @@ do_fdb_op: err =mlxsw_sp_port_fdb_uc_op (mlxsw_sp, local_port, mac, fid, adding, true);if (err) { -if (net_ratelimit ()) -netdev_err (mlxsw_sp_port->dev,"Failed to set FDB entry\n" ); +dev_err_ratelimited (mlxsw_sp->bus_info->dev,"Failed to set FDB entry\n" );return ; }
@@ -1509,8 +1508,7 @@ do_fdb_op: err =mlxsw_sp_port_fdb_uc_lag_op (mlxsw_sp, lag_id, mac, fid, lag_vid, adding, true);if (err) { -if (net_ratelimit ()) -netdev_err (mlxsw_sp_port->dev,"Failed to set FDB entry\n" ); +dev_err_ratelimited (mlxsw_sp->bus_info->dev,"Failed to set FDB entry\n" );return ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/mlxsw-spectrum-avoid-possible-null-pointer-dereference.patch