Patch "lan78xx: Crash in lan78xx_writ_reg (Workqueue: events lan78xx_deferred_multicast_write)" has been added to the 4.14-stable tree
This is a note to let you know that I've just added the patch titled
lan78xx: Crash in lan78xx_writ_reg (Workqueue: events lan78xx_deferred_multicast_write)
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
lan78xx-crash-in-lan78xx_writ_reg-workqueue-events-lan78xx_deferred_multicast_write.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Apr 10 23:20:08 CEST 2018
From: Raghuram Chary J <[email protected]>
Date: Tue, 27 Mar 2018 14:51:16 +0530
Subject: lan78xx: Crash in lan78xx_writ_reg (Workqueue: events lan78xx_deferred_multicast_write)
From: Raghuram Chary J <[email protected]>
[ Upstream commit 2d2d99ec13f62d5d2cecb6169dfdb6bbe05356d0 ]
Description:
Crash was reported with syzkaller pointing to lan78xx_write_reg routine.
Root-cause:
Proper cleanup of workqueues and init/setup routines was not happening in failure conditions.
Fix:
Handled the error conditions by cleaning up the queues and init/setup routines.
--- drivers/net/usb/lan78xx.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-)
drivers/net/usb/lan78xx.c +21 -2
@@ -2863,8 +2863,7 @@ static int lan78xx_bind(struct lan78xx_nif (ret <0 ) {netdev_warn (dev->net,"lan78xx_setup_irq_domain() failed : %d" , ret); -kfree (pdata); -return ret; + goto out1; } dev->net->hard_header_len +=TX_OVERHEAD ;
@@ -2872,14 +2871,32 @@ static int lan78xx_bind(struct lan78xx_n/* Init all registers */ ret =lan78xx_reset (dev); +if (ret) { +netdev_warn (dev->net,"Registers INIT FAILED...." ); + goto out2; + } ret =lan78xx_mdio_init (dev); +if (ret) { +netdev_warn (dev->net,"MDIO INIT FAILED....." ); + goto out2; + } dev->net->flags |=IFF_MULTICAST ; pdata->wol =WAKE_MAGIC ;return ret; + +out2: +lan78xx_remove_irq_domain (dev); + +out1: +netdev_warn (dev->net,"Bind routine FAILED" ); +cancel_work_sync (&pdata->set_multicast); +cancel_work_sync (&pdata->set_vlan); +kfree (pdata); +return ret; }static void lan78xx_unbind (struct lan78xx_net *dev,struct usb_interface *intf)
@@ -2891,6 +2908,8 @@ static void lan78xx_unbind(struct lan78xlan78xx_remove_mdio (dev);if (pdata) { +cancel_work_sync (&pdata->set_multicast); +cancel_work_sync (&pdata->set_vlan);netif_dbg (dev, ifdown, dev->net,"free pdata" );kfree (pdata); pdata =NULL ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/lan78xx-crash-in-lan78xx_writ_reg-workqueue-events-lan78xx_deferred_multicast_write.patch