Patch "strparser: Fix sign of err codes" has been added to the 4.15-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
strparser: Fix sign of err codes
to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
strparser-fix-sign-of-err-codes.patch
and it can be found in the queue-4.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Apr 10 23:19:36 CEST 2018
From: Dave Watson <[email protected]>
Date: Mon, 26 Mar 2018 12:31:21 -0700
Subject: strparser: Fix sign of err codes
From: Dave Watson <[email protected]>
[ Upstream commit cd00edc179863848abab5cc5683de5b7b5f70954 ]
strp_parser_err is called with a negative code everywhere, which then calls abort_parser with a negative code. strp_msg_timeout calls abort_parser directly with a positive code. Negate ETIMEDOUT to match signed-ness of other calls.
The default abort_parser callback, strp_abort_strp, sets sk->sk_err to err. Also negate the error here so sk_err always holds a positive value, as the rest of the net code expects. Currently a negative sk_err can result in endless loops, or user code that thinks it actually sent/received err bytes.
Found while testing net/tls_sw recv path.
--- net/strparser/strparser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/strparser/strparser.c +2 -2
@@ -60,7 +60,7 @@ static void strp_abort_strp(struct strpastruct sock *sk = strp->sk;/* Report an error on the lower socket */ - sk->sk_err = err; + sk->sk_err = -err; sk->sk_error_report (sk); } }
@@ -458,7 +458,7 @@ static void strp_msg_timeout(struct work/* Message assembly timed out */ STRP_STATS_INCR (strp->stats.msg_timeouts); strp->cb.lock (strp); - strp->cb.abort_parser (strp,ETIMEDOUT ); + strp->cb.abort_parser (strp, -ETIMEDOUT ); strp->cb.unlock (strp); }
Patches currently in stable-queue which might be from [email protected] are
queue-4.15/strparser-fix-sign-of-err-codes.patch