GMBUS changes
Subsystems (2)
cover GMBUS changes
I am not aware if there is a reason for restricting the Bytes per GMBUS WR/RD to 256 at present. But HW has 9Bits for Total Byte count for a single read or Write cycle. Means we can extend a cycle of RD/WR to 511Bytes.
At present nothing much as ROI, as most of the usecases are for less than 256Bytes. On GLK tested for 300Bytes on single normal read, found to be working fine.
First patch does it. But I have restricted the extension to BXT onwards, as I am not sure about the legacy platforms.
And second patch is enabling the burst read for all GMBUS read of more than 511Bytes, on supported platforms. Basically this Burst read is enabled in HW for HDCP2.2 compliance requirement. Instead of enabling the burst read only for HDCP on special API this patch enables it for all GMBUS read of >511Bytes, on capable platforms.
Ramalingam C (2):
drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
drm/i915/gmbus: Enable burst read
drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_i2c.c | 49 ++++++++++++++++++++++++++++++++++++---- 2 files changed, 46 insertions(+), 5 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC 1/2 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
From BXT onwards Bspec says HW supports Max Bytes per single RD/WR op is 511Bytes instead of previous 256Bytes used in SW.
This change allows the max bytes per op upto 511Bytes from BXT onwards.
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_i2c.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -3013,6 +3013,7 @@ enum i915_power_well_id {#define GMBUS_CYCLE_STOP (4<<25)#define GMBUS_BYTE_COUNT_SHIFT 16#define GMBUS_BYTE_COUNT_MAX 256U +#define BXT_GMBUS_BYTE_COUNT_MAX 511U#define GMBUS_SLAVE_INDEX_SHIFT 8#define GMBUS_SLAVE_ADDR_SHIFT 1#define GMBUS_SLAVE_READ (1<<0)
drivers/gpu/drm/i915/intel_i2c.c +8 -2
@@ -400,7 +400,10 @@ gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg,int ret; do { - len = min(rx_size, GMBUS_BYTE_COUNT_MAX); + if (INTEL_GEN(dev_priv) >= 9) + len = min(rx_size, BXT_GMBUS_BYTE_COUNT_MAX); + else + len = min(rx_size, GMBUS_BYTE_COUNT_MAX); ret = gmbus_xfer_read_chunk(dev_priv, msg->addr, buf, len, gmbus1_index);
@@ -462,7 +465,10 @@ gmbus_xfer_write(struct drm_i915_private *dev_priv, struct i2c_msg *msg,int ret; do { - len = min(tx_size, GMBUS_BYTE_COUNT_MAX); + if (INTEL_GEN(dev_priv) >= 9) + len = min(tx_size, BXT_GMBUS_BYTE_COUNT_MAX); + else + len = min(tx_size, GMBUS_BYTE_COUNT_MAX); ret = gmbus_xfer_write_chunk(dev_priv, msg->addr, buf, len, gmbus1_index);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: [RFC 1/2] drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
Quoted 2 lines · Ramalingam C
From BXT onwards Bspec says HW supports Max Bytes per single RD/WR op is 511Bytes instead of previous 256Bytes used in SW.
"BXT onwards" and "SKL onwards" are always slightly confusing, because it's not always clear if one includes the other. Since the code is written gen 9+, perhaps use that here and in the macro definition too?
Quoted 51 lines
This change allows the max bytes per op upto 511Bytes from BXT onwards.
Cc Jani Nikula <[email protected]>Cc Chris Wilson <[email protected]>Signed-off-by Ramalingam C <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_i2c.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -3013,6 +3013,7 @@ enum i915_power_well_id {#define GMBUS_CYCLE_STOP (4<<25)#define GMBUS_BYTE_COUNT_SHIFT 16#define GMBUS_BYTE_COUNT_MAX 256U +#define BXT_GMBUS_BYTE_COUNT_MAX 511U#define GMBUS_SLAVE_INDEX_SHIFT 8#define GMBUS_SLAVE_ADDR_SHIFT 1#define GMBUS_SLAVE_READ (1<<0)drivers/gpu/drm/i915/intel_i2c.c +8
-2@@ -400,7 +400,10 @@ gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg,int ret; do { - len = min(rx_size, GMBUS_BYTE_COUNT_MAX); + if (INTEL_GEN(dev_priv) >= 9) + len = min(rx_size, BXT_GMBUS_BYTE_COUNT_MAX); + else + len = min(rx_size, GMBUS_BYTE_COUNT_MAX); ret = gmbus_xfer_read_chunk(dev_priv, msg->addr, buf, len, gmbus1_index);@@ -462,7 +465,10 @@ gmbus_xfer_write(struct drm_i915_private *dev_priv, struct i2c_msg *msg,int ret; do { - len = min(tx_size, GMBUS_BYTE_COUNT_MAX); + if (INTEL_GEN(dev_priv) >= 9) + len = min(tx_size, BXT_GMBUS_BYTE_COUNT_MAX); + else + len = min(tx_size, GMBUS_BYTE_COUNT_MAX); ret = gmbus_xfer_write_chunk(dev_priv, msg->addr, buf, len, gmbus1_index);
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC 2/2 drm/i915/gmbus: Enable burst read
In reply to Ramalingam CSupport for Burst read in HW is added for HDCP2.2 compliance requirement.
This patch enables the burst read for all the gmbus read of more than 511Bytes, on capable platforms.
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_i2c.c | 39 +++++++++++++++++++++++++++++++++++---- 2 files changed, 36 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -2984,6 +2984,7 @@ enum i915_power_well_id {#define GMBUS_RATE_400KHZ (2<<8)/* reserved on Pineview */ #define GMBUS_RATE_1MHZ (3<<8)/* reserved on Pineview */ #define GMBUS_HOLD_EXT (1<<7)/* 300ns hold time, rsvd on Pineview */ +#define GMBUS_BYTE_CNT_OVERRIDE (1<<6)#define GMBUS_PIN_DISABLED 0#define GMBUS_PIN_SSC 1#define GMBUS_PIN_VGADDC 2
drivers/gpu/drm/i915/intel_i2c.c +35 -4
@@ -364,12 +364,24 @@ gmbus_wait_idle(struct drm_i915_private *dev_priv)static int gmbus_xfer_read_chunk (struct drm_i915_private *dev_priv,unsigned short addr,u8 *buf,unsigned int len, -u32 gmbus1_index) +u32 gmbus1_index,bool burst_read) { +unsigned int bytes_af_override, size; + +if (burst_read) { + bytes_af_override = len - (((len /256 ) -1 ) *256 ); + size = bytes_af_override; + +I915_WRITE_FW (GMBUS0 , (I915_READ_FW (GMBUS0 ) | +GMBUS_BYTE_CNT_OVERRIDE )); + }else { + size = len; + } +I915_WRITE_FW (GMBUS1 , gmbus1_index |GMBUS_CYCLE_WAIT | - (len <<GMBUS_BYTE_COUNT_SHIFT ) | + (size <<GMBUS_BYTE_COUNT_SHIFT ) | (addr <<GMBUS_SLAVE_ADDR_SHIFT ) |GMBUS_SLAVE_READ |GMBUS_SW_RDY );while (len) {
@@ -385,11 +397,23 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv, *buf++ = val &0xff ; val >>=8 ; }while (--len && ++loop <4 ); + +if (burst_read && len == (bytes_af_override -4 )) +I915_WRITE_FW (GMBUS0 , (I915_READ_FW (GMBUS0 ) & + ~GMBUS_BYTE_CNT_OVERRIDE )); }return 0 ; } +static bool gmbus_burst_read_supported (struct drm_i915_private *dev_priv) +{ +if (INTEL_GEN (dev_priv) >=10 ||IS_GEMINILAKE (dev_priv) || +IS_KABYLAKE (dev_priv)) +return true; +return false; +} +static int gmbus_xfer_read (struct drm_i915_private *dev_priv,struct i2c_msg *msg,u32 gmbus1_index)
@@ -398,15 +422,22 @@ gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg,unsigned int rx_size = msg->len;unsigned int len;int ret; +bool burst_read = false; + +if (rx_size >BXT_GMBUS_BYTE_COUNT_MAX ) + burst_read =gmbus_burst_read_supported (dev_priv); do { - if (INTEL_GEN(dev_priv) >= 9) + + if (burst_read) + len = rx_size; + else if (INTEL_GEN(dev_priv) >= 9) len = min(rx_size, BXT_GMBUS_BYTE_COUNT_MAX); else len = min(rx_size, GMBUS_BYTE_COUNT_MAX); ret = gmbus_xfer_read_chunk(dev_priv, msg->addr, - buf, len, gmbus1_index); + buf, len, gmbus1_index, burst_read); if (ret) return ret;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RFC v2 2/2 drm/i915/gmbus: Enable burst read
Support for Burst read in HW is added for HDCP2.2 compliance requirement.
This patch enables the burst read for all the gmbus read of more than 511Bytes, on capable platforms.
v2:
Extra line is removed.
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_i2c.c | 38 ++++++++++++++++++++++++++++++++++---- 2 files changed, 35 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -2984,6 +2984,7 @@ enum i915_power_well_id {#define GMBUS_RATE_400KHZ (2<<8)/* reserved on Pineview */ #define GMBUS_RATE_1MHZ (3<<8)/* reserved on Pineview */ #define GMBUS_HOLD_EXT (1<<7)/* 300ns hold time, rsvd on Pineview */ +#define GMBUS_BYTE_CNT_OVERRIDE (1<<6)#define GMBUS_PIN_DISABLED 0#define GMBUS_PIN_SSC 1#define GMBUS_PIN_VGADDC 2
drivers/gpu/drm/i915/intel_i2c.c +34 -4
@@ -364,12 +364,24 @@ gmbus_wait_idle(struct drm_i915_private *dev_priv)static int gmbus_xfer_read_chunk (struct drm_i915_private *dev_priv,unsigned short addr,u8 *buf,unsigned int len, -u32 gmbus1_index) +u32 gmbus1_index,bool burst_read) { +unsigned int bytes_af_override, size; + +if (burst_read) { + bytes_af_override = len - (((len /256 ) -1 ) *256 ); + size = bytes_af_override; + +I915_WRITE_FW (GMBUS0 , (I915_READ_FW (GMBUS0 ) | +GMBUS_BYTE_CNT_OVERRIDE )); + }else { + size = len; + } +I915_WRITE_FW (GMBUS1 , gmbus1_index |GMBUS_CYCLE_WAIT | - (len <<GMBUS_BYTE_COUNT_SHIFT ) | + (size <<GMBUS_BYTE_COUNT_SHIFT ) | (addr <<GMBUS_SLAVE_ADDR_SHIFT ) |GMBUS_SLAVE_READ |GMBUS_SW_RDY );while (len) {
@@ -385,11 +397,23 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv, *buf++ = val &0xff ; val >>=8 ; }while (--len && ++loop <4 ); + +if (burst_read && len == (bytes_af_override -4 )) +I915_WRITE_FW (GMBUS0 , (I915_READ_FW (GMBUS0 ) & + ~GMBUS_BYTE_CNT_OVERRIDE )); }return 0 ; } +static bool gmbus_burst_read_supported (struct drm_i915_private *dev_priv) +{ +if (INTEL_GEN (dev_priv) >=10 ||IS_GEMINILAKE (dev_priv) || +IS_KABYLAKE (dev_priv)) +return true; +return false; +} +static int gmbus_xfer_read (struct drm_i915_private *dev_priv,struct i2c_msg *msg,u32 gmbus1_index)
@@ -398,15 +422,21 @@ gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg,unsigned int rx_size = msg->len;unsigned int len;int ret; +bool burst_read = false; + +if (rx_size >BXT_GMBUS_BYTE_COUNT_MAX ) + burst_read =gmbus_burst_read_supported (dev_priv); do { - if (INTEL_GEN(dev_priv) >= 9) + if (burst_read) + len = rx_size; + else if (INTEL_GEN(dev_priv) >= 9) len = min(rx_size, BXT_GMBUS_BYTE_COUNT_MAX); else len = min(rx_size, GMBUS_BYTE_COUNT_MAX); ret = gmbus_xfer_read_chunk(dev_priv, msg->addr, - buf, len, gmbus1_index); + buf, len, gmbus1_index, burst_read); if (ret) return ret;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [RFC v2 2/2] drm/i915/gmbus: Enable burst read
Quoted 32 lines · Ramalingam C
Support for Burst read in HW is added for HDCP2.2 compliance requirement.
This patch enables the burst read for all the gmbus read of more than 511Bytes, on capable platforms.
v2:
Extra line is removed.Signed-off-by Ramalingam C <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_i2c.c | 38 ++++++++++++++++++++++++++++++++++---- 2 files changed, 35 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -2984,6 +2984,7 @@ enum i915_power_well_id {#define GMBUS_RATE_400KHZ (2<<8)/* reserved on Pineview */ #define GMBUS_RATE_1MHZ (3<<8)/* reserved on Pineview */ #define GMBUS_HOLD_EXT (1<<7)/* 300ns hold time, rsvd on Pineview */ +#define GMBUS_BYTE_CNT_OVERRIDE (1<<6)#define GMBUS_PIN_DISABLED 0#define GMBUS_PIN_SSC 1#define GMBUS_PIN_VGADDC 2drivers/gpu/drm/i915/intel_i2c.c +0
-0
drivers/gpu/drm/i915/intel_i2c.c gmbus_wait_idle(struct drm_i915_private *dev_priv) · line 372
Quoted 10 lines
drivers/gpu/drm/i915/intel_i2c.c +5
-1@@ -364,12 +364,24 @@ gmbus_wait_idle(struct drm_i915_private *dev_priv)static int gmbus_xfer_read_chunk (struct drm_i915_private *dev_priv,unsigned short addr,u8 *buf,unsigned int len, -u32 gmbus1_index) +u32 gmbus1_index,bool burst_read) { +unsigned int bytes_af_override, size; + +if (burst_read) { + bytes_af_override = len - (((len /256 ) -1 ) *256 );
Just realized that this could be simplified as (len % 256) + 256; Will update the next version.
--Ram
Quoted 54 lines
drivers/gpu/drm/i915/intel_i2c.c +28
-2+ size = bytes_af_override; + +I915_WRITE_FW (GMBUS0 , (I915_READ_FW (GMBUS0 ) | +GMBUS_BYTE_CNT_OVERRIDE )); + }else { + size = len; + } +I915_WRITE_FW (GMBUS1 , gmbus1_index |GMBUS_CYCLE_WAIT | - (len <<GMBUS_BYTE_COUNT_SHIFT ) | + (size <<GMBUS_BYTE_COUNT_SHIFT ) | (addr <<GMBUS_SLAVE_ADDR_SHIFT ) |GMBUS_SLAVE_READ |GMBUS_SW_RDY );while (len) {@@ -385,11 +397,23 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv, *buf++ = val &0xff ; val >>=8 ; }while (--len && ++loop <4 ); + +if (burst_read && len == (bytes_af_override -4 )) +I915_WRITE_FW (GMBUS0 , (I915_READ_FW (GMBUS0 ) & + ~GMBUS_BYTE_CNT_OVERRIDE )); }return 0 ; } +static bool gmbus_burst_read_supported (struct drm_i915_private *dev_priv) +{ +if (INTEL_GEN (dev_priv) >=10 ||IS_GEMINILAKE (dev_priv) || +IS_KABYLAKE (dev_priv)) +return true; +return false; +} +static int gmbus_xfer_read (struct drm_i915_private *dev_priv,struct i2c_msg *msg,u32 gmbus1_index)@@ -398,15 +422,21 @@ gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg,unsigned int rx_size = msg->len;unsigned int len;int ret; +bool burst_read = false; + +if (rx_size >BXT_GMBUS_BYTE_COUNT_MAX ) + burst_read =gmbus_burst_read_supported (dev_priv); do { - if (INTEL_GEN(dev_priv) >= 9) + if (burst_read) + len = rx_size; + else if (INTEL_GEN(dev_priv) >= 9)
drivers/gpu/drm/i915/intel_i2c.c gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg, · line 442
Quoted 10 lines
drivers/gpu/drm/i915/intel_i2c.c +1
-1len =min (rx_size,BXT_GMBUS_BYTE_COUNT_MAX ); else len =min (rx_size,GMBUS_BYTE_COUNT_MAX ); ret =gmbus_xfer_read_chunk (dev_priv, msg->addr, - buf, len, gmbus1_index); + buf, len, gmbus1_index, burst_read);if (ret)return ret;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: [RFC v2 2/2] drm/i915/gmbus: Enable burst read
In reply to Ramalingam CQuoted 32 lines · Ramalingam C
Support for Burst read in HW is added for HDCP2.2 compliance requirement.
This patch enables the burst read for all the gmbus read of more than 511Bytes, on capable platforms.
v2:
Extra line is removed.Signed-off-by Ramalingam C <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_i2c.c | 38 ++++++++++++++++++++++++++++++++++---- 2 files changed, 35 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -2984,6 +2984,7 @@ enum i915_power_well_id {#define GMBUS_RATE_400KHZ (2<<8)/* reserved on Pineview */ #define GMBUS_RATE_1MHZ (3<<8)/* reserved on Pineview */ #define GMBUS_HOLD_EXT (1<<7)/* 300ns hold time, rsvd on Pineview */ +#define GMBUS_BYTE_CNT_OVERRIDE (1<<6)#define GMBUS_PIN_DISABLED 0#define GMBUS_PIN_SSC 1#define GMBUS_PIN_VGADDC 2drivers/gpu/drm/i915/intel_i2c.c +0
-0
drivers/gpu/drm/i915/intel_i2c.c gmbus_wait_idle(struct drm_i915_private *dev_priv) · line 367
Quoted 5 lines
drivers/gpu/drm/i915/intel_i2c.c +1
-1@@ -364,12 +364,24 @@ gmbus_wait_idle(struct drm_i915_private *dev_priv)static int gmbus_xfer_read_chunk (struct drm_i915_private *dev_priv,unsigned short addr,u8 *buf,unsigned int len, -u32 gmbus1_index) +u32 gmbus1_index,bool burst_read)
I think you could throw out the burst_read parameter. See below.
Quoted 31 lines
drivers/gpu/drm/i915/intel_i2c.c +17
-1{ +unsigned int bytes_af_override, size; + +if (burst_read) { + bytes_af_override = len - (((len /256 ) -1 ) *256 ); + size = bytes_af_override; + +I915_WRITE_FW (GMBUS0 , (I915_READ_FW (GMBUS0 ) | +GMBUS_BYTE_CNT_OVERRIDE )); + }else { + size = len; + } +I915_WRITE_FW (GMBUS1 , gmbus1_index |GMBUS_CYCLE_WAIT | - (len <<GMBUS_BYTE_COUNT_SHIFT ) | + (size <<GMBUS_BYTE_COUNT_SHIFT ) | (addr <<GMBUS_SLAVE_ADDR_SHIFT ) |GMBUS_SLAVE_READ |GMBUS_SW_RDY );while (len) {@@ -385,11 +397,23 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv, *buf++ = val &0xff ; val >>=8 ; }while (--len && ++loop <4 ); + +if (burst_read && len == (bytes_af_override -4 )) +I915_WRITE_FW (GMBUS0 , (I915_READ_FW (GMBUS0 ) & + ~GMBUS_BYTE_CNT_OVERRIDE )); }
drivers/gpu/drm/i915/intel_i2c.c gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv, · line 415
Quoted 10 lines
drivers/gpu/drm/i915/intel_i2c.c +7
-0return 0 ; } +static bool gmbus_burst_read_supported (struct drm_i915_private *dev_priv) +{ +if (INTEL_GEN (dev_priv) >=10 ||IS_GEMINILAKE (dev_priv) || +IS_KABYLAKE (dev_priv)) +return true; +return false; +}
Name this HAS_GMBUS_BURST_READ() and put below HAS_GMBUS_IRQ() in i915_drv.h.
Quoted 11 lines
drivers/gpu/drm/i915/intel_i2c.c +4
-0+static int gmbus_xfer_read (struct drm_i915_private *dev_priv,struct i2c_msg *msg,u32 gmbus1_index)@@ -398,15 +422,21 @@ gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg,unsigned int rx_size = msg->len;unsigned int len;int ret; +bool burst_read = false; + +if (rx_size >BXT_GMBUS_BYTE_COUNT_MAX )
drivers/gpu/drm/i915/intel_i2c.c gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg, · line 436
Quoted 10 lines
drivers/gpu/drm/i915/intel_i2c.c +4
-1+ burst_read =gmbus_burst_read_supported (dev_priv); do { - if (INTEL_GEN(dev_priv) >= 9) + if (burst_read) + len = rx_size; + else if (INTEL_GEN(dev_priv) >= 9) len = min(rx_size, BXT_GMBUS_BYTE_COUNT_MAX); else len = min(rx_size, GMBUS_BYTE_COUNT_MAX);
If you abstracted the max transfer length in the previous patch, I think you could condence this into something like:
if (HAS_GMBUS_BURST_READ(dev_priv))
len = rx_size;
else
len = min(rx_size, gmbus_max_xfer_size(dev_priv))You could throw away the burst_read variable and parameter altogether, and have gmbus_xfer_read_chunk() decide internally if burst read is to be used by:
burst_read = len > gmbus_max_xfer_size(dev_priv);
(Potentially with a WARN_ON(burst_read && !HAS_GMBUS_BURST_READ()) if you want to be paranoid.)
BR,
Jani.
Quoted 6 lines
drivers/gpu/drm/i915/intel_i2c.c +1
-1ret =gmbus_xfer_read_chunk (dev_priv, msg->addr, - buf, len, gmbus1_index); + buf, len, gmbus1_index, burst_read);if (ret)return ret;
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for GMBUS changes
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: GMBUS changes
URL : https://patchwork.freedesktop.org/series/41632/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
bb2f104e57f8 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
b214f1744d40 drm/i915/gmbus: Enable burst read
-:22: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#22: FILE: drivers/gpu/drm/i915/i915_reg.h:2999:
+#define GMBUS_BYTE_CNT_OVERRIDE (1<<6)
^-:92: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #92: FILE: drivers/gpu/drm/i915/intel_i2c.c:431:
do {
+
total: 0 errors, 0 warnings, 2 checks, 80 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for GMBUS changes
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: GMBUS changes
URL : https://patchwork.freedesktop.org/series/41632/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4049 -> Patchwork_8681 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41632/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_8681 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: PASS -> FAIL (fdo#102575)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008) fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
== Participating hosts (35 -> 32) ==
Additional (1): fi-cnl-y3
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-glk-j4005 fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4049 -> Patchwork_8681
CI_DRM_4049: 3dbfa04d62f1f1214a03c3b2d30f987dccf50ab4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4426: d502f055ac4500cada758876a512ac4f14b34851 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8681: b214f1744d40bb235737d076af5049ea052855fe @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4426: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Linux commits ==
b214f1744d40 drm/i915/gmbus: Enable burst read bb2f104e57f8 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8681/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for GMBUS changes (rev2)
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: GMBUS changes (rev2)
URL : https://patchwork.freedesktop.org/series/41632/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f6b744bf9f24 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
47340a0ebaad drm/i915/gmbus: Enable burst read
-:25: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#25: FILE: drivers/gpu/drm/i915/i915_reg.h:2999:
+#define GMBUS_BYTE_CNT_OVERRIDE (1<<6)
^total: 0 errors, 0 warnings, 1 checks, 79 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for GMBUS changes (rev2)
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: GMBUS changes (rev2)
URL : https://patchwork.freedesktop.org/series/41632/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4049 -> Patchwork_8682 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41632/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_8682 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: PASS -> FAIL (fdo#102575)fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
== Participating hosts (35 -> 33) ==
Additional (1): fi-cnl-y3
Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4049 -> Patchwork_8682
CI_DRM_4049: 3dbfa04d62f1f1214a03c3b2d30f987dccf50ab4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4426: d502f055ac4500cada758876a512ac4f14b34851 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8682: 47340a0ebaad023c949b0c000d3430c5d48c3091 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4426: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Linux commits ==
47340a0ebaad drm/i915/gmbus: Enable burst read f6b744bf9f24 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8682/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for GMBUS changes (rev2)
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: GMBUS changes (rev2)
URL : https://patchwork.freedesktop.org/series/41632/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4049_full -> Patchwork_8682_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8682_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_8682_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41632/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8682_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-render:
shard-kbl: PASS -> SKIP== Known issues ==
Here are the changes found in Patchwork_8682_full that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
shard-hsw: FAIL (fdo#103060) -> PASS +1
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-hsw: FAIL (fdo#100368) -> PASS +1
igt@kms_sysfs_edid_timing:
shard-apl: WARN (fdo#100047) -> PASS fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
== Participating hosts (6 -> 4) ==
Missing (2): shard-glk shard-glkb
== Build changes ==
* Linux: CI_DRM_4049 -> Patchwork_8682
CI_DRM_4049: 3dbfa04d62f1f1214a03c3b2d30f987dccf50ab4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4426: d502f055ac4500cada758876a512ac4f14b34851 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8682: 47340a0ebaad023c949b0c000d3430c5d48c3091 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4426: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8682/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx