drm/i915/selftests: Handle a potential failure of intel_ring_begin
Subsystems (2)
PATCH 1/1 drm/i915/selftests: Handle a potential failure of intel_ring_begin
Silence smatch over:
drivers/gpu/drm/i915/selftests/intel_workarounds.c:58 read_nonprivs() error: 'cs' dereferencing possible ERR_PTR()
by handling a potential (but unlikely) failure of intel_ring_begin.
--- drivers/gpu/drm/i915/selftests/intel_workarounds.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/selftests/intel_workarounds.c +7 -0
@@ -54,6 +54,11 @@ srm++; cs =intel_ring_begin (rq,4 *RING_MAX_NONPRIV_SLOTS ); +if (IS_ERR (cs)) { + err =PTR_ERR (cs); + goto err_req; + } +for (i =0 ; i <RING_MAX_NONPRIV_SLOTS ; i++) { *cs++ = srm; *cs++ =i915_mmio_reg_offset (RING_FORCE_TO_NONPRIV (base, i));
@@ -75,6 +80,8 @@return result; +err_req: +i915_request_add (rq); err_pin:i915_vma_unpin (vma); err_obj:
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/selftests: Handle a potential failure of intel_ring_begin
== Series Details ==
== Series Details ==
Series: drm/i915/selftests: Handle a potential failure of intel_ring_begin
URL : https://patchwork.freedesktop.org/series/41773/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8700 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8700 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_8700, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41773/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8700:
=== IGT changes ===
==== Warnings ====
igt@prime_vgem@basic-fence-flip:
fi-cnl-y3: SKIP -> PASS== Known issues ==
Here are the changes found in Patchwork_8700 that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: FAIL (fdo#102575) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-ivb-3520m: DMESG-WARN (fdo#106084) -> PASS +1 fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
== Participating hosts (35 -> 33) ==
Missing (2): fi-ilk-m540 fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4058 -> Patchwork_8700
CI_DRM_4058: 241d827c86078c4709c00251d22ea8f7554e3e36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4432: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8700: 76ea91dce11329f20e7d1a4285a546b6825c7404 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4432: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Linux commits ==
76ea91dce113 drm/i915/selftests: Handle a potential failure of intel_ring_begin
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8700/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm/i915/selftests: Handle a potential failure of intel_ring_begin
In reply to Oscar Mateo== Series Details ==
== Series Details ==
Series: drm/i915/selftests: Handle a potential failure of intel_ring_begin
URL : https://patchwork.freedesktop.org/series/41773/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4058_full -> Patchwork_8700_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_8700_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_8700_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41773/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8700_full:
=== IGT changes ===
==== Possible regressions ====
igt@gem_wait@wait-vebox:
shard-apl: PASS -> FAIL
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-ctx-render:
shard-kbl: SKIP -> PASS== Known issues ==
Here are the changes found in Patchwork_8700_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_color@pipe-c-ctm-blue-to-red:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103558, fdo#103313) +13
igt@kms_flip@flip-vs-wf_vblank-interruptible:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +14
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@perf@polling:
shard-hsw: PASS -> FAIL (fdo#102252)
igt@pm_rpm@debugfs-read:
shard-kbl: PASS -> DMESG-WARN (fdo#103558, fdo#103313)
==== Possible fixes ====
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-hsw: FAIL (fdo#105189) -> PASS
igt@kms_flip@blocking-wf_vblank:
shard-hsw: FAIL (fdo#103928) -> PASS fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 4) ==
Missing (2): shard-glk shard-glkb
== Build changes ==
* Linux: CI_DRM_4058 -> Patchwork_8700
CI_DRM_4058: 241d827c86078c4709c00251d22ea8f7554e3e36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4432: 8b77704db49167f7ebfd1c470d9c129d3b862cb6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8700: 76ea91dce11329f20e7d1a4285a546b6825c7404 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4432: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8700/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.IGT: failure for drm/i915/selftests: Handle a potential failure of intel_ring_begin
Quoting Patchwork (2018-04-17 00:47:27)
Quoted 23 lines
== Series Details ==
Series: drm/i915/selftests: Handle a potential failure of
intel_ring_begin
URL : https://patchwork.freedesktop.org/series/41773/
State : failure== Summary ==
= CI Bug Log - changes from
CI_DRM_4058_full->Patchwork_8700_full=== Summary - FAILURE ==
Serious unknown changes coming with
Patchwork_8700_fullabsolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
Patchwork_8700_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.External URL: https://patchwork.freedesktop.org/api/1.0/series/41773/revisions/1/mbox/
== Possible new issues ==
Quoted 8 lines
Here are the unknown changes that may have been introduced in
Patchwork_8700_full:=== IGT changes ===
==== Possible regressions ==== igt@gem_wait@wait-vebox: shard-apl: PASS -> FAIL
Unconnected to this patch, so pushed. Thanks for the fix up, -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Oscar Mateo (2018-04-16 22:57:01)
Quoted 9 lines
Silence smatch over:
drivers/gpu/drm/i915/selftests/intel_workarounds.c:58read_nonprivs()error: 'cs' dereferencing possibleERR_PTR()by handling a potential (but unlikely) failure of
intel_ring_begin.Fixes f4ecfbfc32ed ("drm/i915: Check whitelist registers across resets")Signed-off-by Oscar Mateo <[email protected]>Cc Chris Wilson <[email protected]>
Serves me right for forgetting to check with smatch myself.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx