Skip to contentSkip to conversation

patch "ARM: amba: Make driver_override output consistent with other buses" added to char-misc-linus

PATCH [email protected] 1 participant 1 message Apr 26, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ARM: amba: Make driver_override output consistent with other buses

to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From 5f53624662eaac89598641cee6cd54fc192572d9 Mon Sep 17 00:00:00 2001

From: Geert Uytterhoeven <[email protected]>
Date: Tue, 10 Apr 2018 15:21:43 +0200
Subject: ARM: amba: Make driver_override output consistent with other buses

For AMBA devices with unconfigured driver override, the "driver_override" sysfs virtual file is empty, while it contains "(null)" for platform and PCI devices.

Make AMBA consistent with other buses by dropping the test for a NULL pointer.

Note that contrary to popular belief, sprintf() handles NULL pointers fine; they are printed as "(null)".

---
 drivers/amba/bus.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/amba/bus.c +0 -3
index fac8e36de11e..f8c01fbef64d 100644
@@ -70,9 +70,6 @@ static ssize_t driver_override_show(struct device *_dev,
 {
 	struct amba_device *dev = to_amba_device(_dev);
 
-	if (!dev->driver_override)
-		return 0;
-
 	return sprintf(buf, "%s\n", dev->driver_override);
 }
 
Signature · 1 line
2.17.0