Skip to contentSkip to conversation

FAILED: patch "[PATCH] IB/mlx5: Fix represent correct netdevice in dual port RoCE" failed to apply to 4.16-stable tree

PATCH [email protected] 1 participant 1 message May 5, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.16-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 84a6a7a99c0ac2f67366288c0625c9fba176b264 Mon Sep 17 00:00:00 2001

From: Parav Pandit <[email protected]>
Date: Mon, 23 Apr 2018 17:01:55 +0300
Subject: [PATCH] IB/mlx5: Fix represent correct netdevice in dual port RoCE

In commit bcf87f1dbbec ("IB/mlx5: Listen to netdev register/unresiter events in switchdev mode") incorrectly mapped primary device's netdevice to 2nd port netdevice.
It always represented primary port's netdevice for 2nd port netdevice
when ib representors were not used.

This results into failing to process CM request arriving on 2nd port due to incorrect mapping of netdevice.

This fix corrects it by considering the right mdev.

Cc <[email protected]> # 4.16
Fixes bcf87f1dbbec ("IB/mlx5: Listen to netdev register/unresiter events in switchdev mode")
drivers/infiniband/hw/mlx5/main.c +1 -1
index 6a749c02b14c..78a4b2797057 100644
@@ -179,7 +179,7 @@ static int mlx5_netdev_event(struct notifier_block *this,
 			if (rep_ndev == ndev)
 				roce->netdev = (event == NETDEV_UNREGISTER) ?
 					NULL : ndev;
-		} else if (ndev->dev.parent == &ibdev->mdev->pdev->dev) {
+		} else if (ndev->dev.parent == &mdev->pdev->dev) {
 			roce->netdev = (event == NETDEV_UNREGISTER) ?
 				NULL : ndev;
 		}