Skip to contentSkip to conversation

fsi: scom: Remove PIB reset during probe

PATCH In review Eddie James 2 participants 2 messages May 8, 2018 – May 9, 2018 FSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fsi: scom: Remove PIB reset during probe

The PIB reset causes problems for the running P9 chip. The reset shouldn't be performed by this driver.

---
 drivers/fsi/fsi-scom.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/fsi/fsi-scom.c +0 -8
index e13353a..c8eb5e5 100644
@@ -26,15 +26,11 @@
 
 #define FSI_ENGID_SCOM		0x5
 
-#define SCOM_FSI2PIB_DELAY	50
-
 /* SCOM engine register set */
 #define SCOM_DATA0_REG		0x00
 #define SCOM_DATA1_REG		0x04
 #define SCOM_CMD_REG		0x08
-#define SCOM_RESET_REG		0x1C
 
-#define SCOM_RESET_CMD		0x80000000
 #define SCOM_WRITE_CMD		0x80000000
 
 struct scom_device {
@@ -180,7 +176,6 @@ static loff_t scom_llseek(struct file *file, loff_t offset, int whence)
 
 static int scom_probe(struct device *dev)
 {
-	uint32_t data;
 	struct fsi_device *fsi_dev = to_fsi_dev(dev);
 	struct scom_device *scom;
 
@@ -197,9 +192,6 @@ static int scom_probe(struct device *dev)
 	scom->mdev.parent = dev;
 	list_add(&scom->link, &scom_devices);
 
-	data = cpu_to_be32(SCOM_RESET_CMD);
-	fsi_device_write(fsi_dev, SCOM_RESET_REG, &data, sizeof(uint32_t));
-
 	return misc_register(&scom->mdev);
 }
 
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 46 lines · Eddie James

The PIB reset causes problems for the running P9 chip. The reset shouldn't be performed by this driver.

---
  drivers/fsi/fsi-scom.c | 8 --------
  1 file changed, 8 deletions(-)
drivers/fsi/fsi-scom.c +0 -8
index e13353a..c8eb5e5 100644
@@ -26,15 +26,11 @@
 
  #define FSI_ENGID_SCOM		0x5
 
-#define SCOM_FSI2PIB_DELAY	50
-
  /* SCOM engine register set */
  #define SCOM_DATA0_REG		0x00
  #define SCOM_DATA1_REG		0x04
  #define SCOM_CMD_REG		0x08
-#define SCOM_RESET_REG		0x1C
 
-#define SCOM_RESET_CMD		0x80000000
  #define SCOM_WRITE_CMD		0x80000000
 
  struct scom_device {
@@ -180,7 +176,6 @@ static loff_t scom_llseek(struct file *file, loff_t offset, int whence)
 
  static int scom_probe(struct device *dev)
  {
-	uint32_t data;
  	struct fsi_device *fsi_dev = to_fsi_dev(dev);
  	struct scom_device *scom;
 
@@ -197,9 +192,6 @@ static int scom_probe(struct device *dev)
  	scom->mdev.parent = dev;
  	list_add(&scom->link, &scom_devices);
 
-	data = cpu_to_be32(SCOM_RESET_CMD);
-	fsi_device_write(fsi_dev, SCOM_RESET_REG, &data, sizeof(uint32_t));
-
  	return misc_register(&scom->mdev);
  }